Re: [Virtio-fs] [PATCH 1/2] vitriofsd/passthrough_ll: Make fallocate() work

2020-01-14 Thread Dr. David Alan Gilbert
* Xiao Yang (yangx...@cn.fujitsu.com) wrote: > On 2020/1/14 20:14, Dr. David Alan Gilbert 写wrote: > > Thanks; I've merged the fh fix into Stefan's 'add fd_map to hide file > > descriptors' > > patch. > > > > I'll merge the ifdef fix with your next fix and take it as a separate > > patch. > Hi

Re: [Virtio-fs] [PATCH 1/2] vitriofsd/passthrough_ll: Make fallocate() work

2020-01-14 Thread Xiao Yang
On 2020/1/14 20:14, Dr. David Alan Gilbert 写wrote: Thanks; I've merged the fh fix into Stefan's 'add fd_map to hide file descriptors' patch. I'll merge the ifdef fix with your next fix and take it as a separate patch. Hi Dave, Thanks for your review and explanation. Do you mean that I don't

Re: [Virtio-fs] [PATCH 1/2] vitriofsd/passthrough_ll: Make fallocate() work

2020-01-14 Thread Dr. David Alan Gilbert
* Xiao Yang (yangx...@cn.fujitsu.com) wrote: > 1) Use correct CONFIG_FALLOCATE macro to check if fallocate() is > supported.(i.e configure >script sets CONFIG_FALLOCATE intead of HAVE_FALLOCATE if fallocate() is > supported) > 2) Avoid 'Bad file descriptor' error by passing correct fd to