Re: [Virtio-fs] [PATCH v2 0/3] virtiofsd capability changes and addition
* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: > From: "Dr. David Alan Gilbert" > > Hi, > This is a set of changes relating to the capability restirctions > introduced in virtiofsd back in a59feb483b8. > > The first one is a potentially important fix; the missing terminator > could mean extra capabilities are added based on junk on the stack; > although that's not been seen in practice. > > Signed-off-by: Dr. David Alan Gilbert Queued > > v2 > Pass a copy of the parameter list into setup_capabilities > > Dr. David Alan Gilbert (3): > virtiofsd: Terminate capability list > virtiofsd: Check capability calls > virtiofsd: Allow addition or removal of capabilities > > docs/tools/virtiofsd.rst | 5 +++ > tools/virtiofsd/helper.c | 2 + > tools/virtiofsd/passthrough_ll.c | 71 +--- > 3 files changed, 73 insertions(+), 5 deletions(-) > > -- > 2.26.2 > > -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK ___ Virtio-fs mailing list Virtio-fs@redhat.com https://www.redhat.com/mailman/listinfo/virtio-fs
Re: [Virtio-fs] [PATCH v2 0/3] virtiofsd capability changes and addition
On Mon, Jun 29, 2020 at 12:54:17PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Hi, > This is a set of changes relating to the capability restirctions > introduced in virtiofsd back in a59feb483b8. > > The first one is a potentially important fix; the missing terminator > could mean extra capabilities are added based on junk on the stack; > although that's not been seen in practice. > > Signed-off-by: Dr. David Alan Gilbert > > v2 > Pass a copy of the parameter list into setup_capabilities > > Dr. David Alan Gilbert (3): > virtiofsd: Terminate capability list > virtiofsd: Check capability calls > virtiofsd: Allow addition or removal of capabilities > > docs/tools/virtiofsd.rst | 5 +++ > tools/virtiofsd/helper.c | 2 + > tools/virtiofsd/passthrough_ll.c | 71 +--- > 3 files changed, 73 insertions(+), 5 deletions(-) > > -- > 2.26.2 > Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature ___ Virtio-fs mailing list Virtio-fs@redhat.com https://www.redhat.com/mailman/listinfo/virtio-fs
Re: [Virtio-fs] [PATCH v2 0/3] virtiofsd capability changes and addition
On Mon, Jun 29, 2020 at 12:54:17PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Hi, > This is a set of changes relating to the capability restirctions > introduced in virtiofsd back in a59feb483b8. > > The first one is a potentially important fix; the missing terminator > could mean extra capabilities are added based on junk on the stack; > although that's not been seen in practice. > > Signed-off-by: Dr. David Alan Gilbert > Acked-by: Vivek Goyal Mounting overlayfs on top of virtiofs now works for me once I gave CAP_SYS_ADMIN to daemon. Thanks Vivek > v2 > Pass a copy of the parameter list into setup_capabilities > > Dr. David Alan Gilbert (3): > virtiofsd: Terminate capability list > virtiofsd: Check capability calls > virtiofsd: Allow addition or removal of capabilities > > docs/tools/virtiofsd.rst | 5 +++ > tools/virtiofsd/helper.c | 2 + > tools/virtiofsd/passthrough_ll.c | 71 +--- > 3 files changed, 73 insertions(+), 5 deletions(-) > > -- > 2.26.2 > ___ Virtio-fs mailing list Virtio-fs@redhat.com https://www.redhat.com/mailman/listinfo/virtio-fs
