Re: [Virtio-fs] [PATCH v3 07/20] virtio: add vhost-user-base and a generic vhost-user-device

2023-09-06 Thread Matias Ezequiel Vara Larsen
On Tue, Sep 05, 2023 at 06:01:56PM +0100, Alex Bennée wrote: > > Matias Ezequiel Vara Larsen writes: > > > On Mon, Jul 10, 2023 at 04:35:09PM +0100, Alex Bennée wrote: > >> In theory we shouldn't need to repeat so much boilerplate to support > >> vhost-user backends. This provides a generic

Re: [Virtio-fs] [PATCH v3 07/20] virtio: add vhost-user-base and a generic vhost-user-device

2023-09-05 Thread Alex Bennée
Matias Ezequiel Vara Larsen writes: > On Mon, Jul 10, 2023 at 04:35:09PM +0100, Alex Bennée wrote: >> In theory we shouldn't need to repeat so much boilerplate to support >> vhost-user backends. This provides a generic vhost-user-base QOM >> object and a derived vhost-user-device for which the

Re: [Virtio-fs] [PATCH v3 07/20] virtio: add vhost-user-base and a generic vhost-user-device

2023-09-05 Thread Matias Ezequiel Vara Larsen
On Mon, Jul 10, 2023 at 04:35:09PM +0100, Alex Bennée wrote: > In theory we shouldn't need to repeat so much boilerplate to support > vhost-user backends. This provides a generic vhost-user-base QOM > object and a derived vhost-user-device for which the user needs to > provide the few bits of

Re: [Virtio-fs] [PATCH v3 07/20] virtio: add vhost-user-base and a generic vhost-user-device

2023-07-10 Thread Michael S. Tsirkin
> +static const TypeInfo vud_info = { > +.name = TYPE_VHOST_USER_DEVICE, > +.parent = TYPE_VHOST_USER_BASE, > +.instance_size = sizeof(VHostUserBase), > +.class_init = vud_class_init, > +.class_size = sizeof(VHostUserBaseClass), I wish you didn't tie the refactoring in with