Re: [Virtio-fs] [PATCH v4 2/8] vhost-user.rst: Improve [GS]ET_VRING_BASE doc

2023-10-07 Thread Michael S. Tsirkin
On Fri, Oct 06, 2023 at 03:58:44PM +0200, Hanna Czenczek wrote: > On 06.10.23 15:55, Hanna Czenczek wrote: > > On 06.10.23 10:49, Michael S. Tsirkin wrote: > > > On Fri, Oct 06, 2023 at 09:53:53AM +0200, Hanna Czenczek wrote: > > > > On 05.10.23 19:38, Stefan Hajnoczi wrote: > > > > > On Wed, Oct

Re: [Virtio-fs] [PATCH v4 2/8] vhost-user.rst: Improve [GS]ET_VRING_BASE doc

2023-10-07 Thread Michael S. Tsirkin
On Fri, Oct 06, 2023 at 03:55:56PM +0200, Hanna Czenczek wrote: > On 06.10.23 10:49, Michael S. Tsirkin wrote: > > On Fri, Oct 06, 2023 at 09:53:53AM +0200, Hanna Czenczek wrote: > > > On 05.10.23 19:38, Stefan Hajnoczi wrote: > > > > On Wed, Oct 04, 2023 at 02:58:58PM +0200, Hanna Czenczek wrote:

Re: [Virtio-fs] [PATCH v4 2/8] vhost-user.rst: Improve [GS]ET_VRING_BASE doc

2023-10-06 Thread Hanna Czenczek
On 06.10.23 15:55, Hanna Czenczek wrote: On 06.10.23 10:49, Michael S. Tsirkin wrote: On Fri, Oct 06, 2023 at 09:53:53AM +0200, Hanna Czenczek wrote: On 05.10.23 19:38, Stefan Hajnoczi wrote: On Wed, Oct 04, 2023 at 02:58:58PM +0200, Hanna Czenczek wrote: [...]   

Re: [Virtio-fs] [PATCH v4 2/8] vhost-user.rst: Improve [GS]ET_VRING_BASE doc

2023-10-06 Thread Hanna Czenczek
On 06.10.23 10:49, Michael S. Tsirkin wrote: On Fri, Oct 06, 2023 at 09:53:53AM +0200, Hanna Czenczek wrote: On 05.10.23 19:38, Stefan Hajnoczi wrote: On Wed, Oct 04, 2023 at 02:58:58PM +0200, Hanna Czenczek wrote: GET_VRING_BASE does not mention that it stops the respective ring. Fix that.

Re: [Virtio-fs] [PATCH v4 2/8] vhost-user.rst: Improve [GS]ET_VRING_BASE doc

2023-10-06 Thread Michael S. Tsirkin
On Fri, Oct 06, 2023 at 09:53:53AM +0200, Hanna Czenczek wrote: > On 05.10.23 19:38, Stefan Hajnoczi wrote: > > On Wed, Oct 04, 2023 at 02:58:58PM +0200, Hanna Czenczek wrote: > > > GET_VRING_BASE does not mention that it stops the respective ring. Fix > > > that. > > > > > > Furthermore, it is

Re: [Virtio-fs] [PATCH v4 2/8] vhost-user.rst: Improve [GS]ET_VRING_BASE doc

2023-10-06 Thread Hanna Czenczek
On 05.10.23 19:38, Stefan Hajnoczi wrote: On Wed, Oct 04, 2023 at 02:58:58PM +0200, Hanna Czenczek wrote: GET_VRING_BASE does not mention that it stops the respective ring. Fix that. Furthermore, it is not fully clear what the "base offset" these commands' documentation refers to is; an

Re: [Virtio-fs] [PATCH v4 2/8] vhost-user.rst: Improve [GS]ET_VRING_BASE doc

2023-10-05 Thread Stefan Hajnoczi
On Wed, Oct 04, 2023 at 02:58:58PM +0200, Hanna Czenczek wrote: > GET_VRING_BASE does not mention that it stops the respective ring. Fix > that. > > Furthermore, it is not fully clear what the "base offset" these > commands' documentation refers to is; an offset could be many things. > Be more