Re: [VirtualGL-Devel] Allowing glIndex() for RGB Visuals

2014-09-09 Thread Nathan Kidd
On 06/09/14 01:12 AM, DRC wrote: Ugh. I wonder aloud whether it's worth it to continue supporting color index mode at all. Are any apps still using that? I rarely, if ever, have seen it, but then I mostly see apps where there is a rendering/performance issue which somewhat self-selects for n

Re: [VirtualGL-Devel] Allowing glIndex() for RGB Visuals

2014-09-09 Thread Nathan Kidd
On 09/09/14 02:59 PM, Nathan Kidd wrote: > What do you think of the attached patch? Applies to trunk with > > patch -p0 -i only-emulate-ci-for-ci-visuals.patch That should have had at least, s/emulateColorIndex/_emulateColorIndex/ for (more) namespace safety. -Nathan --

Re: [VirtualGL-Devel] Allowing glIndex() for RGB Visuals

2014-09-09 Thread Nathan Kidd
On 09/09/14 02:59 PM, Nathan Kidd wrote: > You'll notice that glReadPixels() comments out the emulateColorIndex() > check. When glReadPixels() is called by VirtualDrawable::readPixels() > the current context is the *temp* context, so glxCurrentContext()-based > lookups fail. This means that up to