Re: [PATCH 2/3] virtio: Net header needs gso_hdr_len

2008-01-15 Thread Rusty Russell
On Wednesday 16 January 2008 11:06:21 Herbert Xu wrote: > Rusty Russell <[EMAIL PROTECTED]> wrote: > > It's far easier to deal with GSO if we don't have to parse the packet > > to figure out the header length. Add the field to the virtio_net_hdr > > struct (and fix the spaces that somehow crept in

Re: [PATCH 2/3] virtio: Net header needs gso_hdr_len

2008-01-15 Thread Herbert Xu
Rusty Russell <[EMAIL PROTECTED]> wrote: > It's far easier to deal with GSO if we don't have to parse the packet > to figure out the header length. Add the field to the virtio_net_hdr > struct (and fix the spaces that somehow crept in there). > > Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> >

Re: [PATCH 1/3] skb_partial_csum_set

2008-01-15 Thread Rusty Russell
On Tuesday 15 January 2008 22:14:22 David Miller wrote: > From: Rusty Russell <[EMAIL PROTECTED]> > Date: Tue, 15 Jan 2008 21:41:55 +1100 > > > Implement skb_partial_csum_set, for setting partial csums on untrusted > > packets. > > > > Use it in virtio_net (replacing buggy version there), it's also

Re: [PATCH] KVM virtio balloon driver

2008-01-15 Thread Marcelo Tosatti
On Tue, Jan 15, 2008 at 10:32:08AM +1100, Rusty Russell wrote: > On Tuesday 15 January 2008 07:03:57 Marcelo Tosatti wrote: > > Hi Rusty, > > > > It was agreed that the balloon driver should be merged through the > > virtio tree, so here it goes. It depends on the config_changed patch > > posted ea

Re: [PATCH 1/3] skb_partial_csum_set

2008-01-15 Thread David Miller
From: Rusty Russell <[EMAIL PROTECTED]> Date: Tue, 15 Jan 2008 21:41:55 +1100 > Implement skb_partial_csum_set, for setting partial csums on untrusted > packets. > > Use it in virtio_net (replacing buggy version there), it's also going > to be used by TAP for partial csum support. > > Signed-of

Re: [PATCH] KVM virtio balloon driver

2008-01-15 Thread Marcelo Tosatti
On Mon, Jan 14, 2008 at 03:29:45PM -0600, Anthony Liguori wrote: > Marcelo Tosatti wrote: > >Hi Rusty, > > > >It was agreed that the balloon driver should be merged through the > >virtio tree, so here it goes. It depends on the config_changed patch > >posted earlier. > > > > > >- > > > >Followi

[PATCH 2/3] virtio: Net header needs gso_hdr_len

2008-01-15 Thread Rusty Russell
It's far easier to deal with GSO if we don't have to parse the packet to figure out the header length. Add the field to the virtio_net_hdr struct (and fix the spaces that somehow crept in there). Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> --- drivers/net/virtio_net.c |4 +++- include

[PATCH 3/3] tun/tap GSO/partial csum support

2008-01-15 Thread Rusty Russell
This implements partial checksum and GSO support for tun/tap. We use the virtio_net_hdr: it is an ABI already and designed to encapsulate such metadata as GSO and partial checksums. lguest performance (160MB sendfile, worst/best/avg, 20 runs): Before: 5.06/3.39/3.82 After: 4.69/0

[PATCH 1/3] skb_partial_csum_set

2008-01-15 Thread Rusty Russell
Implement skb_partial_csum_set, for setting partial csums on untrusted packets. Use it in virtio_net (replacing buggy version there), it's also going to be used by TAP for partial csum support. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> --- drivers/net/virtio_net.c | 11 +-- incl