Re: [Qemu-devel] [PATCH 04/11] qemu: helper routines for pci access.

On Tue, May 26, 2009 at 11:33:37AM +0900, Isaku Yamahata wrote: On Mon, May 25, 2009 at 03:25:33PM +0300, Michael S. Tsirkin wrote: Add inline routines for convenient access to pci devices with correct (little) endianness. Will be used by MSI-X support. Just a minor comment. How about to

Re: [Qemu-devel] [PATCH 04/11] qemu: helper routines for pci access.

Michael S. Tsirkin wrote: On Tue, May 26, 2009 at 11:33:37AM +0900, Isaku Yamahata wrote: On Mon, May 25, 2009 at 03:25:33PM +0300, Michael S. Tsirkin wrote: Add inline routines for convenient access to pci devices with correct (little) endianness. Will be used by MSI-X support.

Re: [PATCH] qemu: virtio save/load bindings

Michael S. Tsirkin wrote: Implement bindings for virtio save/load. Use them in virtio pci. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Is anyone working to fill in load/save bindings so that saving virtio devices works? Here's a trivial patch to do this (this one is on top of my

Re: [Qemu-devel] [PATCH 03/11] qemu: add routines to manage PCI capabilities

On Mon, May 25, 2009 at 03:25:20PM +0300, Michael S. Tsirkin wrote: Add routines to manage PCI capability list. First user will be MSI-X. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/pci.c | 98 -- hw/pci.h | 18

Re: [Qemu-devel] [PATCH 03/11] qemu: add routines to manage PCI capabilities

On Tue, May 26, 2009 at 05:49:26PM +0900, Isaku Yamahata wrote: On Mon, May 25, 2009 at 03:25:20PM +0300, Michael S. Tsirkin wrote: Add routines to manage PCI capability list. First user will be MSI-X. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/pci.c | 98

[PATCH] qemu: fix pci_find_capability for multiple caps

pci_find_capability_list has a bug so it'd stop at the first capability. This only happens to work as we only support a single capability (MSI-X). Here's a fix. Found-by: Isaku Yamahata yamah...@valinux.co.jp Signed-off-by: Michael S. Tsirkin m...@redhat.com --- This is a fixup for my patch

Re: [PATCH] qemu: virtio save/load bindings

-/* FIXME: load/save binding. */ -//pci_device_save(vdev-pci_dev, f); -//msix_save(vdev-pci_dev, f); qdev regressed save/restore? What else is broken right now from the qdev commit? I'm beginning to think committing in the state it was in was a mistake. Paul, can you put

[patch 1/2] virtio: fix id_matching for virtio drivers

From: Christian Borntraeger borntrae...@de.ibm.com This bug never appeared, since all current virtio drivers use VIRTIO_DEV_ANY_ID for the vendor field. If a real vendor would be used, the check in virtio_id_match is wrong - it returns 0 if id-vendor == dev-id.vendor. Signed-off-by: Christian

[patch 2/2] virtio: enhance id_matching for virtio drivers

From: Christian Borntraeger borntrae...@de.ibm.com This patch allows a virtio driver to use VIRTIO_DEV_ANY_ID for the device id. This will be used by a test module that can be bound to any virtio device. Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- drivers/virtio/virtio.c |

[patch 0/2] Fix and enhance virtio device id matching

Hello Rusty, here are two patches that change the device matching of the virtio bus. The patches have been refreshed agains linux-next and should apply to your private virtio tree. OK for linux-next? Christian ___ Virtualization mailing list

Re: lguest PAE

Matias Zabaljauregui wrote: Jeremy, I fixed the code following your comments (hope you still remember). I'd like to ask you again about this one: /* Found in switcher.S */ extern unsigned long default_idt_entries[]; diff --git a/arch/x86/include/asm/lguest_hcall.h

Re: [patch 0/2] Fix and enhance virtio device id matching

On Tue, 26 May 2009 11:16:08 pm Christian Borntraeger wrote: Hello Rusty, here are two patches that change the device matching of the virtio bus. The patches have been refreshed agains linux-next and should apply to your private virtio tree. OK for linux-next? Sure, added. Thanks! Rusty.