Multiple port support for virtio-console

2009-09-03 Thread Amit Shah
Hello all, Here is a new iteration of the patch series that implements a transport for guest and host communications. I've tested for compatibility (old qemu new kernel, new qemu old kernel, new qemu new kernel) and it all works fine*. There are a few items on my todo list but this works

[PATCH 1/1] virtio_console: Add interface for guest and host communication

2009-09-03 Thread Amit Shah
Expose multiple char devices (ports) for simple communication between the host userspace and guest. Sample offline usages can be: poking around in a guest to find out the file systems used, applications installed, etc. Online usages can be sharing of clipboard data between the guest and the host,

[PATCH 1/2] char: Emit 'OPENED' events on char device open

2009-09-03 Thread Amit Shah
Notify users of the char interface whenever the file / connection is opened. The existing RESET event is triggered when the qemu char state is reset as well; which may not be as interesting as char device open events. Signed-off-by: Amit Shah amit.s...@redhat.com --- qemu-char.c | 14

[PATCH 2/2] virtio-console: Add interface for generic guest-host communication

2009-09-03 Thread Amit Shah
This interface extends the virtio-console device to handle multiple ports that present a char device from which bits can be sent and read. Sample uses for such a device can be obtaining info from the guest like the file systems used, apps installed, etc. for offline usage and logged-in users,

Re: [PATCH 2/2] virtio-console: Add interface for generic guest-host communication

2009-09-03 Thread Juan Quintela
Amit Shah amit.s...@redhat.com wrote: This interface extends the virtio-console device to handle multiple ports that present a char device from which bits can be sent and read. Sample uses for such a device can be obtaining info from the guest like the file systems used, apps installed, etc.

Re: [PATCH 2/2] virtio-console: Add interface for generic guest-host communication

2009-09-03 Thread Amit Shah
Hi Juan, On (Thu) Sep 03 2009 [16:06:54], Juan Quintela wrote: diff --git a/hw/virtio-console.c b/hw/virtio-console.c index 663c8b9..da590d2 100644 --- a/hw/virtio-console.c +++ b/hw/virtio-console.c #include hw.h +#include monitor.h +#include pci.h +#include sys-queue.h

Re: [Qemu-devel] Re: [PATCH 2/2] virtio-console: Add interface for generic guest-host communication

2009-09-03 Thread Amit Shah
On (Thu) Sep 03 2009 [19:56:05], Amit Shah wrote: Hi Juan, On (Thu) Sep 03 2009 [16:06:54], Juan Quintela wrote: diff --git a/hw/virtio-console.c b/hw/virtio-console.c index 663c8b9..da590d2 100644 --- a/hw/virtio-console.c +++ b/hw/virtio-console.c #include hw.h

Re: [PATCH 2/2] virtio-console: Add interface for generic guest-host communication

2009-09-03 Thread Juan Quintela
Amit Shah amit.s...@redhat.com wrote: Hi +static void virtio_console_set_port_active(uint32_t idx) +{ +int i = 0; + +while (idx / 32) { +i++; +idx -= 32; +} It is just me, or you are doing a division + modulus in a very strange way?

[PATCH resend] block: silently error unsupported empty barriers too

2009-09-03 Thread Mark McLoughlin
With 2.6.31-rc5 in a KVM guest using dm and virtio_blk, we see the following errors: end_request: I/O error, dev vda, sector 0 end_request: I/O error, dev vda, sector 0 The errors go away if dm stops submitting empty barriers, by reverting: commit 52b1fd5a27c625c78373e024bf570af3c9d44a79

Re: [PATCHv5 3/3] vhost_net: a kernel-level virtio server

2009-09-03 Thread Ira W. Snyder
On Thu, Aug 27, 2009 at 07:07:50PM +0300, Michael S. Tsirkin wrote: What it is: vhost net is a character device that can be used to reduce the number of system calls involved in virtio networking. Existing virtio net code is used in the guest without modification. There's similarity with