Re: [PATCH] SCSI driver for VMware's virtual HBA - V4.

2009-09-09 Thread Anthony Liguori
Jeremy Fitzhardinge wrote: > On 09/09/09 16:34, Anthony Liguori wrote: > >> We haven't even been successful in getting the Xen folks to present >> their work on lkml before shipping it to their users. Why would we >> expect more from VMware if we're willing to merge the Xen stuff? >> >>

Re: [PATCH] SCSI driver for VMware's virtual HBA - V4.

2009-09-09 Thread Jeremy Fitzhardinge
On 09/09/09 16:34, Anthony Liguori wrote: > We haven't even been successful in getting the Xen folks to present > their work on lkml before shipping it to their users. Why would we > expect more from VMware if we're willing to merge the Xen stuff? > The Xen code may be out of tree, but it ha

Re: [PATCH] SCSI driver for VMware's virtual HBA - V4.

2009-09-09 Thread Anthony Liguori
Christoph Hellwig wrote: > On Wed, Sep 09, 2009 at 05:12:26PM -0500, Anthony Liguori wrote: > >> Alok Kataria wrote: >> >>> I see your point, but the ring logic or the ABI that we use to >>> communicate between the hypervisor and guest is not shared between our >>> storage and network drive

Re: [PATCH] SCSI driver for VMware's virtual HBA - V4.

2009-09-09 Thread Christoph Hellwig
On Wed, Sep 09, 2009 at 05:12:26PM -0500, Anthony Liguori wrote: > Alok Kataria wrote: >> I see your point, but the ring logic or the ABI that we use to >> communicate between the hypervisor and guest is not shared between our >> storage and network drivers. As a result, I don't see any benefit of

Re: [PATCH] SCSI driver for VMware's virtual HBA - V4.

2009-09-09 Thread Anthony Liguori
Alok Kataria wrote: > I see your point, but the ring logic or the ABI that we use to > communicate between the hypervisor and guest is not shared between our > storage and network drivers. As a result, I don't see any benefit of > separating out this ring handling mechanism, on the contrary it migh

Re: [PATCH] SCSI driver for VMware's virtual HBA - V4.

2009-09-09 Thread Alok Kataria
Hi Anthony, On Wed, 2009-09-09 at 14:00 -0700, Anthony Liguori wrote: > Hi Alok, > > Joining this a bit late as this was just brought to my attention. It > would have been nice to CC the virtualization mailing list. Please do > in future submissions. Sure. > > Alok Kataria wrote: > > VMwar

Re: [PATCH] SCSI driver for VMware's virtual HBA - V4.

2009-09-09 Thread Anthony Liguori
Hi Alok, Joining this a bit late as this was just brought to my attention. It would have been nice to CC the virtualization mailing list. Please do in future submissions. Alok Kataria wrote: > VMware PVSCSI driver - v4. > / > > diff --git a/drivers/scsi/pvscsi.h b/drivers/scsi/pvscsi.h > n

[PATCH 2/5] virtio-console: Add support for multiple ports for generic guest-host communication

2009-09-09 Thread Amit Shah
This interface extends the virtio-console device to handle multiple ports that present a char device from which bits can be sent and read. Sample uses for such a device can be obtaining info from the guest like the file systems used, apps installed, etc. for offline usage and logged-in users, clip

[PATCH 5/5] vnc: Send / receive guest clipboard if virtio-console connected to clipboard port

2009-09-09 Thread Amit Shah
If a connection to the guest clipboard is open, send the host clipboard to the guest and guest clipboard to the host on any change Signed-off-by: Amit Shah --- hw/virtio-console.h |1 + vnc.c | 33 + 2 files changed, 34 insertions(+), 0 deletio

[PATCH 3/5] virtio-console: in-qemu api for open/read/write/close ports

2009-09-09 Thread Amit Shah
This is a simple-to-use api for opening a port, registering a callback for reading stuff, writing to a port and closing it. Another api for hot-adding a port can be provided. Signed-off-by: Amit Shah --- hw/virtio-console.c | 61 -- hw/virtio-co

[PATCH 4/5] vnc: add a is_vnc_active() helper

2009-09-09 Thread Amit Shah
This helper is introduced to query the status of vnc. Signed-off-by: Amit Shah --- vnc.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/vnc.c b/vnc.c index 5eaef6a..ff2d4a8 100644 --- a/vnc.c +++ b/vnc.c @@ -178,9 +178,17 @@ static void do_info_vnc_client(Monit

[PATCH 1/5] char: Emit 'OPENED' events on char device open

2009-09-09 Thread Amit Shah
Notify users of the char interface whenever the file / connection is opened. The existing RESET event is triggered when the qemu char state is reset as well; which may not be as interesting as char device open events. Signed-off-by: Amit Shah --- qemu-char.c | 14 +- qemu-char.h |

Multiple Port Support for virtio-console

2009-09-09 Thread Amit Shah
Hello all, Here is a new iteration of the patch series that implements a transport for guest and host communications. I've tested for compatibility (old qemu & new kernel, new qemu & old kernel, new qemu & new kernel) and it all works fine*. Migration works with the patch Juan just posted. Ther

[PATCH] virtio_console: Add support for multiple ports for generic guest and host communication

2009-09-09 Thread Amit Shah
Expose multiple char devices ("ports") for simple communication between the host userspace and guest. Sample offline usages can be: poking around in a guest to find out the file systems used, applications installed, etc. Online usages can be sharing of clipboard data between the guest and the host