[PATCH 6/6] virtio_blk: revert QUEUE_FLAG_VIRT addition

2009-09-21 Thread Rusty Russell
From: Christoph Hellwig h...@lst.de It seems like the addition of QUEUE_FLAG_VIRT caueses major performance regressions for Fedora users: https://bugzilla.redhat.com/show_bug.cgi?id=509383 https://bugzilla.redhat.com/show_bug.cgi?id=505695 while I can't reproduce those extreme

[PATCH 5/6] virtio_blk: set QUEUE_ORDERED_DRAIN by default

2009-09-21 Thread Rusty Russell
From: Christoph Hellwig h...@lst.de Currently virtio-blk doesn't set any QUEUE_ORDERED_ flag by default, which means it does not allow filesystems to use barriers. But the typical use case for virtio-blk is to use a backed that uses synchronous I/O, and in that case we can simply set

[PATCH 2/6] virtio: make add_buf return capacity remaining

2009-09-21 Thread Rusty Russell
This API change means that virtio_net can tell how much capacity remains for buffers. It's necessarily fuzzy, since VIRTIO_RING_F_INDIRECT_DESC means we can fit any number of descriptors in one, *if* we can kmalloc. Signed-off-by: Rusty Russell ru...@rustcorp.com.au Cc: Dinesh Subhraveti

[PATCH 4/6] virtio: add virtio IDs file

2009-09-21 Thread Rusty Russell
From: =?UTF-8?B?RmVybmFuZG8gTHVpcyBWw6F6cXVleiBDYW8=?= Virtio IDs are spread all over the tree which makes assigning new IDs bothersome. Putting them together should make the process less error-prone. Signed-off-by: Fernando Luis Vazquez Cao ferna...@oss.ntt.co.jp Signed-off-by: Rusty Russell

[PATCH 3/5] lguest: use PGDIR_SHIFT for PAE code to allow different PAGE_OFFSET

2009-09-21 Thread Rusty Russell
We still assume the Guest and Host have the same PAGE_OFFSET settings, but now we don't assume 0xC000. Signed-off-by: Rusty Russell ru...@rustcorp.com.au Cc: Matias Zabaljauregui zabaljaure...@gmail.com --- drivers/lguest/page_tables.c |6 ++ 1 file changed, 2 insertions(+), 4

[PATCH 5/5] lguest: don't force VIRTIO_F_NOTIFY_ON_EMPTY

2009-09-21 Thread Rusty Russell
VIRTIO_F_NOTIFY_ON_EMPTY indicates to the Guest that we will hit them with an interrupt every time the xmit queue is emptied. Because it results in lots of tx interrupts, modern Guests probably don't want it, so let's only force it when they accept the option. Signed-off-by: Rusty Russell

[PATCH 4/5] lguest: cleanup for map_switcher()

2009-09-21 Thread Rusty Russell
From: Xiao Guangrong xiaoguangr...@cn.fujitsu.com We can use alloc_page() instead of get_zeroed_page() and virt_to_page() Signed-off-by: Xiao Guangrong xiaoguangr...@cn.fujitsu.com Signed-off-by: Rusty Russell ru...@rustcorp.com.au --- drivers/lguest/core.c |5 ++--- 1 file changed, 2

Re: [PATCH] virtio_console: Add support for multiple ports for generic guest and host communication

2009-09-21 Thread Alan Cox
Again, this is paravirtual serial device and I think it's entirely reasonable for people to hook up these ports in the guest directly to physical serial devices in the host. virtio doesn't support all those features. I fail to see how this is at all relevant. This is a virtual machine,

Re: Paravirtualization on VMware's Platform [VMI].

2009-09-21 Thread Arjan van de Ven
On Sun, 20 Sep 2009 09:42:47 +0200 Ingo Molnar mi...@elte.hu wrote: If we were able to rip out all (or most) of paravirt from arch/x86 it would be tempting for other technical reasons - but the patch above is well localized. interesting question is if this would allow us to remove a few of

Re: [RFC] Virtual Machine Device Queues(VMDq) support on KVM

2009-09-21 Thread Stephen Hemminger
On Mon, 21 Sep 2009 16:37:22 +0930 Rusty Russell ru...@rustcorp.com.au wrote: Actually this framework can apply to traditional network adapters which have just one tx/rx queue pair. And applications using the same user/kernel interface can utilize this framework to send/receive

Re: [RFC] Virtual Machine Device Queues(VMDq) support on KVM

2009-09-21 Thread Chris Wright
* Stephen Hemminger (shemmin...@vyatta.com) wrote: On Mon, 21 Sep 2009 16:37:22 +0930 Rusty Russell ru...@rustcorp.com.au wrote: Actually this framework can apply to traditional network adapters which have just one tx/rx queue pair. And applications using the same user/kernel

Re: [PATCH 2/5] lguest: use set_pte/set_pmd uniformly for real page table entries

2009-09-21 Thread Jeremy Fitzhardinge
On 09/21/09 00:22, Rusty Russell wrote: If we're building a pte, we can use simple assigment; only use set_pte etc. when we're actually going to use that destination as a PTE. I don't know that we'll ever run under Xen, but it's neater. I've always thought it would be a Neat Thing To Try.

Re: [PATCHv5 3/3] vhost_net: a kernel-level virtio server

2009-09-21 Thread Ira W. Snyder
On Wed, Sep 16, 2009 at 11:11:57PM -0400, Gregory Haskins wrote: Avi Kivity wrote: On 09/16/2009 10:22 PM, Gregory Haskins wrote: Avi Kivity wrote: On 09/16/2009 05:10 PM, Gregory Haskins wrote: If kvm can do it, others can. The problem is that you seem to

Re: [PATCH] virtio_console: Add support for multiple ports for generic guest and host communication

2009-09-21 Thread Rusty Russell
On Sat, 12 Sep 2009 01:30:10 am Alan Cox wrote: The interface presented to guest userspace is of a simple char device, so it can be used like this: fd = open(/dev/vcon2, O_RDWR); ret = read(fd, buf, 100); ret = write(fd, string, strlen(string)); Each port is to be