Re: [RESENDx2] [PULL] virtio: fix barriers for virtio-mmio

2011-12-23 Thread Linus Torvalds
On Thu, Dec 22, 2011 at 9:16 PM, Rusty Russell ru...@rustcorp.com.au wrote: This one as a signed tag on github, in case the inline patch was the reason you dropped this. No, and please why do you make your tag-names be your email address? That's just odd. It seems to be related to some broken

Re: [RESENDx2] [PULL] virtio: fix barriers for virtio-mmio

2011-12-23 Thread Linus Torvalds
On Fri, Dec 23, 2011 at 1:31 AM, Linus Torvalds torva...@linux-foundation.org wrote: So the whole thing looks confused. There's never any reason to actually use the expensive sfence/rfences at all. Afaik you still just want smp_*mb() for all cases. But note that I haven't thought deeply about

Re: [RESENDx2] [PULL] virtio: fix barriers for virtio-mmio

2011-12-23 Thread Ohad Ben-Cohen
On Fri, Dec 23, 2011 at 11:35 AM, Linus Torvalds torva...@linux-foundation.org wrote: On x86, there really is never any reason to use the heavy memory barriers unless you are talking to a real device. And last I saw, virtio was still about virtual IO. I reported this originally, so maybe I

Re: [RESENDx2] [PULL] virtio: fix barriers for virtio-mmio

2011-12-23 Thread Rusty Russell
On Fri, 23 Dec 2011 13:35:26 +0200, Ohad Ben-Cohen o...@wizery.com wrote: On Fri, Dec 23, 2011 at 11:35 AM, Linus Torvalds torva...@linux-foundation.org wrote: On x86, there really is never any reason to use the heavy memory barriers unless you are talking to a real device. And last I saw,