Re: [PATCH v2] virtio-scsi: hotplug support for virtio-scsi

2012-07-04 Thread Zhi Yong Wu
On Tue, Jul 3, 2012 at 1:41 PM, Cong Meng m...@linux.vnet.ibm.com wrote: This patch implements the hotplug support for virtio-scsi. When there is a device attached/detached, the virtio-scsi driver will be signaled via event virtual queue and it will add/remove the scsi device in question

Re: [PATCH v3 2/4] virtio_balloon: handle concurrent accesses to virtio_balloon struct elements

2012-07-04 Thread Rusty Russell
On Tue, 3 Jul 2012 20:48:50 -0300, Rafael Aquini aqu...@redhat.com wrote: This patch introduces access sychronization to critical elements of struct virtio_balloon, in order to allow the thread concurrency compaction/migration bits might ended up imposing to the balloon driver on several

Re: [PATCH v2] virtio-scsi: hotplug support for virtio-scsi

2012-07-04 Thread mc
Quoting Paolo Bonzini pbonz...@redhat.com: Il 03/07/2012 07:41, Cong Meng ha scritto: This patch implements the hotplug support for virtio-scsi. When there is a device attached/detached, the virtio-scsi driver will be signaled via event virtual queue and it will add/remove the scsi device in

Re: RFD: virtio balloon API use (was Re: [PATCH 5 of 5] virtio: expose added descriptors immediately)

2012-07-04 Thread Michael S. Tsirkin
On Tue, Jul 03, 2012 at 10:17:46AM +0930, Rusty Russell wrote: On Mon, 2 Jul 2012 13:08:19 -0300, Rafael Aquini aqu...@redhat.com wrote: As 'locking in balloon', may I assume the approach I took for the compaction case is OK and aligned to address these concerns of yours? If not, do not

Re: RFD: virtio balloon API use (was Re: [PATCH 5 of 5] virtio: expose added descriptors immediately)

2012-07-04 Thread Michael S. Tsirkin
On Mon, Jul 02, 2012 at 01:08:19PM -0300, Rafael Aquini wrote: On Mon, Jul 02, 2012 at 10:25:58AM +0300, Michael S. Tsirkin wrote: On Mon, Jul 02, 2012 at 10:35:47AM +0930, Rusty Russell wrote: On Sun, 1 Jul 2012 12:20:51 +0300, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Nov

Re: [PATCH v2] virtio-scsi: hotplug support for virtio-scsi

2012-07-04 Thread Paolo Bonzini
Il 04/07/2012 10:11, m...@linux.vnet.ibm.com ha scritto: Signed-off-by: Cong Meng m...@linux.vnet.ibm.com Signed-off-by: Sen Wang senw...@linux.vnet.ibm.com The SoB lines are swapped. Otherwise looks good. Since you have to respin, please add dropped event support too, it shouldn't be

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-04 Thread Michael S. Tsirkin
On Wed, Jul 04, 2012 at 04:24:00AM +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Hi folks, This series contains patches required to update tcm_vhost - virtio-scsi connected hosts - guests to run on v3.5-rc2 mainline code. This series is available on

Re: [PATCH 3/3] virtio-blk: Add bio-based IO path for virtio-blk

2012-07-04 Thread Paolo Bonzini
Il 03/07/2012 16:28, Dor Laor ha scritto: Users using a spinning disk still get IO scheduling in the host though. What benefit is there in doing it in the guest as well? The io scheduler waits for requests to merge and thus batch IOs together. It's not important w.r.t spinning disks since the

Re: [PATCH 5/6] virtio-scsi: Add vdrv-scan for post VIRTIO_CONFIG_S_DRIVER_OK LUN scanning

2012-07-04 Thread Paolo Bonzini
Il 04/07/2012 06:24, Nicholas A. Bellinger ha scritto: From: Nicholas Bellinger n...@linux-iscsi.org This patch changes virtio-scsi to use a new virtio_driver-scan() callback so that scsi_scan_host() can be properly invoked once virtio_dev_probe() has set add_status(dev,

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-04 Thread Paolo Bonzini
Il 04/07/2012 16:02, Michael S. Tsirkin ha scritto: On Wed, Jul 04, 2012 at 04:24:00AM +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Hi folks, This series contains patches required to update tcm_vhost - virtio-scsi connected hosts - guests to run on

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-04 Thread Michael S. Tsirkin
On Wed, Jul 04, 2012 at 04:52:00PM +0200, Paolo Bonzini wrote: Il 04/07/2012 16:02, Michael S. Tsirkin ha scritto: On Wed, Jul 04, 2012 at 04:24:00AM +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Hi folks, This series contains patches required to

Re: [PATCH] virtio-blk: allow toggling host cache between writeback and writethrough

2012-07-04 Thread Michael S. Tsirkin
On Tue, Jul 03, 2012 at 03:19:37PM +0200, Paolo Bonzini wrote: This patch adds support for the new VIRTIO_BLK_F_CONFIG_WCE feature, which exposes the cache mode in the configuration space and lets the driver modify it. The cache mode is exposed via sysfs. Even if the host does not support

Re: [PATCH] virtio-blk: allow toggling host cache between writeback and writethrough

2012-07-04 Thread Paolo Bonzini
Il 04/07/2012 17:42, Michael S. Tsirkin ha scritto: On Tue, Jul 03, 2012 at 03:19:37PM +0200, Paolo Bonzini wrote: This patch adds support for the new VIRTIO_BLK_F_CONFIG_WCE feature, which exposes the cache mode in the configuration space and lets the driver modify it. The cache mode is

Re: [PATCH] virtio-blk: allow toggling host cache between writeback and writethrough

2012-07-04 Thread Michael S. Tsirkin
On Wed, Jul 04, 2012 at 05:54:16PM +0200, Paolo Bonzini wrote: Il 04/07/2012 17:42, Michael S. Tsirkin ha scritto: On Tue, Jul 03, 2012 at 03:19:37PM +0200, Paolo Bonzini wrote: This patch adds support for the new VIRTIO_BLK_F_CONFIG_WCE feature, which exposes the cache mode in the

Re: [PATCH] virtio-blk: allow toggling host cache between writeback and writethrough

2012-07-04 Thread Paolo Bonzini
Il 04/07/2012 18:02, Michael S. Tsirkin ha scritto: On Wed, Jul 04, 2012 at 05:54:16PM +0200, Paolo Bonzini wrote: Il 04/07/2012 17:42, Michael S. Tsirkin ha scritto: On Tue, Jul 03, 2012 at 03:19:37PM +0200, Paolo Bonzini wrote: This patch adds support for the new VIRTIO_BLK_F_CONFIG_WCE

Re: [PATCH v3 2/4] virtio_balloon: handle concurrent accesses to virtio_balloon struct elements

2012-07-04 Thread Rafael Aquini
Howdy Rusty, First and foremost, thank you very much for taking the time to go through this proposal and provide me with such valuable feedback. I really appreciate that. On Wed, Jul 04, 2012 at 04:08:23PM +0930, Rusty Russell wrote: On Tue, 3 Jul 2012 20:48:50 -0300, Rafael Aquini

Re: [PATCH] virtio-blk: allow toggling host cache between writeback and writethrough

2012-07-04 Thread Michael S. Tsirkin
On Wed, Jul 04, 2012 at 06:08:50PM +0200, Paolo Bonzini wrote: Il 04/07/2012 18:02, Michael S. Tsirkin ha scritto: On Wed, Jul 04, 2012 at 05:54:16PM +0200, Paolo Bonzini wrote: Il 04/07/2012 17:42, Michael S. Tsirkin ha scritto: On Tue, Jul 03, 2012 at 03:19:37PM +0200, Paolo Bonzini

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-04 Thread Anthony Liguori
On 07/04/2012 10:05 AM, Michael S. Tsirkin wrote: On Wed, Jul 04, 2012 at 04:52:00PM +0200, Paolo Bonzini wrote: Il 04/07/2012 16:02, Michael S. Tsirkin ha scritto: On Wed, Jul 04, 2012 at 04:24:00AM +, Nicholas A. Bellinger wrote: From: Nicholas Bellingern...@linux-iscsi.org Hi folks,

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-04 Thread Nicholas A. Bellinger
Hi Anthony Co, On Wed, 2012-07-04 at 17:12 -0500, Anthony Liguori wrote: On 07/04/2012 10:05 AM, Michael S. Tsirkin wrote: On Wed, Jul 04, 2012 at 04:52:00PM +0200, Paolo Bonzini wrote: Il 04/07/2012 16:02, Michael S. Tsirkin ha scritto: On Wed, Jul 04, 2012 at 04:24:00AM +, Nicholas

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-04 Thread Nicholas A. Bellinger
On Wed, 2012-07-04 at 18:05 +0300, Michael S. Tsirkin wrote: On Wed, Jul 04, 2012 at 04:52:00PM +0200, Paolo Bonzini wrote: Il 04/07/2012 16:02, Michael S. Tsirkin ha scritto: On Wed, Jul 04, 2012 at 04:24:00AM +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger

[PATCH] tcm_vhost: Fix tv_cmd completion - release SGL memory leak

2012-07-04 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org The SGL memory allocated during vhost_scsi_map_iov_to_sgl() setup was never getting freed during tv_cmd completion - release path. Fix this up by releasing tv_cmd-tvc_sgl in vhost_scsi_free_cmd() ahead of tv_cmd descriptor free. Cc: Stefan Hajnoczi

Re: [PATCH] tcm_vhost: Fix tv_cmd completion - release SGL memory leak

2012-07-04 Thread Zhi Yong Wu
On Thu, 2012-07-05 at 04:14 +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org The SGL memory allocated during vhost_scsi_map_iov_to_sgl() setup was never getting freed during tv_cmd completion - release path. Fix this up by releasing tv_cmd-tvc_sgl in