Re: [PATCH repost] virtio: don't crash when device is buggy

2012-09-17 Thread Rusty Russell
Michael S. Tsirkin m...@redhat.com writes: Because of a sanity check in virtio_dev_remove, a buggy device can crash kernel. And in case of rproc it's userspace so it's not a good idea. We are unloading a driver so how bad can it be? Be less aggressive in handling this error: if it's a driver

[PATCH v10 0/5] make balloon pages movable by compaction

2012-09-17 Thread Rafael Aquini
Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance penalties associated with the reduced number of transparent huge pages that could be used by the guest workload. This

[PATCH v10 1/5] mm: introduce a common interface for balloon pages mobility

2012-09-17 Thread Rafael Aquini
Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance penalties associated with the reduced number of transparent huge pages that could be used by the guest workload. This

[PATCH v10 2/5] mm: introduce compaction and migration for ballooned pages

2012-09-17 Thread Rafael Aquini
Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance penalties associated with the reduced number of transparent huge pages that could be used by the guest workload. This

[PATCH v10 4/5] mm: introduce putback_movable_pages()

2012-09-17 Thread Rafael Aquini
The PATCH mm: introduce compaction and migration for virtio ballooned pages hacks around putback_lru_pages() in order to allow ballooned pages to be re-inserted on balloon page list as if a ballooned page was like a LRU page. As ballooned pages are not legitimate LRU pages, this patch introduces

[PATCH v10 3/5] virtio_balloon: introduce migration primitives to balloon pages

2012-09-17 Thread Rafael Aquini
Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance penalties associated with the reduced number of transparent huge pages that could be used by the guest workload. Besides

[PATCH v10 5/5] mm: add vm event counters for balloon pages compaction

2012-09-17 Thread Rafael Aquini
This patch introduces a new set of vm event counters to keep track of ballooned pages compaction activity. Signed-off-by: Rafael Aquini aqu...@redhat.com --- drivers/virtio/virtio_balloon.c | 1 + include/linux/vm_event_item.h | 8 +++- mm/balloon_compaction.c | 2 ++

Re: [PATCH v10 0/5] make balloon pages movable by compaction

2012-09-17 Thread Andrew Morton
On Mon, 17 Sep 2012 13:38:15 -0300 Rafael Aquini aqu...@redhat.com wrote: Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance penalties associated with the reduced number

Re: [PATCH v10 3/5] virtio_balloon: introduce migration primitives to balloon pages

2012-09-17 Thread Andrew Morton
On Mon, 17 Sep 2012 13:38:18 -0300 Rafael Aquini aqu...@redhat.com wrote: Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance penalties associated with the reduced number

Re: [PATCH v10 1/5] mm: introduce a common interface for balloon pages mobility

2012-09-17 Thread Andrew Morton
On Mon, 17 Sep 2012 13:38:16 -0300 Rafael Aquini aqu...@redhat.com wrote: Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance penalties associated with the reduced number

Re: [PATCH v10 0/5] make balloon pages movable by compaction

2012-09-17 Thread Rik van Riel
On 09/17/2012 06:15 PM, Andrew Morton wrote: On Mon, 17 Sep 2012 13:38:15 -0300 Rafael Aquini aqu...@redhat.com wrote: Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance