On 15.10.12 at 12:25, Ian Campbell ian.campb...@citrix.com wrote:
On Thu, 2012-09-13 at 19:00 +0300, Dan Carpenter wrote:
Hi,
Thanks Dan. I'm not sure anyone from Xen-land really monitors
virtualization@. Adding xen-devel and Konrad.
I was reading some code and had a question in
On 15.10.12 at 12:27, Ian Campbell ian.campb...@citrix.com wrote:
My static analyzer complains about potential memory corruption in
HYPERVISOR_physdev_op()
arch/x86/include/asm/xen/hypercall.h
389 static inline int
390 HYPERVISOR_physdev_op(int cmd, void *arg)
391 {
392
Michael S. Tsirkin m...@redhat.com writes:
On Fri, Oct 12, 2012 at 08:21:50PM +1030, Rusty Russell wrote:
Michael S. Tsirkin m...@redhat.com writes:
On Fri, Oct 12, 2012 at 08:59:36AM +1030, Rusty Russell wrote:
For writes, the standard seems to be a commit latch. We could abuse
the
On Tue, Oct 16, 2012 at 11:45:41PM +1030, Rusty Russell wrote:
Michael S. Tsirkin m...@redhat.com writes:
On Fri, Oct 12, 2012 at 08:21:50PM +1030, Rusty Russell wrote:
Michael S. Tsirkin m...@redhat.com writes:
On Fri, Oct 12, 2012 at 08:59:36AM +1030, Rusty Russell wrote:
For writes,
From: Michael S. Tsirkin m...@redhat.com
[Split from correct capacity math on ring full -- Rusty]
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
---
drivers/net/virtio_net.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Now we can easily use vq-num_free to determine if there are descriptors
left in the queue, we're about to change virtqueue_add_buf() to return 0
on success. The virtio_net driver is the only one which actually uses
the return value, so change that.
Signed-off-by: Rusty Russell
They're generic concepts, so hoist them. This also avoids accessor
functions.
This goes even further than Jason Wang's 17bb6d4088 patch
(virtio-ring: move queue_index to vring_virtqueue) which moved the
queue_index from the specific transport.
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
Now noone relies on this behavior, we simplify virtqueue_add_buf() so it
return 0 or -errno.
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
---
drivers/virtio/virtio_ring.c |7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/virtio/virtio_ring.c
On Wed, Oct 17, 2012 at 12:00:51AM +1030, Rusty Russell wrote:
Now we can easily use vq-num_free to determine if there are descriptors
left in the queue, we're about to change virtqueue_add_buf() to return 0
on success. The virtio_net driver is the only one which actually uses
the return
On Wed, Oct 17, 2012 at 12:00:48AM +1030, Rusty Russell wrote:
They're generic concepts, so hoist them. This also avoids accessor
functions.
This goes even further than Jason Wang's 17bb6d4088 patch
(virtio-ring: move queue_index to vring_virtqueue) which moved the
queue_index from the
Note: I also have minor cleanups to virtio drivers to change (ret = 0)
to (ret == 0) where it would otherwise be confusing for new readers, but
I didn't clutter the list with them. See my virtio-wip tree for the
gory details.
Cheers,
Rusty.
___
Michael S. Tsirkin m...@redhat.com writes:
On Wed, Oct 17, 2012 at 12:00:48AM +1030, Rusty Russell wrote:
* @priv: a pointer for the virtqueue implementation to use.
+ * @index: the zero-based ordinal number for this queue.
+ * @num_free: number of buffers we expect to be able to fit.
Only
On Wed, Oct 17, 2012 at 12:00:48AM +1030, Rusty Russell wrote:
They're generic concepts, so hoist them. This also avoids accessor
functions.
This goes even further than Jason Wang's 17bb6d4088 patch
(virtio-ring: move queue_index to vring_virtqueue) which moved the
queue_index from the
Compiling xenbus_xs.o triggers this GCC warning:
drivers/xen/xenbus/xenbus_xs.c:628:13: warning: function declaration isn’t
a prototype [-Wstrict-prototypes]
Add the obvious and trivial fix.
While we're touching this function add some equally obvious and trivial
whitespace fixes.
14 matches
Mail list logo
