Re: [PATCH net-next v3 0/3] Multiqueue support in virtio-net

2012-12-07 Thread Stephen Hemminger
On Fri, 07 Dec 2012 15:35:56 -0500 (EST) David Miller wrote: > From: Jason Wang > Date: Sat, 8 Dec 2012 01:04:54 +0800 > > > This series is an update version (hope the final version) of multiqueue > > (VIRTIO_NET_F_MQ) support in virtio-net driver. All previous comments were > > addressed, the

Re: [PATCH net-next v3 1/3] virtio-net: separate fields of sending/receiving queue from virtnet_info

2012-12-07 Thread Stephen Hemminger
Minor style issue reported by checkpatch which can be fixed after merge. Although sizeof is actually an operator in C, it is considered correct style to treat it as a function. WARNING: sizeof hdr->hdr should be sizeof(hdr->hdr) #293: FILE: drivers/net/virtio_net.c:395: + sg_set_buf(rq->sg,

Re: [PATCH net-next v3 0/3] Multiqueue support in virtio-net

2012-12-07 Thread David Miller
From: Jason Wang Date: Sat, 8 Dec 2012 01:04:54 +0800 > This series is an update version (hope the final version) of multiqueue > (VIRTIO_NET_F_MQ) support in virtio-net driver. All previous comments were > addressed, the work were based on Krishna Kumar's work to let virtio-net use > multiple r

[PATCH net-next v3 3/3] virtio-net: support changing the number of queue pairs through ethtool

2012-12-07 Thread Jason Wang
This patch implements the ethtool_{set|get}_channels method of virtio-net to allow user to change the number of queues when the device is running on demand. Signed-off-by: Jason Wang --- drivers/net/virtio_net.c | 43 +++ 1 files changed, 43 insertions(+

[PATCH net-next v3 2/3] virtio_net: multiqueue support

2012-12-07 Thread Jason Wang
This patch adds the multiqueue (VIRTIO_NET_F_MQ) support to virtio_net driver. VIRTIO_NET_F_MQ capable device could allow the driver to do packet transmission and reception through multiple queue pairs and does the packet steering to get better performance. By default, one one queue pair is used, u

[PATCH net-next v3 1/3] virtio-net: separate fields of sending/receiving queue from virtnet_info

2012-12-07 Thread Jason Wang
To support multiqueue transmitq/receiveq, the first step is to separate queue related structure from virtnet_info. This patch introduce send_queue and receive_queue structure and use the pointer to them as the parameter in functions handling sending/receiving. Signed-off-by: Krishna Kumar Signed-

[PATCHv6] virtio-spec: virtio network device multiqueue support

2012-12-07 Thread Michael S. Tsirkin
Add multiqueue support to virtio network device. Add a new feature flag VIRTIO_NET_F_MQ for this feature, a new configuration field max_virtqueue_pairs to detect supported number of virtqueues as well as a new command VIRTIO_NET_CTRL_MQ to program packet steering for unidirectional protocols. ---

Re: [RFCv2 04/12] virtio-ring: Refactor out the functions accessing user memory

2012-12-07 Thread Michael S. Tsirkin
On Fri, Dec 07, 2012 at 02:02:12PM +0100, Sjur BRENDELAND wrote: > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > On Fri, Dec 07, 2012 at 12:05:11PM +0100, Sjur BRENDELAND wrote: > > > Hi Michael, > > > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > > > Sent: Thursday, December 06

RE: [RFCv2 04/12] virtio-ring: Refactor out the functions accessing user memory

2012-12-07 Thread Sjur BRENDELAND
> From: Michael S. Tsirkin [mailto:m...@redhat.com] > On Fri, Dec 07, 2012 at 12:05:11PM +0100, Sjur BRENDELAND wrote: > > Hi Michael, > > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > > Sent: Thursday, December 06, 2012 12:16 PM > > > On Thu, Dec 06, 2012 at 12:03:43PM +0100, Sjur BRENDE

Re: [RFCv2 04/12] virtio-ring: Refactor out the functions accessing user memory

2012-12-07 Thread Michael S. Tsirkin
On Fri, Dec 07, 2012 at 12:05:11PM +0100, Sjur BRENDELAND wrote: > Hi Michael, > > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Sent: Thursday, December 06, 2012 12:16 PM > > On Thu, Dec 06, 2012 at 12:03:43PM +0100, Sjur BRENDELAND wrote: > > > Hi Michael, > > > > > > > > -struct vring

RE: [RFCv2 04/12] virtio-ring: Refactor out the functions accessing user memory

2012-12-07 Thread Sjur BRENDELAND
Hi Michael, > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Thursday, December 06, 2012 12:16 PM > On Thu, Dec 06, 2012 at 12:03:43PM +0100, Sjur BRENDELAND wrote: > > Hi Michael, > > > > > > -struct vring_used_elem *vring_add_used_user(struct vring_host *vh, > > > > -