Re: [RFCv2 00/12] Introduce host-side virtio queue and CAIF Virtio.

2013-01-08 Thread Sjur Brændeland
On Fri, Dec 21, 2012 at 7:11 AM, Rusty Russell ru...@rustcorp.com.au wrote: Michael S. Tsirkin m...@redhat.com writes: On Wed, Dec 05, 2012 at 03:36:58PM +0100, Sjur Brændeland wrote: Feedback on this patch-set is appreciated, particularly on structure and code-reuse between vhost.c and the

[PATCH V3 1/2] virtio-net: fix the set affinity bug when CPU IDs are not consecutive

2013-01-08 Thread Wanlong Gao
As Michael mentioned, set affinity and select queue will not work very well when CPU IDs are not consecutive, this can happen with hot unplug. Fix this bug by traversal the online CPUs, and create a per cpu variable to find the mapping from CPU to the preferable virtual-queue. Cc: Rusty Russell

[PATCH V3 2/2] virtio-net: reset virtqueue affinity when doing cpu hotplug

2013-01-08 Thread Wanlong Gao
Add a cpu notifier to virtio-net, so that we can reset the virtqueue affinity if the cpu hotplug happens. It improve the performance through enabling or disabling the virtqueue affinity after doing cpu hotplug. Cc: Rusty Russell ru...@rustcorp.com.au Cc: Michael S. Tsirkin m...@redhat.com Cc:

Re: [PATCH V3 1/2] virtio-net: fix the set affinity bug when CPU IDs are not consecutive

2013-01-08 Thread Jason Wang
On 01/08/2013 06:07 PM, Wanlong Gao wrote: As Michael mentioned, set affinity and select queue will not work very well when CPU IDs are not consecutive, this can happen with hot unplug. Fix this bug by traversal the online CPUs, and create a per cpu variable to find the mapping from CPU to the

Re: [PATCH V3 1/2] virtio-net: fix the set affinity bug when CPU IDs are not consecutive

2013-01-08 Thread Rusty Russell
Wanlong Gao gaowanl...@cn.fujitsu.com writes: */ static u16 virtnet_select_queue(struct net_device *dev, struct sk_buff *skb) { - int txq = skb_rx_queue_recorded(skb) ? skb_get_rx_queue(skb) : - smp_processor_id(); + int txq = 0; + + if

Re: [RFCv2 00/12] Introduce host-side virtio queue and CAIF Virtio.

2013-01-08 Thread Rusty Russell
Sjur Brændeland sjurb...@gmail.com writes: On Fri, Dec 21, 2012 at 7:11 AM, Rusty Russell ru...@rustcorp.com.au wrote: Michael S. Tsirkin m...@redhat.com writes: On Wed, Dec 05, 2012 at 03:36:58PM +0100, Sjur Brændeland wrote: Feedback on this patch-set is appreciated, particularly on

[PATCH 00/12] VMCI for Linux upstreaming

2013-01-08 Thread George Zhang
* * * This series of VMCI linux upstreaming patches include latest udpate from VMware to address Greg's and all other's code review comments. Summary of changes: - Rebase our linux kernel tree from v3.5 to v3.7. - Fix all checkpatch warnings and errors. Fix some checkpatch with

[PATCH 01/12] VMCI: context implementation.

2013-01-08 Thread George Zhang
VMCI Context code maintains state for vmci and allows the driver to communicate with multiple VMs. Signed-off-by: George Zhang georgezh...@vmware.com Acked-by: Andy king ack...@vmware.com Acked-by: Dmitry Torokhov d...@vmware.com --- drivers/misc/vmw_vmci/vmci_context.c | 1214

[PATCH 02/12] VMCI: datagram implementation.

2013-01-08 Thread George Zhang
VMCI datagram Implements datagrams to allow data to be sent between host and guest. Signed-off-by: George Zhang georgezh...@vmware.com Acked-by: Andy king ack...@vmware.com Acked-by: Dmitry Torokhov d...@vmware.com --- drivers/misc/vmw_vmci/vmci_datagram.c | 500

[PATCH 03/12] VMCI: doorbell implementation.

2013-01-08 Thread George Zhang
VMCI doorbell code allows for notifcations between host and guest. Signed-off-by: George Zhang georgezh...@vmware.com Acked-by: Andy king ack...@vmware.com Acked-by: Dmitry Torokhov d...@vmware.com --- drivers/misc/vmw_vmci/vmci_doorbell.c | 604 +

[PATCH 04/12] VMCI: device driver implementaton.

2013-01-08 Thread George Zhang
VMCI driver code implementes both the host and guest personalities of the VMCI driver. Signed-off-by: George Zhang georgezh...@vmware.com Acked-by: Andy king ack...@vmware.com Acked-by: Dmitry Torokhov d...@vmware.com --- drivers/misc/vmw_vmci/vmci_driver.c | 117

[PATCH 06/12] VMCI: handle array implementation.

2013-01-08 Thread George Zhang
VMCI handle code adds support for dynamic arrays that will grow if they need to. Signed-off-by: George Zhang georgezh...@vmware.com Acked-by: Andy king ack...@vmware.com Acked-by: Dmitry Torokhov d...@vmware.com --- drivers/misc/vmw_vmci/vmci_handle_array.c | 142 +

[PATCH 08/12] VMCI: resource object implementation.

2013-01-08 Thread George Zhang
VMCI resource tracks all used resources within the vmci code. Signed-off-by: George Zhang georgezh...@vmware.com Acked-by: Andy king ack...@vmware.com Acked-by: Dmitry Torokhov d...@vmware.com --- drivers/misc/vmw_vmci/vmci_resource.c | 229 +

[PATCH 10/12] VMCI: guest side driver implementation.

2013-01-08 Thread George Zhang
VMCI guest side driver code implementation. Signed-off-by: George Zhang georgezh...@vmware.com Acked-by: Andy king ack...@vmware.com Acked-by: Dmitry Torokhov d...@vmware.com --- drivers/misc/vmw_vmci/vmci_guest.c | 759 1 files changed, 759 insertions(+), 0

[PATCH 11/12] VMCI: host side driver implementation.

2013-01-08 Thread George Zhang
VMCI host side driver code implementation. Signed-off-by: George Zhang georgezh...@vmware.com Acked-by: Andy king ack...@vmware.com Acked-by: Dmitry Torokhov d...@vmware.com --- drivers/misc/vmw_vmci/vmci_host.c | 1042 + 1 files changed, 1042 insertions(+), 0

[PATCH 12/12] VMCI: Some header and config files.

2013-01-08 Thread George Zhang
VMCI head config patch Adds all the necessary files to enable building of the VMCI module with the Linux Makefiles and Kconfig systems. Also adds the header files used for building modules against the driver. Signed-off-by: George Zhang georgezh...@vmware.com Acked-by: Andy king

[PATCH 0/6] VSOCK for Linux upstreaming

2013-01-08 Thread George Zhang
* * * This series of VSOCK linux upstreaming patches include latest udpate from VMware to address Greg's and all other's code review comments. Summary of changes: - Rebase our linux kernel tree from v3.5 to v3.7. - Fix all checkpatch warnings and errors. Fix some checkpatch with

[PATCH 2/6] VSOCK: vsock address implementaion.

2013-01-08 Thread George Zhang
VSOCK linux address code implementation. Signed-off-by: George Zhang georgezh...@vmware.com Acked-by: Andy king ack...@vmware.com Acked-by: Dmitry Torokhov d...@vmware.com --- net/vmw_vsock/vsock_addr.c | 116 net/vmw_vsock/vsock_addr.h | 34

[PATCH 3/6] VSOCK: notification implementation.

2013-01-08 Thread George Zhang
VSOCK control notifications for VMCI Stream Sockets protocol. Signed-off-by: George Zhang georgezh...@vmware.com Acked-by: Andy king ack...@vmware.com Acked-by: Dmitry Torokhov d...@vmware.com --- net/vmw_vsock/notify.c | 675

[PATCH 4/6] VSOCK: statistics implementation.

2013-01-08 Thread George Zhang
VSOCK stats for VMCI Stream Sockets protocol. Signed-off-by: George Zhang georgezh...@vmware.com Acked-by: Andy king ack...@vmware.com Acked-by: Dmitry Torokhov d...@vmware.com --- net/vmw_vsock/stats.c | 30 ++ net/vmw_vsock/stats.h | 150

[PATCH 5/6] VSOCK: utility functions.

2013-01-08 Thread George Zhang
VSOCK utility functions for Linux VSocket module. Signed-off-by: George Zhang georgezh...@vmware.com Acked-by: Andy king ack...@vmware.com Acked-by: Dmitry Torokhov d...@vmware.com --- net/vmw_vsock/util.c | 345 ++ net/vmw_vsock/util.h | 187

[PATCH 6/6] VSOCK: header and config files.

2013-01-08 Thread George Zhang
VSOCK header files, Makefiles and Kconfig systems for Linux VSocket module. Signed-off-by: George Zhang georgezh...@vmware.com Acked-by: Andy king ack...@vmware.com Acked-by: Dmitry Torokhov d...@vmware.com --- Documentation/ioctl/ioctl-number.txt |1 include/linux/socket.h |

Re: [PATCH 07/12] VMCI: queue pairs implementation.

2013-01-08 Thread Greg KH
On Tue, Jan 08, 2013 at 03:54:54PM -0800, George Zhang wrote: VMCI queue pairs allow for bi-directional ordered communication between host and guests. You should wrap your commit lines at 72 characters, like git asks you to :) +/* Guest device port I/O. */ +struct PPNSet { + u64

Re: [PATCH 00/12] VMCI for Linux upstreaming

2013-01-08 Thread Greg KH
On Tue, Jan 08, 2013 at 03:52:33PM -0800, George Zhang wrote: * * * This series of VMCI linux upstreaming patches include latest udpate from VMware to address Greg's and all other's code review comments. Nice work, thanks for the changes you've made over time, and for your persistence. I

Re: [PATCH 0/6] VSOCK for Linux upstreaming

2013-01-08 Thread Greg KH
On Tue, Jan 08, 2013 at 03:59:08PM -0800, George Zhang wrote: * * * This series of VSOCK linux upstreaming patches include latest udpate from VMware to address Greg's and all other's code review comments. Dave, you acked these patches a while ago, and now that I've taken the VMCI patches

Re: [Pv-drivers] [PATCH 07/12] VMCI: queue pairs implementation.

2013-01-08 Thread Dmitry Torokhov
Hi Greg, On Tuesday, January 08, 2013 04:15:39 PM Greg KH wrote: On Tue, Jan 08, 2013 at 03:54:54PM -0800, George Zhang wrote: +/* Guest device port I/O. */ +struct PPNSet { + u64 num_produce_pages; + u64 num_consume_pages; + u32 *produce_ppns; + u32 *consume_ppns; +

Re: [Pv-drivers] [PATCH 07/12] VMCI: queue pairs implementation.

2013-01-08 Thread Greg KH
On Tue, Jan 08, 2013 at 04:28:51PM -0800, Dmitry Torokhov wrote: Hi Greg, On Tuesday, January 08, 2013 04:15:39 PM Greg KH wrote: On Tue, Jan 08, 2013 at 03:54:54PM -0800, George Zhang wrote: +/* Guest device port I/O. */ +struct PPNSet { + u64 num_produce_pages; + u64

Re: [PATCH 0/6] VSOCK for Linux upstreaming

2013-01-08 Thread David Miller
From: Greg KH gre...@linuxfoundation.org Date: Tue, 8 Jan 2013 16:21:10 -0800 On Tue, Jan 08, 2013 at 03:59:08PM -0800, George Zhang wrote: * * * This series of VSOCK linux upstreaming patches include latest udpate from VMware to address Greg's and all other's code review comments.

Re: [Pv-drivers] [PATCH 0/6] VSOCK for Linux upstreaming

2013-01-08 Thread Dmitry Torokhov
On Tuesday, January 08, 2013 05:30:56 PM David Miller wrote: From: Greg KH gre...@linuxfoundation.org Date: Tue, 8 Jan 2013 16:21:10 -0800 On Tue, Jan 08, 2013 at 03:59:08PM -0800, George Zhang wrote: * * * This series of VSOCK linux upstreaming patches include latest udpate from

Re: [Pv-drivers] [PATCH 0/6] VSOCK for Linux upstreaming

2013-01-08 Thread David Miller
From: Dmitry Torokhov d...@vmware.com Date: Tue, 08 Jan 2013 17:41:44 -0800 On Tuesday, January 08, 2013 05:30:56 PM David Miller wrote: From: Greg KH gre...@linuxfoundation.org Date: Tue, 8 Jan 2013 16:21:10 -0800 On Tue, Jan 08, 2013 at 03:59:08PM -0800, George Zhang wrote: * * *

Re: [Pv-drivers] [PATCH 0/6] VSOCK for Linux upstreaming

2013-01-08 Thread Dmitry Torokhov
On Tue, Jan 08, 2013 at 05:46:01PM -0800, David Miller wrote: From: Dmitry Torokhov d...@vmware.com Date: Tue, 08 Jan 2013 17:41:44 -0800 On Tuesday, January 08, 2013 05:30:56 PM David Miller wrote: From: Greg KH gre...@linuxfoundation.org Date: Tue, 8 Jan 2013 16:21:10 -0800 On

Re: [PATCH V3 1/2] virtio-net: fix the set affinity bug when CPU IDs are not consecutive

2013-01-08 Thread Wanlong Gao
On 01/09/2013 07:31 AM, Rusty Russell wrote: Wanlong Gao gaowanl...@cn.fujitsu.com writes: */ static u16 virtnet_select_queue(struct net_device *dev, struct sk_buff *skb) { -int txq = skb_rx_queue_recorded(skb) ? skb_get_rx_queue(skb) : - smp_processor_id(); +int

Re: [PATCH V3 1/2] virtio-net: fix the set affinity bug when CPU IDs are not consecutive

2013-01-08 Thread Wanlong Gao
On 01/08/2013 06:26 PM, Jason Wang wrote: On 01/08/2013 06:07 PM, Wanlong Gao wrote: As Michael mentioned, set affinity and select queue will not work very well when CPU IDs are not consecutive, this can happen with hot unplug. Fix this bug by traversal the online CPUs, and create a per cpu

Re: [PATCH V3 1/2] virtio-net: fix the set affinity bug when CPU IDs are not consecutive

2013-01-08 Thread Jason Wang
On 01/09/2013 09:52 AM, Wanlong Gao wrote: On 01/08/2013 06:26 PM, Jason Wang wrote: On 01/08/2013 06:07 PM, Wanlong Gao wrote: As Michael mentioned, set affinity and select queue will not work very well when CPU IDs are not consecutive, this can happen with hot unplug. Fix this bug by

[PATCH] virtio-spec: fix two typos

2013-01-08 Thread akong
From: Amos Kong ak...@redhat.com VIRTIO_NET_F_VTRL_VQ - VIRTIO_NET_F_CTRL_VQ VIRTIO_NET_CTRL_MQ is defined to 4 in kernel code Signed-off-by: Amos Kong ak...@redhat.com --- virtio-spec.lyx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/virtio-spec.lyx b/virtio-spec.lyx