Re: [patch] virtio: console: fix error handling for debugfs_create_dir()

2013-07-21 Thread Greg Kroah-Hartman
On Sun, Jul 21, 2013 at 11:36:25AM +0200, Arnd Bergmann wrote: On Saturday 20 July 2013, Dan Carpenter wrote: On Fri, Jul 19, 2013 at 12:28:41PM +0200, Arnd Bergmann wrote: On Friday 19 July 2013, Dan Carpenter wrote: debugfs_create_dir() returns ERR_PTR(-ENODEV) if debugfs is disabled.

Re: [patch] virtio: console: fix error handling for debugfs_create_dir()

2013-07-21 Thread Dan Carpenter
I don't see where that oops would happen. In the code I'm looking at, all uses of -debugfs_dir only ever get passed into other debugfs functions that are stubbed out to empty inline functions. It's not the most obvious interface design, but this all seems intentional and correct to me. Ah.

Re: Re: [PATCH V2 0/2] [BUGFIX] virtio/console: Fix two bugs of splice_write

2013-07-21 Thread Yoshihiro YUNOMAE
Hi Amit, Sorry for the late reply. (2013/07/19 19:05), Amit Shah wrote: On (Fri) 19 Jul 2013 [18:19:51], Yoshihiro YUNOMAE wrote: Hi, This patch set fixes two bugs of splice_write in the virtio-console driver. [BUG1] Although pipe-nrbufs is empty, the driver tries to do splice_write.

[PATCH V3 0/2] [BUGFIX] virtio/console: Fix two bugs of splice_write

2013-07-21 Thread Yoshihiro YUNOMAE
Hi, This patch set fixes two bugs of splice_write in the virtio-console driver. [BUG1] Although pipe-nrbufs is empty, the driver tries to do splice_write. = This induces oops in sg_init_table(). [BUG2] No lock for competition of splice_write. = This induces oops in

[PATCH V3 1/2] [BUGFIX] virtio/console: Quit from splice_write if pipe-nrbufs is 0

2013-07-21 Thread Yoshihiro YUNOMAE
Quit from splice_write if pipe-nrbufs is 0 for avoiding oops in virtio-serial. When an application was doing splice from a kernel buffer to virtio-serial on a guest, the application received signal(SIGINT). This situation will normally happen, but the kernel executed a kernel panic by oops as