On 21/11/13 19:31, Michael S. Tsirkin wrote:
On Thu, Nov 21, 2013 at 06:12:21PM +0100, Heinz Graalfs wrote:
On 21/11/13 16:15, Michael S. Tsirkin wrote:
On Thu, Nov 21, 2013 at 03:45:33PM +0100, Heinz Graalfs wrote:
virtio_ccw's notify() callback for the common IO layer invokes
Code is added to the notify handler to set the 'surprize_removal' flag
in virtio_device in case a CIO_GONE notification occurs. The remove
callback of the backend driver must check this flag in order to perform
special processing for a lost device.
Signed-off-by: Heinz Graalfs
Code is added to the remove callback to verify if a device was lost.
In case of a device loss further request queueing should be prevented
by setting appropriate queue flags prior to invoking del_gendisk().
Blocking of request queueing leads to appropriate I/O errors when data
are tried to be
Hi, here is an updated patch-set to my v2 RFC
virtio: add new notify() callback to virtio_driver
This RFC introduces a new virtio_device entry 'surprize_removal' instead
of a new 'notify' callback in struct virtio_driver.
When an active virtio block device is hot-unplugged from a KVM guest,
Add new entry surprize_removal to struct virtio_device.
When a virtio transport driver is notified about a lost device
it should set surprize_removal to true.
A backend driver can test this flag in order to perform specific
actions that might be appropriate wrt the device loss.
Signed-off-by:
Code is added to avoid calling blk_cleanup_queue() when the surprize_removal
flag is set due to a disappeared device. It avoid hangs due to incomplete
requests (e.g. in-flight requests). Such requests must be considered as lost.
If the current remove callback was triggered due to an unregister
On Wed, Nov 27, 2013 at 11:32:07AM +0100, Heinz Graalfs wrote:
On 21/11/13 19:31, Michael S. Tsirkin wrote:
On Thu, Nov 21, 2013 at 06:12:21PM +0100, Heinz Graalfs wrote:
On 21/11/13 16:15, Michael S. Tsirkin wrote:
On Thu, Nov 21, 2013 at 03:45:33PM +0100, Heinz Graalfs wrote:
virtio_ccw's
On Wed, Nov 27, 2013 at 11:32:39AM +0100, Heinz Graalfs wrote:
Code is added to avoid calling blk_cleanup_queue() when the surprize_removal
flag is set due to a disappeared device. It avoid hangs due to incomplete
requests (e.g. in-flight requests). Such requests must be considered as lost.
On Wed, Nov 27, 2013 at 11:32:40AM +0100, Heinz Graalfs wrote:
Code is added to the notify handler to set the 'surprize_removal' flag
in virtio_device in case a CIO_GONE notification occurs. The remove
callback of the backend driver must check this flag in order to perform
special processing
On 27/11/13 11:47, Michael S. Tsirkin wrote:
On Wed, Nov 27, 2013 at 11:32:39AM +0100, Heinz Graalfs wrote:
Code is added to avoid calling blk_cleanup_queue() when the surprize_removal
flag is set due to a disappeared device. It avoid hangs due to incomplete
requests (e.g. in-flight requests).
On Wed, Nov 27, 2013 at 12:37:02PM +0100, Heinz Graalfs wrote:
On 27/11/13 11:47, Michael S. Tsirkin wrote:
On Wed, Nov 27, 2013 at 11:32:39AM +0100, Heinz Graalfs wrote:
Code is added to avoid calling blk_cleanup_queue() when the surprize_removal
flag is set due to a disappeared device. It
On Wed, Nov 27, 2013 at 12:37:02PM +0100, Heinz Graalfs wrote:
On 27/11/13 11:47, Michael S. Tsirkin wrote:
On Wed, Nov 27, 2013 at 11:32:39AM +0100, Heinz Graalfs wrote:
Code is added to avoid calling blk_cleanup_queue() when the surprize_removal
flag is set due to a disappeared device. It
* Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote:
(2013/11/22 11:35), Masami Hiramatsu wrote:
(2013/11/21 16:29), Ingo Molnar wrote:
* Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote:
(2013/11/21 2:36), Frank Ch. Eigler wrote:
[ ... ]
one needs to resort to
* Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote:
+#ifdef CONFIG_KPROBES
+/*
+ * Blacklist ganerating macro. Specify functions which is not probed
+ * by using this macro.
+ */
+#define __NOKPROBE_SYMBOL(fname) \
+static struct kprobe_blackpoint __used
On 27/11/13 13:49, Michael S. Tsirkin wrote:
On Wed, Nov 27, 2013 at 12:37:02PM +0100, Heinz Graalfs wrote:
On 27/11/13 11:47, Michael S. Tsirkin wrote:
On Wed, Nov 27, 2013 at 11:32:39AM +0100, Heinz Graalfs wrote:
Code is added to avoid calling blk_cleanup_queue() when the surprize_removal
On Wed, Nov 27, 2013 at 03:15:45PM +0100, Heinz Graalfs wrote:
On 27/11/13 13:49, Michael S. Tsirkin wrote:
On Wed, Nov 27, 2013 at 12:37:02PM +0100, Heinz Graalfs wrote:
On 27/11/13 11:47, Michael S. Tsirkin wrote:
On Wed, Nov 27, 2013 at 11:32:39AM +0100, Heinz Graalfs wrote:
Code is added
receive mergeable now handles errors internally.
Do same for big and small packet paths, otherwise
the logic is too hard to follow.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
While I can't point at a bug this fixes, I'm not sure
there's no bug in the existing logic.
So not exactly a
Eric Dumazet noticed that if we encounter an error
when processing a mergeable buffer, we don't
dequeue all of the buffers from this packet,
the result is almost sure to be loss of networking.
Jason Wang noticed that we also leak a page and that we don't decrement
the rq buf count, so we won't
On Wed, Nov 27, 2013 at 08:58:37AM -0800, Ashutosh Dixit wrote:
These patches fix various issues which were reported or found with the
MIC driver.
All now applied, thanks.
greg k-h
___
Virtualization mailing list
On 11/28/2013 12:31 AM, Michael S. Tsirkin wrote:
Eric Dumazet noticed that if we encounter an error
when processing a mergeable buffer, we don't
dequeue all of the buffers from this packet,
the result is almost sure to be loss of networking.
Jason Wang noticed that we also leak a page and
On 11/28/2013 12:31 AM, Michael S. Tsirkin wrote:
receive mergeable now handles errors internally.
Do same for big and small packet paths, otherwise
the logic is too hard to follow.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
While I can't point at a bug this fixes, I'm not sure
(2013/11/27 22:32), Ingo Molnar wrote:
* Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote:
+#ifdef CONFIG_KPROBES
+/*
+ * Blacklist ganerating macro. Specify functions which is not probed
+ * by using this macro.
+ */
+#define __NOKPROBE_SYMBOL(fname)\
22 matches
Mail list logo
