Re: [PATCH] virtio: pci: Use SIMPLE_DEV_PM_OPS macro

2014-09-08 Thread Rusty Russell
Jingoo Han writes: > Use SIMPLE_DEV_PM_OPS macro in order to make the code simpler. > > Signed-off-by: Jingoo Han This patch is obviously wrong. It won't compile without CONFIG_PM_SLEEP. Cheers, Rusty. > --- > drivers/virtio/virtio_pci.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 de

Re: [PATCH] virtio_blk: merge S/G list entries by default

2014-09-08 Thread Christoph Hellwig
On Mon, Sep 08, 2014 at 11:18:30AM +0300, Michael S. Tsirkin wrote: > Could you respond to Ming Lei's mail, who benchmarked the patch, please? I don't really have any additional data or disagreement, not sure what I should respond there. ___ Virtualizati

Re: [PATCH 3/3] virtio_ring: unify direct/indirect code paths.

2014-09-08 Thread Andy Lutomirski
On Sep 5, 2014 3:55 AM, "Paolo Bonzini" wrote: > > Il 03/09/2014 06:29, Rusty Russell ha scritto: > > + desc = kmalloc(total_sg * sizeof(struct vring_desc), gfp); > > + if (!desc) > > + return NULL; > > > > - return head; > > + for (i = 0; i < total_sg; i++) > > +

Re: [PATCH] virtio_blk: merge S/G list entries by default

2014-09-08 Thread Paolo Bonzini
Il 07/09/2014 13:41, Michael S. Tsirkin ha scritto: > On Sat, Sep 06, 2014 at 04:09:54PM -0700, Christoph Hellwig wrote: >> Most virtio setups have a fairly limited number of ring entries available. > > Seems a bit vague: QEMU at least has pretty large queues. > Which hypervisor do you have in min

Re: [PATCH] virtio-rng: complete have_data completion in removing device

2014-09-08 Thread Amos Kong
On Wed, Aug 06, 2014 at 01:55:29PM +0530, Amit Shah wrote: > On (Wed) 06 Aug 2014 [16:05:41], Amos Kong wrote: > > On Wed, Aug 06, 2014 at 01:35:15AM +0800, Amos Kong wrote: > > > When we try to hot-remove a busy virtio-rng device from QEMU monitor, > > > the device can't be hot-removed. Because vi

Re: [PATCH] virtio_blk: merge S/G list entries by default

2014-09-08 Thread Michael S. Tsirkin
On Sun, Sep 07, 2014 at 08:47:45PM +0200, Christoph Hellwig wrote: > On Sun, Sep 07, 2014 at 02:41:53PM +0300, Michael S. Tsirkin wrote: > > > Signed-off-by: Christoph Hellwig > > > > OK so this is an optimization patch right? > > What kind of performance gain is observed with it? > > None. I a