Re: [PATCH 1/2] virtio-rng cleanup: move some code out of mutex protection

2014-09-11 Thread Amit Shah
On (Wed) 10 Sep 2014 [17:07:06], Amos Kong wrote: It doesn't save too much cpu time as expected, just a cleanup. Frankly I won't bother with this. It doesn't completely remove all copying from the mutex, so it's not worthwhile. Signed-off-by: Amos Kong ak...@redhat.com ---

Re: [PATCH 2/2] virtio-rng: fix stuck in catting hwrng attributes

2014-09-11 Thread Amit Shah
On (Wed) 10 Sep 2014 [17:07:07], Amos Kong wrote: When I check hwrng attributes in sysfs, cat process always gets stuck if guest has only 1 vcpu and uses a slow rng backend. Currently we check if there is any tasks waiting to be run on current cpu in rng_dev_read() by need_resched(). But

blk-mq crash under KVM in multiqueue block code (with virtio-blk and ext4)

2014-09-11 Thread Christian Borntraeger
Folks, we have seen the following bug with 3.16 as a KVM guest. It suspect the blk-mq rework that happened between 3.15 and 3.16, but it can be something completely different. [ 65.992022] Unable to handle kernel pointer dereference in virtual kernel address space [ 65.992187] failing

Re: Rusty away 18th September -- 11th October

2014-09-11 Thread Michael S. Tsirkin
On Thu, Sep 11, 2014 at 10:26:52AM +0930, Rusty Russell wrote: Hi all, Probably won't read mail. Linus, I'll have pull requests early next week; if there's anything needed I'm sure Michael Tsirkin can handle it. Sure. Rusty, there's a small chance virtio 1.0 bits will be ready in

Re: [PATCH 2/2] virtio-rng: fix stuck in catting hwrng attributes

2014-09-11 Thread Rusty Russell
Amos Kong ak...@redhat.com writes: When I check hwrng attributes in sysfs, cat process always gets stuck if guest has only 1 vcpu and uses a slow rng backend. Currently we check if there is any tasks waiting to be run on current cpu in rng_dev_read() by need_resched(). But need_resched()

[PATCH 2/2] virtio-gpu/2d: add docs/specs/virtio-gpu.txt

2014-09-11 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- docs/specs/virtio-gpu.txt | 165 ++ 1 file changed, 165 insertions(+) create mode 100644 docs/specs/virtio-gpu.txt diff --git a/docs/specs/virtio-gpu.txt b/docs/specs/virtio-gpu.txt new file mode

[PATCH 1/2] virtio-gpu/2d: add hardware spec include file

2014-09-11 Thread Gerd Hoffmann
This patch adds the header file with structs and defines for the virtio based gpu device. Covers 2d operations only. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/hw/virtio/virtgpu_hw.h | 158 + 1 file changed, 158 insertions(+) create mode

[PATCH 0/2] virtio-gpu: hardware specification

2014-09-11 Thread Gerd Hoffmann
Hi folks, Lets kick off the virtio-gpu review process, starting with the virtio protocol. This is a tiny patch series for qemu. Patch #1 carries the header file describing the virtual hardware: config space, command structs being sent over the rings, defines etc. Patch #2 adds a text file

Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file

2014-09-11 Thread Peter Maydell
On 11 September 2014 16:09, Gerd Hoffmann kra...@redhat.com wrote: This patch adds the header file with structs and defines for the virtio based gpu device. Covers 2d operations only. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/hw/virtio/virtgpu_hw.h | 158

Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file

2014-09-11 Thread Gerd Hoffmann
On Do, 2014-09-11 at 16:20 +0100, Peter Maydell wrote: On 11 September 2014 16:09, Gerd Hoffmann kra...@redhat.com wrote: This patch adds the header file with structs and defines for the virtio based gpu device. Covers 2d operations only. Please don't cc subscriber only mailing lists

Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file

2014-09-11 Thread Christopher Covington
On 09/11/2014 11:43 AM, Gerd Hoffmann wrote: On Do, 2014-09-11 at 16:20 +0100, Peter Maydell wrote: On 11 September 2014 16:09, Gerd Hoffmann kra...@redhat.com wrote: This patch adds the header file with structs and defines for the virtio based gpu device. Covers 2d operations only. Please

Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file

2014-09-11 Thread Eric Blake
On 09/11/2014 09:09 AM, Gerd Hoffmann wrote: This patch adds the header file with structs and defines for the virtio based gpu device. Covers 2d operations only. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/hw/virtio/virtgpu_hw.h | 158

Re: [Qemu-devel] [PATCH 2/2] virtio-gpu/2d: add docs/specs/virtio-gpu.txt

2014-09-11 Thread Eric Blake
On 09/11/2014 09:09 AM, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann kra...@redhat.com --- docs/specs/virtio-gpu.txt | 165 ++ 1 file changed, 165 insertions(+) create mode 100644 docs/specs/virtio-gpu.txt diff --git

Re: [virtio-dev] Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file

2014-09-11 Thread Paolo Bonzini
On Do, 2014-09-11 at 16:20 +0100, Peter Maydell wrote: On 11 September 2014 16:09, Gerd Hoffmann kra...@redhat.com wrote: This patch adds the header file with structs and defines for the virtio based gpu device. Covers 2d operations only. Please don't cc subscriber only mailing

Re: Rusty away 18th September -- 11th October

2014-09-11 Thread Linus Torvalds
On Wed, Sep 10, 2014 at 5:56 PM, Rusty Russell ru...@rustcorp.com.au wrote: Probably won't read mail. Linus, I'll have pull requests early next week; if there's anything needed I'm sure Michael Tsirkin can handle it. So according to normal timing, I would do the 3.17 release about

Re: [PATCH v3 1/2] virtio-rng: fix stuck of hot-unplugging busy device

2014-09-11 Thread Rusty Russell
Amit Shah amit.s...@redhat.com writes: On (Wed) 10 Sep 2014 [14:11:36], Amos Kong wrote: When we try to hot-remove a busy virtio-rng device from QEMU monitor, the device can't be hot-removed. Because virtio-rng driver hangs at wait_for_completion_killable(). This patch exits the waiting by