Re: [PATCH v3 net 1/3] ipv6: Select fragment id during UFO segmentation if not set.

2015-02-03 Thread David Miller
From: Vladislav Yasevich vyasev...@gmail.com Date: Tue, 3 Feb 2015 16:36:15 -0500 diff --git a/net/ipv6/output_core.c b/net/ipv6/output_core.c index 97f41a3..54520a0 100644 --- a/net/ipv6/output_core.c +++ b/net/ipv6/output_core.c @@ -9,6 +9,24 @@ #include net/addrconf.h #include

[PATCH v3 15/18] vhost: switch vhost get_indirect() to iov_iter, kill memcpy_fromiovec()

2015-02-03 Thread Al Viro
From: Al Viro v...@zeniv.linux.org.uk Cc: Michael S. Tsirkin m...@redhat.com Cc: k...@vger.kernel.org Cc: virtualization@lists.linux-foundation.org Signed-off-by: Al Viro v...@zeniv.linux.org.uk --- drivers/vhost/vhost.c | 6 -- include/linux/uio.h | 1 - lib/iovec.c | 25

[PATCH v3 16/18] vhost: don't bother with copying iovec in handle_tx()

2015-02-03 Thread Al Viro
From: Al Viro v...@zeniv.linux.org.uk just advance the msg.msg_iter and be done with that. Cc: Michael S. Tsirkin m...@redhat.com Cc: k...@vger.kernel.org Cc: virtualization@lists.linux-foundation.org Signed-off-by: Al Viro v...@zeniv.linux.org.uk --- drivers/vhost/net.c | 9 + 1 file

[PATCH v3 17/18] vhost: don't bother copying iovecs in handle_rx(), kill memcpy_toiovecend()

2015-02-03 Thread Al Viro
From: Al Viro v...@zeniv.linux.org.uk Cc: Michael S. Tsirkin m...@redhat.com Cc: k...@vger.kernel.org Cc: virtualization@lists.linux-foundation.org Signed-off-by: Al Viro v...@zeniv.linux.org.uk --- drivers/vhost/net.c | 82 +++--

[PATCH v3 18/18] vhost: vhost_scsi_handle_vq() should just use copy_from_user()

2015-02-03 Thread Al Viro
From: Al Viro v...@zeniv.linux.org.uk it has just verified that it asks no more than the length of the first segment of iovec. And with that the last user of stuff in lib/iovec.c is gone. RIP. Cc: Michael S. Tsirkin m...@redhat.com Cc: Nicholas A. Bellinger n...@linux-iscsi.org Cc:

[PATCH for-3.19] vhost/net: fix up num_buffers endian-ness

2015-02-03 Thread Michael S. Tsirkin
In virtio 1.0 mode, when mergeable buffers are enabled on a big-endian host, num_buffers wasn't byte-swapped correctly, so large incoming packets got corrupted. To fix, fill it in within hdr - this also makes sure it gets the correct type. Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

Re: [PATCH] virtio_console: fix sparse warnings

2015-02-03 Thread Greg Kroah-Hartman
On Mon, Dec 01, 2014 at 01:35:57PM +0200, Michael S. Tsirkin wrote: CHECK drivers/char/virtio_console.c drivers/char/virtio_console.c:687:36: warning: incorrect type in argument 1 (different address spaces) drivers/char/virtio_console.c:687:36:expected void [noderef] asn:1*to

[PATCH v3 net 3/3] Revert drivers/net: Disable UFO through virtio

2015-02-03 Thread Vladislav Yasevich
This reverts commit 3d0ad09412ffe00c9afa201d01effdb6023d09b4. Now that GSO functionality can correctly track if the fragment id has been selected and select a fragment id if necessary, we can re-enable UFO on tap/macvap and virtio devices. Signed-off-by: Vladislav Yasevich vyase...@redhat.com

[PATCH v3 net 1/3] ipv6: Select fragment id during UFO segmentation if not set.

2015-02-03 Thread Vladislav Yasevich
If the IPv6 fragment id has not been set and we perform fragmentation due to UFO, select a new fragment id. We now consider a fragment id of 0 as unset and if id selection process returns 0 (after all the pertrubations), we set it to 0x8000, thus giving us ample space not to create collisions

[PATCH v4 net 0/3] Restore UFO support to virtio_net devices

2015-02-03 Thread Vladislav Yasevich
commit 3d0ad09412ffe00c9afa201d01effdb6023d09b4 Author: Ben Hutchings b...@decadent.org.uk Date: Thu Oct 30 18:27:12 2014 + drivers/net: Disable UFO through virtio Turned off UFO support to virtio-net based devices due to issues with IPv6 fragment id generation for UFO packets. The