Re: [PATCH v2 5/6] virtio-gpu: add basic prime support

2015-09-22 Thread Daniel Vetter
On Tue, Sep 22, 2015 at 05:24:29PM +0200, Gerd Hoffmann wrote: > > > +int virtgpu_gem_prime_mmap(struct drm_gem_object *obj, > > > +struct vm_area_struct *area) > > > +{ > > > + WARN_ONCE(1, "not implemented"); > > > + return ENOSYS; > > > > This can get called by userspace, so

Re: [PATCH v7] pci: quirk to skip msi disable on shutdown

2015-09-22 Thread Michael S. Tsirkin
On Mon, Sep 21, 2015 at 05:10:43PM -0500, Bjorn Helgaas wrote: > On Mon, Sep 21, 2015 at 10:42:13PM +0300, Michael S. Tsirkin wrote: > > On Mon, Sep 21, 2015 at 01:21:47PM -0500, Bjorn Helgaas wrote: > > > On Sun, Sep 06, 2015 at 06:32:35PM +0300, Michael S. Tsirkin wrote: > > > > On some

Re: [PATCH v2 5/6] virtio-gpu: add basic prime support

2015-09-22 Thread Daniel Vetter
On Mon, Sep 21, 2015 at 11:40:16AM +0200, Gerd Hoffmann wrote: > From: Dave Airlie > > This is enough to enable DRI3. > > Signed-off-by: Dave Airlie > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/virtio/Makefile| 2

Re: [PATCH v2 4/6] virtio-gpu: add 3d/virgl support

2015-09-22 Thread Gerd Hoffmann
Hi, > > static unsigned int features[] = { > > +#ifdef __LITTLE_ENDIAN > > + VIRTIO_GPU_FEATURE_VIRGL, > > +#endif > > }; > > Why is virgl LE specific? Just curious. gallium command stream is native endian, and we only support little endian guests on little endian hosts for that reason.

Re: [PATCH v7] pci: quirk to skip msi disable on shutdown

2015-09-22 Thread Bjorn Helgaas via Virtualization
On Tue, Sep 22, 2015 at 02:29:03PM +0300, Michael S. Tsirkin wrote: > On Mon, Sep 21, 2015 at 05:10:43PM -0500, Bjorn Helgaas wrote: > > On Mon, Sep 21, 2015 at 10:42:13PM +0300, Michael S. Tsirkin wrote: > > > On Mon, Sep 21, 2015 at 01:21:47PM -0500, Bjorn Helgaas wrote: > > > > On Sun, Sep 06,

Re: [PATCH v7] pci: quirk to skip msi disable on shutdown

2015-09-22 Thread Michael S. Tsirkin
On Tue, Sep 22, 2015 at 07:36:40AM -0500, Bjorn Helgaas wrote: > On Tue, Sep 22, 2015 at 02:29:03PM +0300, Michael S. Tsirkin wrote: > > On Mon, Sep 21, 2015 at 05:10:43PM -0500, Bjorn Helgaas wrote: > > > On Mon, Sep 21, 2015 at 10:42:13PM +0300, Michael S. Tsirkin wrote: > > > > On Mon, Sep 21,

Re: [PATCH v2 5/6] virtio-gpu: add basic prime support

2015-09-22 Thread Gerd Hoffmann
> > +int virtgpu_gem_prime_mmap(struct drm_gem_object *obj, > > + struct vm_area_struct *area) > > +{ > > + WARN_ONCE(1, "not implemented"); > > + return ENOSYS; > > This can get called by userspace, so please don't WARN here. Also missing > negate sign: > > return

Re: [PATCH v7] pci: quirk to skip msi disable on shutdown

2015-09-22 Thread Bjorn Helgaas via Virtualization
On Tue, Sep 22, 2015 at 05:07:19PM +0300, Michael S. Tsirkin wrote: > On Tue, Sep 22, 2015 at 07:36:40AM -0500, Bjorn Helgaas wrote: > > On Tue, Sep 22, 2015 at 02:29:03PM +0300, Michael S. Tsirkin wrote: > > > On Mon, Sep 21, 2015 at 05:10:43PM -0500, Bjorn Helgaas wrote: > > > > Can you