Re: [PATCH v10] virtio-net: add Max MTU configuration field

On Tue, Sep 13, 2016 at 11:18:12AM -0400, Aaron Conole wrote: > It is helpful for a host to indicate it's MTU to be set on guest NICs > other than the assumed 1500 byte value. This helps in situations where > the host network is using Jumbo Frames, or aiding in PMTU discovery by > configuring a

Re: virtio_blk: Less function calls in init_vq() after error detection

On 09/13/2016 07:30 PM, SF Markus Elfring wrote: [...] > Unfortunately, I get an other impression here after a closer look. > > Can it be that the discussed commit from 2016-08-09 accepted (or tolerated) > two weaknesses at least? > > 1. Commit title: >Is the word "slient" a typo? >Would

Re: [PATCH v9 00/19] Add support for FDMA DMA controller and slim core rproc found on STi chipsets

On Tue 13 Sep 02:31 PDT 2016, Peter Griffin wrote: > Hi Vinod & Bjorn, > > [..] > > On Mon, 05 Sep 2016, Peter Griffin wrote: > > > v8 actions some review feedback from Bjorn to the slim rproc driver, and > > also includes > > a patch which fixes a recursive Kconfig error which is triggered

Re: [PATCH v9 01/19] remoteproc: st_slim_rproc: add a slimcore rproc driver

On Mon 05 Sep 06:16 PDT 2016, Peter Griffin wrote: > slim core is used as a basis for many IPs in the STi > chipsets such as fdma and demux. To avoid duplicating > the elf loading code in each device driver a slim > rproc driver has been created. > > This driver is designed to be used by other

Re: virtio_blk: Less function calls in init_vq() after error detection

> In addition, please have a look at commit > 347a529398e8e723338cca5d8a8ae2d9e7e93448 > virtio_blk: Fix a slient kernel panic I would like to add another view on the implementation details in this software update. > which did the opposite of your patch. This update contained a different

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

On Sat, Aug 20, 2016 at 05:07:43PM +0900, Namhyung Kim wrote: > Add virtio pstore device to allow kernel log files saved on the host. > It will save the log files on the directory given by pstore device > option. > > $ qemu-system-x86_64 -device virtio-pstore,directory=dir-xx ... > > (guest)

Re: [PATCH v10] virtio-net: add Max MTU configuration field

On Tue, Sep 13, 2016 at 11:18:12AM -0400, Aaron Conole wrote: > It is helpful for a host to indicate it's MTU to be set on guest NICs > other than the assumed 1500 byte value. This helps in situations where > the host network is using Jumbo Frames, or aiding in PMTU discovery by > configuring a

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

On Sat, Aug 20, 2016 at 05:07:42PM +0900, Namhyung Kim wrote: > The virtio pstore driver provides interface to the pstore subsystem so > that the guest kernel's log/dump message can be saved on the host > machine. Users can access the log file directly on the host, or on the > guest at the next

[PATCH v10] virtio-net: add Max MTU configuration field

It is helpful for a host to indicate it's MTU to be set on guest NICs other than the assumed 1500 byte value. This helps in situations where the host network is using Jumbo Frames, or aiding in PMTU discovery by configuring a homogenous network. It is also helpful for sizing receive buffers

Re: virtio_blk: Less function calls in init_vq() after error detection

>> drivers/block/virtio_blk.c | 22 +- >> 1 file changed, 17 insertions(+), 5 deletions(-) > > Can't you see from this diffstat that the patch actually seems to makes > the code more complex? I find that the repeated usage of a bit more error handling code is almost

Re: [PATCH 2/4] virtio_blk: Less function calls in init_vq() after error detection

On 09/13/2016 02:13 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 13 Sep 2016 13:20:44 +0200 > > The kfree() function was called in up to three cases > by the init_vq() function during error handling even if > the passed variable contained a null

[PATCH 4/4] virtio_blk: Rename a jump label in virtblk_get_id()

From: Markus Elfring Date: Tue, 13 Sep 2016 13:50:56 +0200 Adjust a jump label according to the current Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/block/virtio_blk.c | 4 ++-- 1 file changed, 2

[PATCH 3/4] virtio_blk: Delete an unnecessary initialisation in init_vq()

From: Markus Elfring Date: Tue, 13 Sep 2016 13:43:50 +0200 The local variable "err" will be set to an appropriate value by a following statement. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring

[PATCH 2/4] virtio_blk: Less function calls in init_vq() after error detection

From: Markus Elfring Date: Tue, 13 Sep 2016 13:20:44 +0200 The kfree() function was called in up to three cases by the init_vq() function during error handling even if the passed variable contained a null pointer. * Split a condition check for memory allocation

[PATCH 1/4] virtio_blk: Use kmalloc_array() in init_vq()

From: Markus Elfring Date: Tue, 13 Sep 2016 11:32:22 +0200 Multiplications for the size determination of memory allocations indicated that array data structures should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by

[PATCH 0/4] block-virtio: Fine-tuning for two function implementations

From: Markus Elfring Date: Tue, 13 Sep 2016 14:05:05 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (4): Use kmalloc_array() in init_vq() Less function calls in init_vq() after error detection Delete

Re: [PATCH v9 00/19] Add support for FDMA DMA controller and slim core rproc found on STi chipsets

Hi Vinod & Bjorn, [..] On Mon, 05 Sep 2016, Peter Griffin wrote: > v8 actions some review feedback from Bjorn to the slim rproc driver, and also > includes > a patch which fixes a recursive Kconfig error which is triggered when st_fdma > selects > slim_rproc driver. The series has also been

Re: [PATCH] virtio_pci: Limit DMA mask to 44 bits for legacy virtio devices

On Mon, Sep 12, 2016 at 8:57 AM, Will Deacon wrote: > > On Mon, Sep 12, 2016 at 06:33:43PM +0300, Michael S. Tsirkin wrote: > > On Mon, Sep 12, 2016 at 01:10:41PM +0100, Will Deacon wrote: > > > Legacy virtio defines the virtqueue base using a 32-bit PFN field, with > > > a