RE: [PATCH v3] crypto: add virtio-crypto driver

2016-11-28 Thread Gonglei (Arei)
> > > > > + > > > > +/* Note: kernel crypto API realization */ > > > > +static int virtio_crypto_ablkcipher_setkey(struct crypto_ablkcipher > > > > *tfm, > > > > +const uint8_t *key, > > > > +unsigned int keylen) > >

RE: [PATCH v3] crypto: add virtio-crypto driver

2016-11-28 Thread Gonglei (Arei)
Hi Halil, > > On 11/28/2016 06:19 PM, Michael S. Tsirkin wrote: > >>> +static int virtio_crypto_alg_ablkcipher_init_session( > >>> > > + struct virtio_crypto_ablkcipher_ctx *ctx, > >>> > > + uint32_t alg, const uint8_t *key, > >>> > > + unsigned int keylen, >

RE: [PATCH v3] crypto: add virtio-crypto driver

2016-11-28 Thread Gonglei (Arei)
Hi Michael and Stefan, > > Subject: Re: [PATCH v3] crypto: add virtio-crypto driver > > On Mon, Nov 28, 2016 at 04:20:55PM +, Stefan Hajnoczi wrote: > > On Mon, Nov 28, 2016 at 08:08:23PM +0800, Gonglei wrote: > > > This patch introduces virtio-crypto driver for Linux Kernel. > > > > > > The

RE: [virtio-dev] Re: [PATCH v3] crypto: add virtio-crypto driver

2016-11-28 Thread Gonglei (Arei)
> > Subject: [virtio-dev] Re: [PATCH v3] crypto: add virtio-crypto driver > > On Mon, 28 Nov 2016 20:08:23 +0800 > Gonglei wrote: > > > +static int virtcrypto_update_status(struct virtio_crypto *vcrypto) > > +{ > > + u32 status; > > + int err; > > + > > +

Re: [PATCH net-next] virtio-net: enable multiqueue by default

2016-11-28 Thread David Miller
From: Jason Wang Date: Fri, 25 Nov 2016 12:37:26 +0800 > We use single queue even if multiqueue is enabled and let admin to > enable it through ethtool later. This is used to avoid possible > regression (small packet TCP stream transmission). But looks like an > overkill

Re: [PATCH v3] crypto: add virtio-crypto driver

2016-11-28 Thread Halil Pasic
On 11/28/2016 06:19 PM, Michael S. Tsirkin wrote: >>> +static int virtio_crypto_alg_ablkcipher_init_session( >>> > > + struct virtio_crypto_ablkcipher_ctx *ctx, >>> > > + uint32_t alg, const uint8_t *key, >>> > > + unsigned int keylen, >>> > > +

Re: [PATCH v3] crypto: add virtio-crypto driver

2016-11-28 Thread Michael S. Tsirkin
On Mon, Nov 28, 2016 at 04:20:55PM +, Stefan Hajnoczi wrote: > On Mon, Nov 28, 2016 at 08:08:23PM +0800, Gonglei wrote: > > This patch introduces virtio-crypto driver for Linux Kernel. > > > > The virtio crypto device is a virtual cryptography device > > as well as a kind of virtual hardware

Re: [PATCH net-next] virtio-net: enable multiqueue by default

2016-11-28 Thread Michael S. Tsirkin
On Fri, Nov 25, 2016 at 12:37:26PM +0800, Jason Wang wrote: > We use single queue even if multiqueue is enabled and let admin to > enable it through ethtool later. This is used to avoid possible > regression (small packet TCP stream transmission). But looks like an > overkill since: > > - single

Re: [PATCH net-next] virtio-net: enable multiqueue by default

2016-11-28 Thread John Fastabend
On 16-11-28 08:28 AM, David Miller wrote: > From: "Michael S. Tsirkin" > Date: Fri, 25 Nov 2016 06:43:08 +0200 > >> On Fri, Nov 25, 2016 at 12:37:26PM +0800, Jason Wang wrote: >>> We use single queue even if multiqueue is enabled and let admin to >>> enable it through ethtool

Re: [PATCH net-next] virtio-net: enable multiqueue by default

2016-11-28 Thread David Miller
From: "Michael S. Tsirkin" Date: Fri, 25 Nov 2016 06:43:08 +0200 > On Fri, Nov 25, 2016 at 12:37:26PM +0800, Jason Wang wrote: >> We use single queue even if multiqueue is enabled and let admin to >> enable it through ethtool later. This is used to avoid possible >> regression

Re: [PATCH v3] crypto: add virtio-crypto driver

2016-11-28 Thread Stefan Hajnoczi
On Mon, Nov 28, 2016 at 08:08:23PM +0800, Gonglei wrote: > This patch introduces virtio-crypto driver for Linux Kernel. > > The virtio crypto device is a virtual cryptography device > as well as a kind of virtual hardware accelerator for > virtual machines. The encryption anddecryption requests >

Re: [PATCH v3] crypto: add virtio-crypto driver

2016-11-28 Thread kbuild test robot
Hi Gonglei, [auto build test ERROR on cryptodev/master] [also build test ERROR on v4.9-rc7 next-20161128] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Gonglei/crypto-add-virtio-crypto-driver

Re: [PATCH net-next] virtio-net: enable multiqueue by default

2016-11-28 Thread Neil Horman
On Fri, Nov 25, 2016 at 06:43:08AM +0200, Michael S. Tsirkin wrote: > On Fri, Nov 25, 2016 at 12:37:26PM +0800, Jason Wang wrote: > > We use single queue even if multiqueue is enabled and let admin to > > enable it through ethtool later. This is used to avoid possible > > regression (small packet

Re: [PATCH net-next] virtio-net: enable multiqueue by default

2016-11-28 Thread Neil Horman
On Fri, Nov 25, 2016 at 12:37:26PM +0800, Jason Wang wrote: > We use single queue even if multiqueue is enabled and let admin to > enable it through ethtool later. This is used to avoid possible > regression (small packet TCP stream transmission). But looks like an > overkill since: > > - single

Re: [PATCH] drm/virtio: fix framebuffer sparse warning

2016-11-28 Thread Michael S. Tsirkin
On Mon, Nov 28, 2016 at 09:05:21AM +0100, Gerd Hoffmann wrote: > virtio uses normal ram as backing storage for the framebuffer, so we > should assign the address to new screen_buffer (added by commit > 17a7b0b4d9749f80d365d7baff5dec2f54b0e992) instead of screen_base. > > Reported-by: Michael S.

Re: [PATCH v3] crypto: add virtio-crypto driver

2016-11-28 Thread Cornelia Huck
On Mon, 28 Nov 2016 20:08:23 +0800 Gonglei wrote: > +static int virtcrypto_update_status(struct virtio_crypto *vcrypto) > +{ > + u32 status; > + int err; > + > + virtio_cread(vcrypto->vdev, > + struct virtio_crypto_config, status, ); > + > + /*

[PATCH v3] virtio-crypto: add Linux driver

2016-11-28 Thread Gonglei
v3: - set cpu affinity when data queues are not equal to the number of online cpus. [Michael] - add TODO comments for cpu hotplug (changing the relationship of binding virtqueue and cpu) - use __u32/64 in the config space since the virtio->get() doesn't support byte-swap yet. [Michael] -

[PATCH] drm/virtio: fix framebuffer sparse warning

2016-11-28 Thread Gerd Hoffmann
virtio uses normal ram as backing storage for the framebuffer, so we should assign the address to new screen_buffer (added by commit 17a7b0b4d9749f80d365d7baff5dec2f54b0e992) instead of screen_base. Reported-by: Michael S. Tsirkin Signed-off-by: Gerd Hoffmann