[PULL] vhost: cleanups and fixes

The following changes since commit c470abd4fde40ea6a0846a2beab642a578c0b8cd: Linux 4.10 (2017-02-19 14:34:00 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to

Re: [PATCH] virtio-console: avoid DMA from stack

On Wed, Mar 01, 2017 at 12:01:10PM -0800, Omar Sandoval wrote: > On Wed, Feb 01, 2017 at 07:17:12PM +0530, Amit Shah wrote: > > On (Wed) 01 Feb 2017 [00:02:27], Omar Sandoval wrote: > > > From: Omar Sandoval > > > > > > put_chars() stuffs the buffer it gets into an sg, but that

Re: [systemd-devel] udev virtio by-path naming

On 01.03.2017 20:23, Viktor Mihajlovski wrote: > On 01.03.2017 19:44, Daniel P. Berrange wrote: > [...] > replying on the list, a bit lengthy >> >> Ok, my guest has 4 disks >> >> - sda - virtio-scsi, over virtio-pci transport >> - sdb - virtio-scsi, over virtio-mmio transport >> - vda -

Re: [PATCH] virtio-console: avoid DMA from stack

On Wed, Feb 01, 2017 at 07:17:12PM +0530, Amit Shah wrote: > On (Wed) 01 Feb 2017 [00:02:27], Omar Sandoval wrote: > > From: Omar Sandoval > > > > put_chars() stuffs the buffer it gets into an sg, but that buffer may be > > on the stack. This breaks with CONFIG_VMAP_STACK=y (for

Re: [systemd-devel] udev virtio by-path naming

On 01.03.2017 19:44, Daniel P. Berrange wrote: [...] replying on the list, a bit lengthy > > Ok, my guest has 4 disks > > - sda - virtio-scsi, over virtio-pci transport > - sdb - virtio-scsi, over virtio-mmio transport > - vda - virtio-scsi, over virtio-pci transport > - vdb - virtio-scsi,

Re: [systemd-devel] udev virtio by-path naming

On Wed, Mar 01, 2017 at 07:28:46PM +0100, Viktor Mihajlovski wrote: > On 01.03.2017 16:58, Daniel P. Berrange wrote: > > given a basic Fedora 25 guest, with a virtio-mmio disk added as per the > > guide above... > > > > looking at device > >

Re: [systemd-devel] udev virtio by-path naming

On 01.03.2017 16:58, Daniel P. Berrange wrote: > On Wed, Mar 01, 2017 at 04:02:53PM +0100, Viktor Mihajlovski wrote: >> On 01.03.2017 04:30, Zbigniew Jędrzejewski-Szmek wrote: >>> On Tue, Feb 28, 2017 at 09:47:42AM +0100, Viktor Mihajlovski wrote: One could argue about back-level

Re: [systemd-devel] udev virtio by-path naming

On Wed, Mar 01, 2017 at 03:58:12PM +, Daniel P. Berrange wrote: > On Wed, Mar 01, 2017 at 04:02:53PM +0100, Viktor Mihajlovski wrote: > > If wanted, I can take a stab at virtio-mmio, but would need the output > > of udevadm -a /dev/vda from a virtio-mmio system. > > Presumably you mean

Re: [systemd-devel] udev virtio by-path naming

On Wed, Mar 01, 2017 at 04:02:53PM +0100, Viktor Mihajlovski wrote: > On 01.03.2017 04:30, Zbigniew Jędrzejewski-Szmek wrote: > > On Tue, Feb 28, 2017 at 09:47:42AM +0100, Viktor Mihajlovski wrote: > >> One could argue about back-level compatibility, but virtio by-path > >> naming has

Re: [systemd-devel] udev virtio by-path naming

On 01.03.2017 04:30, Zbigniew Jędrzejewski-Szmek wrote: > On Tue, Feb 28, 2017 at 09:47:42AM +0100, Viktor Mihajlovski wrote: >> One could argue about back-level compatibility, but virtio by-path >> naming has changed multiple times. We have seen virtio-pci-virtio >> (not predictable),

Re: [PATCH] drm: virtio: use kmem_cache

On Wed, Mar 01, 2017 at 03:09:08PM +0100, Gerd Hoffmann wrote: > Just use kmem_cache instead of rolling > our own, limited implementation. > > Signed-off-by: Gerd Hoffmann Looks very reasonable. Reviewed-by: Daniel Vetter > --- >

[PATCH] drm: virtio: use kmem_cache

Just use kmem_cache instead of rolling our own, limited implementation. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_drv.h | 4 +-- drivers/gpu/drm/virtio/virtgpu_vq.c | 57 +++- 2 files changed, 11 insertions(+), 50

[PATCH 2/4] qxl: limit monitor config read retries

When reading the monitor config fails, don't retry forever. If it fails ten times in a row just give up to avoid the driver hangs. Also add a small delay after each attempt, so the host has a chance to complete a partial update. Signed-off-by: Gerd Hoffmann ---

[PATCH 3/4] qxl: read monitors config at boot

Try to read the client monitors config at driver load time, even without explicit notification. So in case that info was filled before the driver loaded and we've missed the notifications because of that the settings will still be used. With that place we now have to take care to properly handle

[PATCH 4/4] qxl: fix qxl_conn_get_modes

Call qxl_add_monitors_config_modes() unconditionally. Do all sanity checks in that function. Fix sanity checks. monitors_config is the current monitor configuration, whereas client_monitors_config is the configuration requested by the spice client. So when filling the mode list, based on the

[PATCH 1/4] qxl: drop mode_info.modes & related code.

very old qxl hardware revisions (predating qxl ksm support by a few years) supported a fixed list of video modes only. The list is still provided by the virtual hardware, for backward compatibility reasons. The qxl kms driver never ever looks at it, except for dumping it to the kernel log at