Re: [PATCH net-next 7/8] vhost_net: try batch dequing from skb array

2017-03-22 Thread Jason Wang
On 2017年03月22日 22:16, Michael S. Tsirkin wrote: On Tue, Mar 21, 2017 at 12:04:46PM +0800, Jason Wang wrote: We used to dequeue one skb during recvmsg() from skb_array, this could be inefficient because of the bad cache utilization and spinlock touching for each packet. This patch tries to

Re: [PATCH net-next 1/8] ptr_ring: introduce batch dequeuing

2017-03-22 Thread Jason Wang
On 2017年03月22日 21:43, Michael S. Tsirkin wrote: On Tue, Mar 21, 2017 at 12:04:40PM +0800, Jason Wang wrote: Signed-off-by: Jason Wang --- include/linux/ptr_ring.h | 65 1 file changed, 65 insertions(+) diff --git

Re: [REGRESSION] 07ec51480b5e ("virtio_pci: use shared interrupts for virtqueues") causes crashes in guest

2017-03-22 Thread Jason Wang
On 2017年03月23日 08:30, Laura Abbott wrote: Hi, Fedora has received multiple reports of crashes when running 4.11 as a guest https://bugzilla.redhat.com/show_bug.cgi?id=1430297 https://bugzilla.redhat.com/show_bug.cgi?id=1434462 https://bugzilla.kernel.org/show_bug.cgi?id=194911

Re: [PATCH 2] net: virtio_net: use new api ethtool_{get|set}_link_ksettings

2017-03-22 Thread David Miller
From: Philippe Reynes Date: Tue, 21 Mar 2017 23:24:24 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes > --- > Changelog: > v2: > - remove comment about

[REGRESSION] 07ec51480b5e ("virtio_pci: use shared interrupts for virtqueues") causes crashes in guest

2017-03-22 Thread Laura Abbott
Hi, Fedora has received multiple reports of crashes when running 4.11 as a guest https://bugzilla.redhat.com/show_bug.cgi?id=1430297 https://bugzilla.redhat.com/show_bug.cgi?id=1434462 https://bugzilla.kernel.org/show_bug.cgi?id=194911 https://bugzilla.redhat.com/show_bug.cgi?id=1433899 The

Re: [PATCH] virtio_balloon: don't push uninitialized buffers to stats virtqueue

2017-03-22 Thread Ladi Prosek
On Wed, Mar 22, 2017 at 6:15 PM, Michael S. Tsirkin wrote: > On Wed, Mar 22, 2017 at 06:05:39PM +0100, Ladi Prosek wrote: >> On Wed, Mar 22, 2017 at 5:14 PM, Michael S. Tsirkin wrote: >> > On Wed, Mar 22, 2017 at 04:10:27PM +0100, Ladi Prosek wrote: >> >> When

Re: [PATCH] virtio_balloon: don't push uninitialized buffers to stats virtqueue

2017-03-22 Thread Michael S. Tsirkin
On Wed, Mar 22, 2017 at 06:05:39PM +0100, Ladi Prosek wrote: > On Wed, Mar 22, 2017 at 5:14 PM, Michael S. Tsirkin wrote: > > On Wed, Mar 22, 2017 at 04:10:27PM +0100, Ladi Prosek wrote: > >> When init_vqs runs, virtio_balloon.stats is either uninitialized or > >> contains stale

Re: [PATCH] virtio_balloon: don't push uninitialized buffers to stats virtqueue

2017-03-22 Thread Ladi Prosek
On Wed, Mar 22, 2017 at 5:14 PM, Michael S. Tsirkin wrote: > On Wed, Mar 22, 2017 at 04:10:27PM +0100, Ladi Prosek wrote: >> When init_vqs runs, virtio_balloon.stats is either uninitialized or >> contains stale values. The host updates its state with garbage data >> because it

Re: [PATCH] virtio_balloon: don't push uninitialized buffers to stats virtqueue

2017-03-22 Thread Michael S. Tsirkin
On Wed, Mar 22, 2017 at 04:10:27PM +0100, Ladi Prosek wrote: > When init_vqs runs, virtio_balloon.stats is either uninitialized or > contains stale values. The host updates its state with garbage data > because it has no way of knowing that this is just a marker buffer > used for signaling. > >

[PATCH] virtio_balloon: don't push uninitialized buffers to stats virtqueue

2017-03-22 Thread Ladi Prosek
When init_vqs runs, virtio_balloon.stats is either uninitialized or contains stale values. The host updates its state with garbage data because it has no way of knowing that this is just a marker buffer used for signaling. This patch initializes all tags with U16_MAX which is guaranteed to be

Re: [PATCH net-next 7/8] vhost_net: try batch dequing from skb array

2017-03-22 Thread Michael S. Tsirkin
On Tue, Mar 21, 2017 at 12:04:46PM +0800, Jason Wang wrote: > We used to dequeue one skb during recvmsg() from skb_array, this could > be inefficient because of the bad cache utilization and spinlock > touching for each packet. This patch tries to batch them by calling > batch dequeuing helpers

Re: [PATCH net-next 1/8] ptr_ring: introduce batch dequeuing

2017-03-22 Thread Michael S. Tsirkin
On Tue, Mar 21, 2017 at 12:04:40PM +0800, Jason Wang wrote: > Signed-off-by: Jason Wang > --- > include/linux/ptr_ring.h | 65 > > 1 file changed, 65 insertions(+) > > diff --git a/include/linux/ptr_ring.h

RE: [PATCH kernel v8 3/4] mm: add inerface to offer info about unused pages

2017-03-22 Thread Wang, Wei W
Hi Andrew, Do you have any comments on my thoughts? Thanks. > On 03/17/2017 05:28 AM, Andrew Morton wrote: > > On Thu, 16 Mar 2017 15:08:46 +0800 Wei Wang > wrote: > > > >> From: Liang Li > >> > >> This patch adds a function to provides a snapshot