Re: [PATCH v11 4/6] mm: function to offer a page block on the free list

2017-06-12 Thread Wei Wang
On 06/13/2017 04:54 AM, Dave Hansen wrote: On 06/12/2017 01:34 PM, Michael S. Tsirkin wrote: On Mon, Jun 12, 2017 at 09:42:36AM -0700, Dave Hansen wrote: On 06/12/2017 09:28 AM, Michael S. Tsirkin wrote: The hypervisor is going to throw away the contents of these pages, right? It should be

Re: [PATCH] virtio_net: lower limit on buffer size

2017-06-12 Thread J. Bruce Fields
On Sat, Jun 03, 2017 at 11:17:30PM +0300, Sergei Shtylyov wrote: > On 06/02/2017 11:25 PM, J. Bruce Fields wrote: > > >>>commit d85b758f72b0 "virtio_net: fix support for small rings" > >> > >> Commit d85b758f72b0 ("virtio_net: fix support for small rings") > >> > >>>was supposed to increase the

[PATCH v1] virtio_blk: Use sysfs_match_string() helper

2017-06-12 Thread Andy Shevchenko
Use sysfs_match_string() helper instead of open coded variant. Cc: "Michael S. Tsirkin" Cc: Jason Wang Signed-off-by: Andy Shevchenko --- drivers/block/virtio_blk.c | 7 ++- 1 file changed, 2 insertions(+), 5

Re: [PATCH] virtio_net: lower limit on buffer size

2017-06-12 Thread J. Bruce Fields
On Fri, Jun 02, 2017 at 02:56:04AM +0300, Michael S. Tsirkin wrote: > commit d85b758f72b0 "virtio_net: fix support for small rings" > was supposed to increase the buffer size for small rings > but had an unintentional side effect of decreasing > it for large rings. This seems to break some setups

Re: [PATCH] virtio_net: lower limit on buffer size

2017-06-12 Thread J. Bruce Fields
On Fri, Jun 02, 2017 at 12:34:57PM +0300, Sergei Shtylyov wrote: > Hello! > > On 6/2/2017 2:56 AM, Michael S. Tsirkin wrote: > > >commit d85b758f72b0 "virtio_net: fix support for small rings" > >Commit d85b758f72b0 ("virtio_net: fix support for small rings") > > >was supposed to increase

Re: remove function pointer casts and constify function tables

2017-06-12 Thread bfie...@fieldses.org
On Tue, May 30, 2017 at 07:26:37PM +0300, Michael S. Tsirkin wrote: > On Fri, May 26, 2017 at 03:31:33PM -0400, bfie...@fieldses.org wrote: > > Looks like the culprit is very likely d85b758f72b0 "virtio_net: fix > > support for small rings". > > > > After that patch, my NFS server VM stops

Re: remove function pointer casts and constify function tables

2017-06-12 Thread bfie...@fieldses.org
On Wed, May 31, 2017 at 05:09:23PM -0400, bfie...@fieldses.org wrote: > On Tue, May 30, 2017 at 07:26:37PM +0300, Michael S. Tsirkin wrote: > > On Fri, May 26, 2017 at 03:31:33PM -0400, bfie...@fieldses.org wrote: > > > Looks like the culprit is very likely d85b758f72b0 "virtio_net: fix > > >

Re: remove function pointer casts and constify function tables

2017-06-12 Thread bfie...@fieldses.org
On Tue, May 30, 2017 at 07:58:06PM +0300, Michael S. Tsirkin wrote: > On Tue, May 30, 2017 at 07:26:37PM +0300, Michael S. Tsirkin wrote: > > On Fri, May 26, 2017 at 03:31:33PM -0400, bfie...@fieldses.org wrote: > > > Looks like the culprit is very likely d85b758f72b0 "virtio_net: fix > > >

Re: remove function pointer casts and constify function tables

2017-06-12 Thread bfie...@fieldses.org
On Tue, May 30, 2017 at 08:03:12PM +0300, Michael S. Tsirkin wrote: > On Fri, May 26, 2017 at 03:31:33PM -0400, bfie...@fieldses.org wrote: > > Looks like the culprit is very likely d85b758f72b0 "virtio_net: fix > > support for small rings". > > > > After that patch, my NFS server VM stops

[PATCH 02/37] drm: Remove drm_device->virtdev

2017-06-12 Thread Daniel Vetter
This is a leftover from the drm_bus days, where we've had a bus-specific device type for every bus type in drm_device. Except for pci (which we can't remove because dri1 drivers) this is all gone. And the virt driver also doesn't really need it, dev_to_virtio works perfectly fine. Cc: David

Re: remove function pointer casts and constify function tables

2017-06-12 Thread bfie...@fieldses.org
Probably should have cc'd virtualization@lists.linux-foundation.org too. On Fri, May 26, 2017 at 11:08:39AM -0400, bfie...@fieldses.org wrote: > On Tue, May 23, 2017 at 08:23:34AM -0400, bfie...@fieldses.org wrote: > > Unfortunately I can't get anything through testing. It's not your > >

Re: remove function pointer casts and constify function tables

2017-06-12 Thread bfie...@fieldses.org
Looks like the culprit is very likely d85b758f72b0 "virtio_net: fix support for small rings". After that patch, my NFS server VM stops responding to packets after a few minutes of testing. Before that patch, my server keeps working. --b. ___

Re: [PATCH 02/37] drm: Remove drm_device->virtdev

2017-06-12 Thread Neil Armstrong
On 05/24/2017 04:51 PM, Daniel Vetter wrote: > This is a leftover from the drm_bus days, where we've had a > bus-specific device type for every bus type in drm_device. Except for > pci (which we can't remove because dri1 drivers) this is all gone. And > the virt driver also doesn't really need it,

Re: [PATCH v11 4/6] mm: function to offer a page block on the free list

2017-06-12 Thread Dave Hansen
On 06/12/2017 01:34 PM, Michael S. Tsirkin wrote: > On Mon, Jun 12, 2017 at 09:42:36AM -0700, Dave Hansen wrote: >> On 06/12/2017 09:28 AM, Michael S. Tsirkin wrote: >>> The hypervisor is going to throw away the contents of these pages, right? >>> It should be careful and only throw away

Re: [PATCH v11 4/6] mm: function to offer a page block on the free list

2017-06-12 Thread Michael S. Tsirkin
On Mon, Jun 12, 2017 at 09:42:36AM -0700, Dave Hansen wrote: > On 06/12/2017 09:28 AM, Michael S. Tsirkin wrote: > > > >> The hypervisor is going to throw away the contents of these pages, > >> right? > > It should be careful and only throw away contents that was there before > >

Re: [PATCH v11 4/6] mm: function to offer a page block on the free list

2017-06-12 Thread Dave Hansen
On 06/12/2017 09:28 AM, Michael S. Tsirkin wrote: > >> The hypervisor is going to throw away the contents of these pages, >> right? > It should be careful and only throw away contents that was there before > report_unused_page_block was invoked. Hypervisor is responsible for not > corrupting

Re: [PATCH v11 4/6] mm: function to offer a page block on the free list

2017-06-12 Thread Michael S. Tsirkin
On Mon, Jun 12, 2017 at 07:10:12AM -0700, Dave Hansen wrote: > Please stop cc'ing me on things also sent to closed mailing lists > (virtio-...@lists.oasis-open.org). I'm happy to review things on open > lists, but I'm not fond of the closed lists bouncing things at me. > > On 06/09/2017 03:41

Re: [PATCH v11 4/6] mm: function to offer a page block on the free list

2017-06-12 Thread Dave Hansen
Please stop cc'ing me on things also sent to closed mailing lists (virtio-...@lists.oasis-open.org). I'm happy to review things on open lists, but I'm not fond of the closed lists bouncing things at me. On 06/09/2017 03:41 AM, Wei Wang wrote: > Add a function to find a page block on the free

Re: [PATCH v11 6/6] virtio-balloon: VIRTIO_BALLOON_F_CMD_VQ

2017-06-12 Thread Dave Hansen
On 06/09/2017 03:41 AM, Wei Wang wrote: > + for_each_populated_zone(zone) { > + for (order = MAX_ORDER - 1; order > 0; order--) { > + for (migratetype = 0; migratetype < MIGRATE_TYPES; > + migratetype++) { > +