Re: [PATCH v29 1/4] mm: support reporting free page blocks

2018-03-26 Thread Michal Hocko
On Tue 27-03-18 14:23:51, Wei Wang wrote: > On 03/27/2018 05:22 AM, Andrew Morton wrote: > > On Mon, 26 Mar 2018 10:39:51 +0800 Wei Wang wrote: > > > > > This patch adds support to walk through the free page blocks in the > > > system and report them via a callback function. Some page blocks may

Re: [PATCH v29 1/4] mm: support reporting free page blocks

2018-03-26 Thread Wei Wang
On 03/27/2018 05:22 AM, Andrew Morton wrote: On Mon, 26 Mar 2018 10:39:51 +0800 Wei Wang wrote: This patch adds support to walk through the free page blocks in the system and report them via a callback function. Some page blocks may leave the free list after zone->lock is released, so it is th

[PATCH net] vhost: correctly remove wait queue during poll failure

2018-03-26 Thread Jason Wang
We tried to remove vq poll from wait queue, but do not check whether or not it was in a list before. This will lead double free. Fixing this by checking poll->wqh to make sure it was in a list. Reported-by: syzbot+c0272972b01b872e6...@syzkaller.appspotmail.com Fixes: 2b8b328b61c79 ("vhost_net: han

Re: BUG: corrupted list in remove_wait_queue

2018-03-26 Thread Jason Wang
On 2018年03月24日 20:32, syzbot wrote: syzbot has found reproducer for the following crash on upstream commit 99fec39e7725d091c94d1bb0242e40c8092994f6 (Fri Mar 23 22:34:18 2018 +) Merge tag 'trace-v4.16-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace syzbot dashboard

Re: [RFC PATCH V2 0/8] Packed ring for vhost

2018-03-26 Thread Jason Wang
On 2018年03月27日 03:01, Konrad Rzeszutek Wilk wrote: On Mon, Mar 26, 2018 at 11:38:45AM +0800, Jason Wang wrote: Hi all: This RFC implement packed ring layout. The code were tested with pmd implement by Jens at http://dpdk.org/ml/archives/dev/2018-January/089417.html. Minor change was needed fo

Re: [PATCH v29 3/4] mm/page_poison: expose page_poisoning_enabled to kernel modules

2018-03-26 Thread Andrew Morton
On Mon, 26 Mar 2018 10:39:53 +0800 Wei Wang wrote: > In some usages, e.g. virtio-balloon, a kernel module needs to know if > page poisoning is in use. This patch exposes the page_poisoning_enabled > function to kernel modules. Acked-by: Andrew Morton

Re: [PATCH v29 1/4] mm: support reporting free page blocks

2018-03-26 Thread Andrew Morton
On Mon, 26 Mar 2018 10:39:51 +0800 Wei Wang wrote: > This patch adds support to walk through the free page blocks in the > system and report them via a callback function. Some page blocks may > leave the free list after zone->lock is released, so it is the caller's > responsibility to either dete

Re: [RFC PATCH V2 0/8] Packed ring for vhost

2018-03-26 Thread Konrad Rzeszutek Wilk
On Mon, Mar 26, 2018 at 11:38:45AM +0800, Jason Wang wrote: > Hi all: > > This RFC implement packed ring layout. The code were tested with pmd > implement by Jens at > http://dpdk.org/ml/archives/dev/2018-January/089417.html. Minor change > was needed for pmd codes to kick virtqueue since it assum

Re: [PATCH net] vhost_net: add missing lock nesting notation

2018-03-26 Thread David Miller
From: Jason Wang Date: Mon, 26 Mar 2018 16:10:23 +0800 > We try to hold TX virtqueue mutex in vhost_net_rx_peek_head_len() > after RX virtqueue mutex is held in handle_rx(). This requires an > appropriate lock nesting notation to calm down deadlock detector. > > Fixes: 0308813724606 ("vhost_net:

Re: [PATCH net] vhost_net: add missing lock nesting notation

2018-03-26 Thread Michael S. Tsirkin
On Mon, Mar 26, 2018 at 04:10:23PM +0800, Jason Wang wrote: > We try to hold TX virtqueue mutex in vhost_net_rx_peek_head_len() > after RX virtqueue mutex is held in handle_rx(). This requires an > appropriate lock nesting notation to calm down deadlock detector. > > Fixes: 0308813724606 ("vhost_n

[PATCH net] vhost_net: add missing lock nesting notation

2018-03-26 Thread Jason Wang
We try to hold TX virtqueue mutex in vhost_net_rx_peek_head_len() after RX virtqueue mutex is held in handle_rx(). This requires an appropriate lock nesting notation to calm down deadlock detector. Fixes: 0308813724606 ("vhost_net: basic polling support") Reported-by: syzbot+7f073540b1384a614...@s