Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-12 Thread Jason Wang
On 2018年06月13日 12:24, Samudrala, Sridhar wrote: On 6/12/2018 7:38 PM, Jason Wang wrote: On 2018年06月12日 19:54, Michael S. Tsirkin wrote: On Wed, Jun 06, 2018 at 10:29:03AM +0800, Jason Wang wrote: On 2018年06月05日 20:33, Michael S. Tsirkin wrote: I don't think this is sufficient. If both

Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-12 Thread Samudrala, Sridhar
On 6/12/2018 7:38 PM, Jason Wang wrote: On 2018年06月12日 19:54, Michael S. Tsirkin wrote: On Wed, Jun 06, 2018 at 10:29:03AM +0800, Jason Wang wrote: On 2018年06月05日 20:33, Michael S. Tsirkin wrote: I don't think this is sufficient. If both primary and standby devices are present, a legacy

Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-12 Thread Jason Wang
On 2018年06月13日 08:20, Samudrala, Sridhar wrote: On 6/12/2018 4:54 AM, Michael S. Tsirkin wrote: On Wed, Jun 06, 2018 at 10:29:03AM +0800, Jason Wang wrote: On 2018年06月05日 20:33, Michael S. Tsirkin wrote: I don't think this is sufficient. If both primary and standby devices are present, a

Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-12 Thread Samudrala, Sridhar
On 6/12/2018 4:54 AM, Michael S. Tsirkin wrote: On Wed, Jun 06, 2018 at 10:29:03AM +0800, Jason Wang wrote: On 2018年06月05日 20:33, Michael S. Tsirkin wrote: I don't think this is sufficient. If both primary and standby devices are present, a legacy guest without support for the feature might

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-12 Thread Samudrala, Sridhar
On 6/12/2018 4:34 AM, Michael S. Tsirkin wrote: On Mon, Jun 11, 2018 at 10:02:45PM -0700, Samudrala, Sridhar wrote: On 6/11/2018 7:17 PM, Michael S. Tsirkin wrote: On Tue, Jun 12, 2018 at 09:54:44AM +0800, Jason Wang wrote: On 2018年06月12日 01:26, Michael S. Tsirkin wrote: On Mon, May 07, 2018

Re: [PATCH v4 1/3] compiler-gcc.h: add gnu_inline to all inline declarations

2018-06-12 Thread H. Peter Anvin
On 06/12/18 13:19, Nick Desaulniers wrote: > > Oh, by [0] __GCC_STDC_INLINE__ is indeed actually the correct symbol > to check for. Clang does support that, so nothing to fix there. > >> By the way, you should check clang against gcc's predefined macros by doing: >> >> gcc [options] -x c

Re: [PATCH 0/3] Use sbitmap instead of percpu_ida

2018-06-12 Thread Jens Axboe
On 6/12/18 1:05 PM, Matthew Wilcox wrote: > Removing the percpu_ida code nets over 400 lines of removal. It's not > as spectacular as deleting an entire architecture, but it's still a > worthy reduction in lines of code. > > Untested due to lack of hardware and not understanding how to set up a

Re: [PATCH 0/3] Use sbitmap instead of percpu_ida

2018-06-12 Thread Bart Van Assche
On Tue, 2018-06-12 at 12:05 -0700, Matthew Wilcox wrote: > Removing the percpu_ida code nets over 400 lines of removal. It's not > as spectacular as deleting an entire architecture, but it's still a > worthy reduction in lines of code. > > Untested due to lack of hardware and not understanding

[PATCH 3/3] Remove percpu_ida

2018-06-12 Thread Matthew Wilcox
With its one user gone, remove the library code. Signed-off-by: Matthew Wilcox --- include/linux/percpu_ida.h | 83 - lib/Makefile | 2 +- lib/percpu_ida.c | 370 - 3 files changed, 1 insertion(+), 454 deletions(-) delete

[PATCH 1/3] target: Abstract tag freeing

2018-06-12 Thread Matthew Wilcox
Introduce target_free_tag() and convert all drivers to use it. Signed-off-by: Matthew Wilcox --- drivers/scsi/qla2xxx/qla_target.c| 4 ++-- drivers/target/iscsi/iscsi_target_util.c | 2 +- drivers/target/sbp/sbp_target.c | 2 +- drivers/target/tcm_fc/tfc_cmd.c | 4 ++--

Re: [PATCH v4 1/3] compiler-gcc.h: add gnu_inline to all inline declarations

2018-06-12 Thread H. Peter Anvin
,Greg KH ,jarkko.sakki...@linux.intel.com,jgr...@suse.com,Josh Poimboeuf ,Matthias Kaehlcke ,thomas.lenda...@amd.com,Thiebaud Weksteen ,mj...@google.com,j...@perches.com From: h...@zytor.com Message-ID: <191e4ebe-4cb2-4c8b-ab61-689a91ffe...@zytor.com> On June 12, 2018 11:33:14 AM PDT, Nick

Re: [PATCH 1/2] Convert target drivers to use sbitmap

2018-06-12 Thread Matthew Wilcox
On Tue, Jun 12, 2018 at 04:32:03PM +, Bart Van Assche wrote: > On Tue, 2018-06-12 at 09:15 -0700, Matthew Wilcox wrote: > > On Tue, Jun 12, 2018 at 03:22:42PM +, Bart Van Assche wrote: > > > Please introduce functions in the target core for allocating and freeing > > > a tag > > > instead

Re: [PATCH 1/2] Convert target drivers to use sbitmap

2018-06-12 Thread Bart Van Assche
On Tue, 2018-06-12 at 09:15 -0700, Matthew Wilcox wrote: > On Tue, Jun 12, 2018 at 03:22:42PM +, Bart Van Assche wrote: > > On Tue, 2018-05-15 at 09:00 -0700, Matthew Wilcox wrote: > > > diff --git a/drivers/scsi/qla2xxx/qla_target.c > > > b/drivers/scsi/qla2xxx/qla_target.c > > > index

Re: [PATCH 1/2] Convert target drivers to use sbitmap

2018-06-12 Thread Matthew Wilcox
On Tue, Jun 12, 2018 at 03:22:42PM +, Bart Van Assche wrote: > On Tue, 2018-05-15 at 09:00 -0700, Matthew Wilcox wrote: > > diff --git a/drivers/scsi/qla2xxx/qla_target.c > > b/drivers/scsi/qla2xxx/qla_target.c > > index 025dc2d3f3de..cdf671c2af61 100644 > > ---

Re: [PATCH v6] virtio_blk: add DISCARD and WRIET ZEROES commands support

2018-06-12 Thread Stefan Hajnoczi
On Mon, Jun 11, 2018 at 03:37:00AM +, Liu, Changpeng wrote: > > > > -Original Message- > > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > > Sent: Friday, June 8, 2018 6:20 PM > > To: Liu, Changpeng > > Cc: virtualization@lists.linux-foundation.org; cav...@redhat.com; > >

Re: [PATCH 1/2] Convert target drivers to use sbitmap

2018-06-12 Thread Bart Van Assche
On Tue, 2018-05-15 at 09:00 -0700, Matthew Wilcox wrote: > diff --git a/drivers/scsi/qla2xxx/qla_target.c > b/drivers/scsi/qla2xxx/qla_target.c > index 025dc2d3f3de..cdf671c2af61 100644 > --- a/drivers/scsi/qla2xxx/qla_target.c > +++ b/drivers/scsi/qla2xxx/qla_target.c > @@ -3719,7 +3719,8 @@

Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-12 Thread Michael S. Tsirkin
On Wed, Jun 06, 2018 at 10:29:03AM +0800, Jason Wang wrote: > > > On 2018年06月05日 20:33, Michael S. Tsirkin wrote: > > I don't think this is sufficient. > > > > If both primary and standby devices are present, a legacy guest without > > support for the feature might see two devices with same mac

Re: [virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-12 Thread Michael S. Tsirkin
On Tue, Jun 05, 2018 at 03:09:26PM -0700, Siwei Liu wrote: > The thing is cloud service provider might prefer sticking to the same > level of service agreement (SLA) of keeping VF over migration, That requirement is trivially satisfied by just a single VF :) If your SLA does not require live

Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-12 Thread Michael S. Tsirkin
On Mon, Jun 11, 2018 at 10:02:45PM -0700, Samudrala, Sridhar wrote: > On 6/11/2018 7:17 PM, Michael S. Tsirkin wrote: > > On Tue, Jun 12, 2018 at 09:54:44AM +0800, Jason Wang wrote: > > > > > > On 2018年06月12日 01:26, Michael S. Tsirkin wrote: > > > > On Mon, May 07, 2018 at 04:09:54PM -0700,

Re: [PULL] vhost: cleanups and fixes

2018-06-12 Thread Wei Wang
On 06/12/2018 09:59 AM, Linus Torvalds wrote: On Mon, Jun 11, 2018 at 6:36 PM Michael S. Tsirkin wrote: Maybe it will help to have GFP_NONE which will make any allocation fail if attempted. Linus, would this address your comment? It would definitely have helped me initially overlook that call