Re: [PATCH net-next v2] net: vhost: improve performance when enable busyloop

2018-06-27 Thread Tonghao Zhang
On Wed, Jun 27, 2018 at 11:58 PM Michael S. Tsirkin wrote: > > On Wed, Jun 27, 2018 at 10:24:43PM +0800, Jason Wang wrote: > > > > > > On 2018年06月26日 13:17, xiangxia.m@gmail.com wrote: > > > From: Tonghao Zhang > > > > > > This patch improves the guest receive performance from > > > host. On

Re: [PATCH net-next v2] net: vhost: improve performance when enable busyloop

2018-06-27 Thread Tonghao Zhang
On Wed, Jun 27, 2018 at 10:24 PM Jason Wang wrote: > > > > On 2018年06月26日 13:17, xiangxia.m@gmail.com wrote: > > From: Tonghao Zhang > > > > This patch improves the guest receive performance from > > host. On the handle_tx side, we poll the sock receive > > queue at the same time. handle_rx d

Re: [PATCH net-next v2] net: vhost: improve performance when enable busyloop

2018-06-27 Thread Jason Wang
On 2018年06月27日 23:58, Michael S. Tsirkin wrote: On Wed, Jun 27, 2018 at 10:24:43PM +0800, Jason Wang wrote: On 2018年06月26日 13:17, xiangxia.m@gmail.com wrote: From: Tonghao Zhang This patch improves the guest receive performance from host. On the handle_tx side, we poll the sock receive

Re: [PATCH v2 0/5] Add virtio-iommu driver

2018-06-27 Thread Michael S. Tsirkin
On Wed, Jun 27, 2018 at 07:04:46PM +0100, Jean-Philippe Brucker wrote: > On 26/06/18 19:07, Michael S. Tsirkin wrote: > > So as I pointed out new virtio 0 device isn't really welcome ;) > > Agreed, virtio-iommu is expected to be implemented on virtio 1 and > later. I'll remove the two legacy-relat

Re: [PATCH v33 1/4] mm: add a function to get free page blocks

2018-06-27 Thread Michael S. Tsirkin
On Wed, Jun 27, 2018 at 09:05:39AM -0700, Linus Torvalds wrote: > [ Sorry for slow reply, my travels have made a mess of my inbox ] > > On Mon, Jun 25, 2018 at 6:55 PM Michael S. Tsirkin wrote: > > > > Linus, do you think it would be ok to have get_from_free_page_list > > actually pop entries fro

Re: [PATCH v2 0/5] Add virtio-iommu driver

2018-06-27 Thread Jean-Philippe Brucker
On 26/06/18 19:07, Michael S. Tsirkin wrote: > So as I pointed out new virtio 0 device isn't really welcome ;) Agreed, virtio-iommu is expected to be implemented on virtio 1 and later. I'll remove the two legacy-related paragraph from the spec and add a check in the driver as you suggested, to avo

Re: [PATCH v2 1/5] dt-bindings: virtio: Specify #iommu-cells value for a virtio-iommu

2018-06-27 Thread Rob Herring
On Tue, Jun 26, 2018 at 11:59 AM Jean-Philippe Brucker wrote: > > On 25/06/18 20:27, Rob Herring wrote: > > On Thu, Jun 21, 2018 at 08:06:51PM +0100, Jean-Philippe Brucker wrote: > >> A virtio-mmio node may represent a virtio-iommu device. This is discovered > >> by the virtio driver at probe time

Re: [virtio-dev] Re: [PATCH v34 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-27 Thread Michael S. Tsirkin
On Wed, Jun 27, 2018 at 01:27:55PM +0800, Wei Wang wrote: > On 06/27/2018 11:58 AM, Michael S. Tsirkin wrote: > > On Wed, Jun 27, 2018 at 11:00:05AM +0800, Wei Wang wrote: > > > On 06/27/2018 10:41 AM, Michael S. Tsirkin wrote: > > > > On Wed, Jun 27, 2018 at 09:24:18AM +0800, Wei Wang wrote: > > >

Re: [PATCH v33 1/4] mm: add a function to get free page blocks

2018-06-27 Thread Linus Torvalds
[ Sorry for slow reply, my travels have made a mess of my inbox ] On Mon, Jun 25, 2018 at 6:55 PM Michael S. Tsirkin wrote: > > Linus, do you think it would be ok to have get_from_free_page_list > actually pop entries from the free list and use them as the buffer > to store PAs? Honestly, what I

Re: [PATCH net-next v2] net: vhost: improve performance when enable busyloop

2018-06-27 Thread Michael S. Tsirkin
On Wed, Jun 27, 2018 at 10:24:43PM +0800, Jason Wang wrote: > > > On 2018年06月26日 13:17, xiangxia.m@gmail.com wrote: > > From: Tonghao Zhang > > > > This patch improves the guest receive performance from > > host. On the handle_tx side, we poll the sock receive > > queue at the same time. ha

Re: [PATCH net-next v2] net: vhost: improve performance when enable busyloop

2018-06-27 Thread Jason Wang
On 2018年06月26日 13:17, xiangxia.m@gmail.com wrote: From: Tonghao Zhang This patch improves the guest receive performance from host. On the handle_tx side, we poll the sock receive queue at the same time. handle_rx do that in the same way. For avoiding deadlock, change the code to lock the

Re: [PATCH v34 0/4] Virtio-balloon: support free page reporting

2018-06-27 Thread David Hildenbrand
On 25.06.2018 14:05, Wei Wang wrote: > This patch series is separated from the previous "Virtio-balloon > Enhancement" series. The new feature, VIRTIO_BALLOON_F_FREE_PAGE_HINT, > implemented by this series enables the virtio-balloon driver to report > hints of guest free pages to the host. It can

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-27 Thread Cornelia Huck
On Sat, 23 Jun 2018 00:43:24 +0300 "Michael S. Tsirkin" wrote: > On Fri, Jun 22, 2018 at 05:09:55PM +0200, Cornelia Huck wrote: > > Would it be more helpful to focus on generic > > migration support for vfio instead of going about it device by device? > > Just to note this approach is actually

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-27 Thread Cornelia Huck
On Tue, 26 Jun 2018 20:50:20 +0300 "Michael S. Tsirkin" wrote: > On Tue, Jun 26, 2018 at 05:08:13PM +0200, Cornelia Huck wrote: > > On Fri, 22 Jun 2018 17:05:04 -0700 > > Siwei Liu wrote: > > > > > On Fri, Jun 22, 2018 at 3:33 PM, Michael S. Tsirkin > > > wrote: > > > > I suspect the dive

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-27 Thread Siwei Liu
On Tue, Jun 26, 2018 at 11:49 PM, Samudrala, Sridhar wrote: > On 6/26/2018 11:21 PM, Siwei Liu wrote: >> >> On Tue, Jun 26, 2018 at 5:29 PM, Michael S. Tsirkin >> wrote: >>> >>> On Tue, Jun 26, 2018 at 04:38:26PM -0700, Siwei Liu wrote: On Mon, Jun 25, 2018 at 6:50 PM, Michael S. Tsirki