Re: [PATCH 2/5] VSOCK: support fill data to mergeable rx buffer in host

2018-11-06 Thread jiangyiwen
On 2018/11/7 14:18, Jason Wang wrote: > > On 2018/11/6 下午2:30, jiangyiwen wrote: >>> Seems duplicated with the one used by vhost-net. >>> >>> In packed virtqueue implementation, I plan to move this to vhost.c. >>> >> Yes, this code is full copied from vhost-net, if it can be packed into >> vhost.c

Re: [PATCH 3/5] VSOCK: support receive mergeable rx buffer in guest

2018-11-06 Thread jiangyiwen
On 2018/11/7 14:20, Jason Wang wrote: > > On 2018/11/6 下午2:41, jiangyiwen wrote: >> On 2018/11/6 12:00, Jason Wang wrote: >>> On 2018/11/5 下午3:47, jiangyiwen wrote: Guest receive mergeable rx buffer, it can merge scatter rx buffer into a big buffer and then copy to user space.

[PATCH] drm/qxl: use ttm_tt

2018-11-06 Thread Gerd Hoffmann
qxl device will not dma, so we don't need ttm_dma_tt. Go use ttm_tt instead, to avoid wasting resources (swiotlb bounce buffers for example). Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_ttm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu

Re: [PATCH 3/5] VSOCK: support receive mergeable rx buffer in guest

2018-11-06 Thread Jason Wang
On 2018/11/6 下午2:41, jiangyiwen wrote: On 2018/11/6 12:00, Jason Wang wrote: On 2018/11/5 下午3:47, jiangyiwen wrote: Guest receive mergeable rx buffer, it can merge scatter rx buffer into a big buffer and then copy to user space. Signed-off-by: Yiwen Jiang --- include/linux/virtio_vsock.h

Re: [PATCH 2/5] VSOCK: support fill data to mergeable rx buffer in host

2018-11-06 Thread Jason Wang
On 2018/11/6 下午2:30, jiangyiwen wrote: Seems duplicated with the one used by vhost-net. In packed virtqueue implementation, I plan to move this to vhost.c. Yes, this code is full copied from vhost-net, if it can be packed into vhost.c, it would be great. If you try to reuse vhost-net, you

Re: [PATCH 1/5] VSOCK: support fill mergeable rx buffer in guest

2018-11-06 Thread Jason Wang
On 2018/11/6 下午2:22, jiangyiwen wrote: On 2018/11/6 11:38, Jason Wang wrote: On 2018/11/5 下午3:45, jiangyiwen wrote: In driver probing, if virtio has VIRTIO_VSOCK_F_MRG_RXBUF feature, it will fill mergeable rx buffer, support for host send mergeable rx buffer. It will fill a page everytime to c

Re: [PATCH 0/1] vhost: add vhost_blk driver

2018-11-06 Thread Paolo Bonzini
On 06/11/2018 08:13, Christoph Hellwig wrote: > On Tue, Nov 06, 2018 at 10:45:08AM +0800, Jason Wang wrote: >>> Storage industry is shifting away from SCSI, which has a scaling >>> problem. >> >> Know little about storage. For scaling, do you mean SCSI protocol itself? If >> not, it's probably not

Re: [PATCH 1/1] Add vhost_blk driver

2018-11-06 Thread Stefan Hajnoczi
On Fri, Nov 02, 2018 at 06:21:23PM +, Vitaly Mayatskikh wrote: > This driver accelerates host side of virtio-blk. Did you look at vhost-user-blk? It does things slightly differently: more of the virtio-blk device model is handled by the vhost-user device (e.g. config space). That might be ne

Re: [PATCH 0/1] vhost: add vhost_blk driver

2018-11-06 Thread Stefan Hajnoczi
On Fri, Nov 02, 2018 at 02:26:00PM -0400, Michael S. Tsirkin wrote: > On Fri, Nov 02, 2018 at 06:21:22PM +, Vitaly Mayatskikh wrote: > > vhost_blk is a host-side kernel mode accelerator for virtio-blk. The > > driver allows VM to reach a near bare-metal disk performance. See IOPS > > numbers be

Re: [PATCH 0/1] vhost: add vhost_blk driver

2018-11-06 Thread Stefan Hajnoczi
On Mon, Nov 05, 2018 at 11:15:04AM -0500, Vitaly Mayatskih wrote: > On Mon, Nov 5, 2018 at 10:48 AM Christian Borntraeger > wrote: > > > For the record, we still do use virtio-blk a lot. As we see new things like > > discard/write zero > > support it seems that others do as well. > > Yes, trim/

Re: [PATCH 0/1] vhost: add vhost_blk driver

2018-11-06 Thread Christoph Hellwig
On Tue, Nov 06, 2018 at 10:45:08AM +0800, Jason Wang wrote: > > Storage industry is shifting away from SCSI, which has a scaling > > problem. > > > Know little about storage. For scaling, do you mean SCSI protocol itself? If > not, it's probably not a real issue for virtio-scsi itself. The above