Re: [PATCH v1 0/2] Virtio: fix some vq allocation issues

2018-12-27 Thread Christian Borntraeger
On 28.12.2018 03:26, Wei Wang wrote: > Some vqs don't need to be allocated when the related feature bits are > disabled. Callers notice the vq allocation layer by setting the related > names[i] to be NULL. > > This patch series fixes the find_vqs implementations to handle this case. So the

[RFC PATCH V2 1/3] vhost: generalize adding used elem

2018-12-27 Thread Jason Wang
Use one generic vhost_copy_to_user() instead of two dedicated accessor. This will simplify the conversion to fine grain accessors. About 2% improvement of PPS were seen during vitio-user txonly test. Signed-off-by: Jason Wang --- drivers/vhost/vhost.c | 11 +-- 1 file changed, 1

[RFC PATCH V2 2/3] vhost: fine grain userspace memory accessors

2018-12-27 Thread Jason Wang
This is used to hide the metadata address from virtqueue helpers. This will allow to implement a vmap based fast accessing to metadata. Signed-off-by: Jason Wang --- drivers/vhost/vhost.c | 94 +++ 1 file changed, 77 insertions(+), 17 deletions(-) diff

[RFC PATCH V2 3/3] vhost: access vq metadata through kernel virtual address

2018-12-27 Thread Jason Wang
It was noticed that the copy_user() friends that was used to access virtqueue metdata tends to be very expensive for dataplane implementation like vhost since it involves lots of software checks, speculation barrier, hardware feature toggling (e.g SMAP). The extra cost will be more obvious when

[RFC PATCH V2 0/3] vhost: accelerate metadata access through vmap()

2018-12-27 Thread Jason Wang
Hi: This series tries to access virtqueue metadata through kernel virtual address instead of copy_user() friends since they had too much overheads like checks, spec barriers or even hardware feature toggling. Test shows about 24% improvement on TX PPS. It should benefit other cases as well.

Re: [PATCH v37 0/3] Virtio-balloon: support free page reporting

2018-12-27 Thread Wei Wang
On 12/27/2018 08:17 PM, Christian Borntraeger wrote: On 27.12.2018 12:59, Christian Borntraeger wrote: On 27.12.2018 12:31, Christian Borntraeger wrote: This patch triggers random crashes in the guest kernel on s390 early during boot. No migration and no setting of the balloon is involved.

Re: [PATCH v37 1/3] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-12-27 Thread Wei Wang
On 12/27/2018 08:03 PM, Christian Borntraeger wrote: On 27.08.2018 03:32, Wei Wang wrote: static int init_vqs(struct virtio_balloon *vb) { - struct virtqueue *vqs[3]; - vq_callback_t *callbacks[] = { balloon_ack, balloon_ack, stats_request }; - static const char * const

[PATCH v1 2/2] virtio: don't allocate vqs when names[i] = NULL

2018-12-27 Thread Wei Wang
Some vqs may not need to be allocated when their related feature bits are disabled. So callers may pass in such vqs with "names = NULL". Then we skip such vq allocations. Signed-off-by: Wei Wang --- drivers/misc/mic/vop/vop_main.c| 9 +++-- drivers/remoteproc/remoteproc_virtio.c |

[PATCH v1 1/2] virtio_pci: use queue idx instead of array idx to set up the vq

2018-12-27 Thread Wei Wang
When find_vqs, there will be no vq[i] allocation if its corresponding names[i] is NULL. For example, the caller may pass in names[i] (i=4) with names[2] being NULL because the related feature bit is turned off, so technically there are 3 queues on the device, and name[4] should correspond to the

[PATCH v1 0/2] Virtio: fix some vq allocation issues

2018-12-27 Thread Wei Wang
Some vqs don't need to be allocated when the related feature bits are disabled. Callers notice the vq allocation layer by setting the related names[i] to be NULL. This patch series fixes the find_vqs implementations to handle this case. Wei Wang (2): virtio_pci: use queue idx instead of array

CFP SECRYPT 2019 - Int.l Conf. on Security and Cryptography (Prague/Czech Republic)

2018-12-27 Thread ic...@insticc.info
SUBMISSION DEADLINE International Conference on Security and Cryptography Submission Deadline: February 28, 2019 http://www.secrypt.icete.org/ July 26 - 28, 2019 Prague, Czech Republic. In Cooperation with: Photonics21 and EOS. Proceedings will be submitted for

CFP WINSYS 2019 - Int.l Conf. on Wireless Networks and Mobile Systems (Prague/Czech Republic)

2018-12-27 Thread ic...@insticc.info
SUBMISSION DEADLINE International Conference on Wireless Networks and Mobile Systems Submission Deadline: February 28, 2019 http://www.winsys.icete.org/ July 26 - 28, 2019 Prague, Czech Republic. WINSYS is organized in 3 major tracks: - Sensor Networks and Ad Hoc Communications -

CFP DCNET 2019 - Int.l Conf. on Data Communication Networking (Prague/Czech Republic)

2018-12-27 Thread ic...@insticc.info
SUBMISSION DEADLINE International Conference on Data Communication Networking Submission Deadline: February 28, 2019 http://www.dcnet.icete.org/ July 26 - 28, 2019 Prague, Czech Republic. In Cooperation with: Photonics21 and EOS. Proceedings will be submitted for

CFP ICETE 2019 - 16th Int.l Joint Conf. on e-Business and Telecommunications (Prague/Czech Republic)

2018-12-27 Thread ic...@insticc.info
SUBMISSION DEADLINE 16th International Joint Conference on e-Business and Telecommunications Submission Deadline: February 28, 2019 http://www.icete.org/ July 26 - 28, 2019 Prague, Czech Republic. In Cooperation with: Photonics21 and EOS. Proceedings will be

Re: [PATCH v37 0/3] Virtio-balloon: support free page reporting

2018-12-27 Thread Christian Borntraeger
On 27.12.2018 12:59, Christian Borntraeger wrote: > On 27.12.2018 12:31, Christian Borntraeger wrote: >> This patch triggers random crashes in the guest kernel on s390 early during >> boot. >> No migration and no setting of the balloon is involved. >> > > Adding Conny and Halil, > > As the

Re: [PATCH v37 1/3] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-12-27 Thread Christian Borntraeger
On 27.08.2018 03:32, Wei Wang wrote: > static int init_vqs(struct virtio_balloon *vb) > { > - struct virtqueue *vqs[3]; > - vq_callback_t *callbacks[] = { balloon_ack, balloon_ack, stats_request > }; > - static const char * const names[] = { "inflate", "deflate", "stats" }; > -

Re: [PATCH v37 0/3] Virtio-balloon: support free page reporting

2018-12-27 Thread Christian Borntraeger
On 27.12.2018 12:31, Christian Borntraeger wrote: > This patch triggers random crashes in the guest kernel on s390 early during > boot. > No migration and no setting of the balloon is involved. > Adding Conny and Halil, As the QEMU provides no PAGE_HINT feature yet, this quick hack makes the

Re: [PATCH v37 0/3] Virtio-balloon: support free page reporting

2018-12-27 Thread Christian Borntraeger
This patch triggers random crashes in the guest kernel on s390 early during boot. No migration and no setting of the balloon is involved. On 27.08.2018 03:32, Wei Wang wrote: > The new feature, VIRTIO_BALLOON_F_FREE_PAGE_HINT, implemented by this > series enables the virtio-balloon driver to

Re: [PATCH RFC 1/2] virtio-net: bql support

2018-12-27 Thread Jason Wang
On 2018/12/26 下午11:22, Michael S. Tsirkin wrote: On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote: On 2018/12/6 上午6:54, Michael S. Tsirkin wrote: When use_napi is set, let's enable BQLs. Note: some of the issues are similar to wifi. It's worth considering whether something similar

Re: [PATCH RFC 1/2] virtio-net: bql support

2018-12-27 Thread Jason Wang
On 2018/12/26 下午11:19, Michael S. Tsirkin wrote: On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote: On 2018/12/6 上午6:54, Michael S. Tsirkin wrote: When use_napi is set, let's enable BQLs. Note: some of the issues are similar to wifi. It's worth considering whether something similar

Re: [PATCH RFC 1/2] virtio-net: bql support

2018-12-27 Thread Jason Wang
On 2018/12/26 下午11:15, Michael S. Tsirkin wrote: On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote: On 2018/12/6 上午6:54, Michael S. Tsirkin wrote: When use_napi is set, let's enable BQLs. Note: some of the issues are similar to wifi. It's worth considering whether something similar

Re: [PATCH net-next 3/3] vhost: access vq metadata through kernel virtual address

2018-12-27 Thread Jason Wang
On 2018/12/26 下午11:02, Michael S. Tsirkin wrote: On Wed, Dec 26, 2018 at 11:57:32AM +0800, Jason Wang wrote: On 2018/12/25 下午8:50, Michael S. Tsirkin wrote: On Tue, Dec 25, 2018 at 06:05:25PM +0800, Jason Wang wrote: On 2018/12/25 上午2:10, Michael S. Tsirkin wrote: On Mon, Dec 24, 2018 at

Re: [PATCH net V2 4/4] vhost: log dirty page correctly

2018-12-27 Thread Jason Wang
On 2018/12/26 下午9:46, Michael S. Tsirkin wrote: On Wed, Dec 26, 2018 at 01:43:26PM +0800, Jason Wang wrote: On 2018/12/26 上午12:25, Michael S. Tsirkin wrote: On Tue, Dec 25, 2018 at 05:43:25PM +0800, Jason Wang wrote: On 2018/12/25 上午1:41, Michael S. Tsirkin wrote: On Mon, Dec 24, 2018 at