Re: [PATCH] drm/qxl: drop prime import/export callbacks

2019-04-08 Thread Gerd Hoffmann
On Tue, Apr 09, 2019 at 02:01:33PM +1000, Dave Airlie wrote: > On Sat, 12 Jan 2019 at 07:13, Dave Airlie wrote: > > > > On Thu, 10 Jan 2019 at 18:17, Gerd Hoffmann wrote: > > > > > > Also set prime_handle_to_fd and prime_fd_to_handle to NULL, > > > so drm will not advertive DRM_PRIME_CAP_{IMPORT,

[PATCH net] vhost: flush dcache page when logging dirty pages

2019-04-08 Thread Jason Wang
We set dirty bit through setting up kmaps and access them through kernel virtual address, this may result alias in virtually tagged caches that require a dcache flush afterwards. Cc: Christoph Hellwig Cc: James Bottomley Cc: Andrea Arcangeli Fixes: 3a4d5c94e9593 ("vhost_net: a kernel-level virt

[PATCH net] vhost: reject zero size iova range

2019-04-08 Thread Jason Wang
We used to accept zero size iova range which will lead a infinite loop in translate_desc(). Fixing this by failing the request in this case. Reported-by: syzbot+d21e6e297322a900c...@syzkaller.appspotmail.com Fixes: 6b1e6cc7 ("vhost: new device IOTLB API") Signed-off-by: Jason Wang --- drivers/vh

Re: [PATCH] drm/qxl: drop prime import/export callbacks

2019-04-08 Thread Dave Airlie
On Sat, 12 Jan 2019 at 07:13, Dave Airlie wrote: > > On Thu, 10 Jan 2019 at 18:17, Gerd Hoffmann wrote: > > > > Also set prime_handle_to_fd and prime_fd_to_handle to NULL, > > so drm will not advertive DRM_PRIME_CAP_{IMPORT,EXPORT} to > > userspace. It's been pointed out to me that disables DRI3

Re: INFO: task hung in vhost_net_stop_vq

2019-04-08 Thread Jason Wang
On 2019/3/26 下午6:28, Dmitry Vyukov wrote: On Tue, Mar 26, 2019 at 11:17 AM Jason Wang wrote: On 2019/3/25 下午10:02, Michael S. Tsirkin wrote: Looks like more iotlb locking mess? Looking at the calltrace: [ 221.743675] = [ 221.744297] [ INFO: poss

Re: [PATCH net v7] failover: allow name change on IFF_UP slave interfaces

2019-04-08 Thread Michael S. Tsirkin
On Mon, Apr 08, 2019 at 04:24:45PM -0400, Si-Wei Liu wrote: > When a netdev appears through hot plug then gets enslaved by a failover > master that is already up and running, the slave will be opened > right away after getting enslaved. Today there's a race that userspace > (udev) may fail to renam

Re: [PATCH RFC 3/4] vsock/virtio: change the maximum packet size allowed

2019-04-08 Thread Stefan Hajnoczi
On Mon, Apr 08, 2019 at 05:17:35PM +0200, Stefano Garzarella wrote: > On Mon, Apr 08, 2019 at 10:57:44AM -0400, Michael S. Tsirkin wrote: > > On Mon, Apr 08, 2019 at 04:55:31PM +0200, Stefano Garzarella wrote: > > > > Anyway, any change to this behavior requires compatibility so new guest > > > > d

Re: [PATCH RFC 3/4] vsock/virtio: change the maximum packet size allowed

2019-04-08 Thread Michael S. Tsirkin
On Mon, Apr 08, 2019 at 04:55:31PM +0200, Stefano Garzarella wrote: > > Anyway, any change to this behavior requires compatibility so new guest > > drivers work with old vhost_vsock.ko. Therefore we should probably just > > leave the limit for now. > > I understood your point of view and I comple

Re: [PATCH 1/1] virtio_blk: replace 0 by HCTX_TYPE_DEFAULT to index blk_mq_tag_set->map

2019-04-08 Thread Jens Axboe
On 3/11/19 7:31 PM, Dongli Zhang wrote: > Use HCTX_TYPE_DEFAULT instead of 0 to avoid hardcoding. Applied, thanks. -- Jens Axboe ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listin

Re: [PATCH 1/1] virtio_blk: replace 0 by HCTX_TYPE_DEFAULT to index blk_mq_tag_set->map

2019-04-08 Thread Dongli Zhang
ping? The similar patchset has been queued by linux-scsi 5.2/scsi-queue. virtio-blk is the last place where HCTX_TYPE_DEFAULT is hardcoded. It would be more friendly to cscope if the hardcoding is avoided. Thank you very much! Dongli Zhang On 03/12/2019 09:31 AM, Dongli Zhang wrote: > Use HCT

Re: [PATCH 0/2] Limit number of hw queues by nr_cpu_ids for virtio-blk and virtio-scsi

2019-04-08 Thread Dongli Zhang
ping? Thank you very much! Dongli Zhang On 03/27/2019 06:36 PM, Dongli Zhang wrote: > When tag_set->nr_maps is 1, the block layer limits the number of hw queues > by nr_cpu_ids. No matter how many hw queues are use by > virtio-blk/virtio-scsi, as they both have (tag_set->nr_maps == 1), they > ca

Re: [PATCH] virtio: Honour 'may_reduce_num' in vring_create_virtqueue

2019-04-08 Thread Jens Freimann
On Mon, Apr 08, 2019 at 02:33:22PM +0200, Cornelia Huck wrote: vring_create_virtqueue() allows the caller to specify via the may_reduce_num parameter whether the vring code is allowed to allocate a smaller ring than specified. However, the split ring allocation code tries to allocate a smaller r

Re: [RFC PATCH 01/12] virtio/s390: use vring_create_virtqueue

2019-04-08 Thread Michael S. Tsirkin
On Mon, Apr 08, 2019 at 01:01:28PM +0200, Cornelia Huck wrote: > On Fri, 5 Apr 2019 01:16:11 +0200 > Halil Pasic wrote: > > > The commit 2a2d1382fe9d ("virtio: Add improved queue allocation API") > > establishes a new way of allocating virtqueues (as a part of the effort > > that taught DMA to v

[PATCH] virtio: Honour 'may_reduce_num' in vring_create_virtqueue

2019-04-08 Thread Cornelia Huck
vring_create_virtqueue() allows the caller to specify via the may_reduce_num parameter whether the vring code is allowed to allocate a smaller ring than specified. However, the split ring allocation code tries to allocate a smaller ring on allocation failure regardless of what the caller specified

Re: [PATCH 00/15] Share TTM code among framebuffer drivers

2019-04-08 Thread Koenig, Christian
Well first problem is I'm not sure if that is a good idea. Essentially we want to get rid of TTM in the long run. On the other hand this work might aid with that goal, so it might be worth a try. Second is that this might actually not work of hand. The problem is here: > + /* TODO: This tes

Re: [RFC PATCH 01/12] virtio/s390: use vring_create_virtqueue

2019-04-08 Thread Cornelia Huck
On Fri, 5 Apr 2019 01:16:11 +0200 Halil Pasic wrote: > The commit 2a2d1382fe9d ("virtio: Add improved queue allocation API") > establishes a new way of allocating virtqueues (as a part of the effort > that taught DMA to virtio rings). > > In the future we will want virtio-ccw to use the DMA API

Re: [PATCH RFC 0/4] vsock/virtio: optimizations to increase the throughput

2019-04-08 Thread Stefan Hajnoczi
On Mon, Apr 08, 2019 at 02:43:28PM +0800, Jason Wang wrote: > Another thing that may help is to implement sendpage(), which will greatly > improve the performance. I can't find documentation for ->sendpage(). Is the idea that you get a struct page for the payload and can do zero-copy tx? (And ca

Re: [PATCH RFC 3/4] vsock/virtio: change the maximum packet size allowed

2019-04-08 Thread Stefan Hajnoczi
On Fri, Apr 05, 2019 at 12:07:47PM +0200, Stefano Garzarella wrote: > On Fri, Apr 05, 2019 at 09:24:47AM +0100, Stefan Hajnoczi wrote: > > On Thu, Apr 04, 2019 at 12:58:37PM +0200, Stefano Garzarella wrote: > > > Since now we are able to split packets, we can avoid limiting > > > their sizes to VIR

Re: [PATCH RFC 2/4] vhost/vsock: split packets to send using multiple buffers

2019-04-08 Thread Stefan Hajnoczi
On Fri, Apr 05, 2019 at 11:36:08AM +0200, Stefano Garzarella wrote: > On Fri, Apr 05, 2019 at 09:13:56AM +0100, Stefan Hajnoczi wrote: > > On Thu, Apr 04, 2019 at 12:58:36PM +0200, Stefano Garzarella wrote: > > > - vhost_add_used(vq, head, sizeof(pkt->hdr) + pkt->len); > > > + vhost

Re: [PATCH RFC 1/4] vsock/virtio: reduce credit update messages

2019-04-08 Thread Stefan Hajnoczi
On Fri, Apr 05, 2019 at 10:16:48AM +0200, Stefano Garzarella wrote: > On Thu, Apr 04, 2019 at 08:15:39PM +0100, Stefan Hajnoczi wrote: > > On Thu, Apr 04, 2019 at 12:58:35PM +0200, Stefano Garzarella wrote: > > > int err = -EFAULT; > > > > > > spin_lock_bh(&vvs->rx_lock); > > > @@ -288,9 +290

Re: [PATCH RFC 0/4] vsock/virtio: optimizations to increase the throughput

2019-04-08 Thread Stefan Hajnoczi
On Fri, Apr 05, 2019 at 09:49:17AM +0200, Stefano Garzarella wrote: > On Thu, Apr 04, 2019 at 02:04:10PM -0400, Michael S. Tsirkin wrote: > > On Thu, Apr 04, 2019 at 06:47:15PM +0200, Stefano Garzarella wrote: > > > On Thu, Apr 04, 2019 at 11:52:46AM -0400, Michael S. Tsirkin wrote: > > > > I simpl