Re: [Qemu-devel] [PATCH v7 6/6] xfs: disable map_sync for async flush

2019-05-07 Thread Pankaj Gupta
> > On Tue, May 07, 2019 at 08:37:01AM -0700, Dan Williams wrote: > > On Thu, Apr 25, 2019 at 10:03 PM Pankaj Gupta wrote: > > > > > > Dont support 'MAP_SYNC' with non-DAX files and DAX files > > > with asynchronous dax_device. Virtio pmem provides > > > asynchronous host page cache flush mecha

Re: [Qemu-devel] [PATCH v7 4/6] dax: check synchronous mapping is supported

2019-05-07 Thread Pankaj Gupta
> > From: Pankaj Gupta > Date: Thu, Apr 25, 2019 at 10:00 PM > > > +static inline bool daxdev_mapping_supported(struct vm_area_struct *vma, > > + struct dax_device *dax_dev) > > +{ > > + return !(vma->flags & VM_SYNC); > > +} > > Shouldn't it be rather `ret

Re: [PATCH RFC] vhost: don't use kmap() to log dirty pages

2019-05-07 Thread Jason Wang
On 2019/5/8 下午12:12, Michael S. Tsirkin wrote: On Mon, May 06, 2019 at 10:23:29PM -0400, Jason Wang wrote: Vhost log dirty pages directly to a userspace bitmap through GUP and kmap_atomic() since kernel doesn't have a set_bit_to_user() helper. This will cause issues for the arch that has virtua

Re: [PATCH RFC] vhost: don't use kmap() to log dirty pages

2019-05-07 Thread Michael S. Tsirkin
On Mon, May 06, 2019 at 10:23:29PM -0400, Jason Wang wrote: > Vhost log dirty pages directly to a userspace bitmap through GUP and > kmap_atomic() since kernel doesn't have a set_bit_to_user() > helper. This will cause issues for the arch that has virtually tagged > caches. The way to fix is to kee

Re: [PATCH RFC] vhost: don't use kmap() to log dirty pages

2019-05-07 Thread Jason Wang
On 2019/5/7 下午11:47, Christoph Hellwig wrote: > On Mon, May 06, 2019 at 10:23:29PM -0400, Jason Wang wrote: >> Note: there're archs (few non popular ones) that don't implement >> futex helper, we can't log dirty pages. We can fix them on top or >> simply disable LOG_ALL features of vhost. > > That

Re: [Qemu-devel] [RFC 0/3] VirtIO RDMA

2019-05-07 Thread Jason Gunthorpe
On Tue, Apr 30, 2019 at 08:13:54PM +0300, Yuval Shaia wrote: > On Mon, Apr 22, 2019 at 01:45:27PM -0300, Jason Gunthorpe wrote: > > On Fri, Apr 19, 2019 at 01:16:06PM +0200, Hannes Reinecke wrote: > > > On 4/15/19 12:35 PM, Yuval Shaia wrote: > > > > On Thu, Apr 11, 2019 at 07:02:15PM +0200, Cornel

Re: [PATCH v7 6/6] xfs: disable map_sync for async flush

2019-05-07 Thread Darrick J. Wong
On Tue, May 07, 2019 at 08:37:01AM -0700, Dan Williams wrote: > On Thu, Apr 25, 2019 at 10:03 PM Pankaj Gupta wrote: > > > > Dont support 'MAP_SYNC' with non-DAX files and DAX files > > with asynchronous dax_device. Virtio pmem provides > > asynchronous host page cache flush mechanism. We don't >

Re: [PATCH RFC] vhost: don't use kmap() to log dirty pages

2019-05-07 Thread Christoph Hellwig
On Mon, May 06, 2019 at 10:23:29PM -0400, Jason Wang wrote: > Note: there're archs (few non popular ones) that don't implement > futex helper, we can't log dirty pages. We can fix them on top or > simply disable LOG_ALL features of vhost. That means vhost now has to depend on HAVE_FUTEX_CMPXCHG to

Re: [PATCH v7 3/6] libnvdimm: add dax_dev sync flag

2019-05-07 Thread Dan Williams
On Thu, Apr 25, 2019 at 10:02 PM Pankaj Gupta wrote: > > This patch adds 'DAXDEV_SYNC' flag which is set > for nd_region doing synchronous flush. This later > is used to disable MAP_SYNC functionality for > ext4 & xfs filesystem for devices don't support > synchronous flush. > > Signed-off-by: Pan

Re: [PATCH v7 6/6] xfs: disable map_sync for async flush

2019-05-07 Thread Dan Williams
On Thu, Apr 25, 2019 at 10:03 PM Pankaj Gupta wrote: > > Dont support 'MAP_SYNC' with non-DAX files and DAX files > with asynchronous dax_device. Virtio pmem provides > asynchronous host page cache flush mechanism. We don't > support 'MAP_SYNC' with virtio pmem and xfs. > > Signed-off-by: Pankaj G

Re: [PATCH v7 2/6] virtio-pmem: Add virtio pmem driver

2019-05-07 Thread Dan Williams
Hi Pankaj, Some minor file placement comments below. On Thu, Apr 25, 2019 at 10:02 PM Pankaj Gupta wrote: > > This patch adds virtio-pmem driver for KVM guest. > > Guest reads the persistent memory range information from > Qemu over VIRTIO and registers it on nvdimm_bus. It also > creates a nd_r

Re: [PATCH 01/10] virtio/s390: use vring_create_virtqueue

2019-05-07 Thread Christian Borntraeger
On 05.05.19 13:15, Cornelia Huck wrote: > On Sat, 4 May 2019 16:03:40 +0200 > Halil Pasic wrote: > >> On Fri, 3 May 2019 16:04:48 -0400 >> "Michael S. Tsirkin" wrote: >> >>> On Fri, May 03, 2019 at 11:17:24AM +0200, Cornelia Huck wrote: On Fri, 26 Apr 2019 20:32:36 +0200 Halil Pas

Re: [PATCH] vsock/virtio: Initialize core virtio vsock before registering the driver

2019-05-07 Thread Stefano Garzarella
Hi Jorge, On Mon, May 06, 2019 at 01:19:55PM -0700, Jorge Moreira Broche wrote: > > On Wed, May 01, 2019 at 03:08:31PM -0400, Stefan Hajnoczi wrote: > > > On Tue, Apr 30, 2019 at 05:30:01PM -0700, Jorge E. Moreira wrote: > > > > Avoid a race in which static variables in net/vmw_vsock/af_vsock.c ar