Re: [PATCH] drm/virtio: fix mmap page attributes

2019-12-10 Thread Gurchetan Singh
On Tue, Dec 10, 2019 at 12:58 AM Gerd Hoffmann wrote: > > virtio-gpu uses cached mappings. shmem helpers use writecombine though. > So roll our own mmap function, wrapping drm_gem_shmem_mmap(), to tweak > vm_page_prot accordingly. > > Reported-by: Gurchetan Singh > Signed-off-by: Gerd Hoffmann

[PATCH AUTOSEL 4.14 113/130] crypto: virtio - deal with unsupported input sizes

2019-12-10 Thread Sasha Levin
From: Ard Biesheuvel [ Upstream commit 19c5da7d4a2662e85ea67d2d81df57e038fde3ab ] Return -EINVAL for input sizes that are not a multiple of the AES block size, since they are not supported by our CBC chaining mode. While at it, remove the pr_err() that reports unsupported key sizes being used:

[PATCH AUTOSEL 4.19 154/177] crypto: virtio - deal with unsupported input sizes

2019-12-10 Thread Sasha Levin
From: Ard Biesheuvel [ Upstream commit 19c5da7d4a2662e85ea67d2d81df57e038fde3ab ] Return -EINVAL for input sizes that are not a multiple of the AES block size, since they are not supported by our CBC chaining mode. While at it, remove the pr_err() that reports unsupported key sizes being used:

[PATCH AUTOSEL 5.4 297/350] crypto: virtio - deal with unsupported input sizes

2019-12-10 Thread Sasha Levin
From: Ard Biesheuvel [ Upstream commit 19c5da7d4a2662e85ea67d2d81df57e038fde3ab ] Return -EINVAL for input sizes that are not a multiple of the AES block size, since they are not supported by our CBC chaining mode. While at it, remove the pr_err() that reports unsupported key sizes being used:

[PATCH AUTOSEL 5.4 002/350] drm/virtio: switch virtio_gpu_wait_ioctl() to gem helper.

2019-12-10 Thread Sasha Levin
From: Gerd Hoffmann [ Upstream commit 29cf12394c0565d7eb1685bf0c1b4749aa6a8b66 ] Use drm_gem_reservation_object_wait() in virtio_gpu_wait_ioctl(). This also makes the ioctl run lockless. v9: fix return value. v5: handle lookup failure. v2: use reservation_object_test_signaled_rcu for

Re: [PATCH net-next v11 0/3] netdev: ndo_tx_timeout cleanup

2019-12-10 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 10 Dec 2019 08:08:58 -0500 > Sorry about the churn, v10 was based on net - not on net-next > by mistake. Ugh sorry, I just saw this. vger is sending postings massively out of order today. Ignore my previous reply to #1 :-)

Re: [PATCH net-next v10 1/3] netdev: pass the stuck queue to the timeout handler

2019-12-10 Thread David Miller
Michael, please provide a proper introductory posting for your patch series just like everyone else does. Not only does it help people understand at a high level what the patch series is doing, how it is doing it, and why it is doing it that way. It also gives me a single email to reply to

Call for Papers - MICRADS 2020, Quito, Ecuador | Deadline: December 23

2019-12-10 Thread Maria Lemos
* Proceedings by Springer, indexed by Scopus, ISI, EI-Compendex, Google Scholar, etc. -- MICRADS´20 - The 2020 Multidisciplinary International Conference of Research Applied to Defense and Security Quito, Ecuador, 13 - 15 May 2020

Re: [PATCH v2] virtio-balloon: fix managed page counts when migrating pages between zones

2019-12-10 Thread David Hildenbrand
On 10.12.19 16:24, Michael S. Tsirkin wrote: > On Tue, Dec 10, 2019 at 02:44:38PM +0100, David Hildenbrand wrote: >> On 05.12.19 10:24, David Hildenbrand wrote: >>> In case we have to migrate a ballon page to a newpage of another zone, the >>> managed page count of both zones is wrong. Paired with

Re: [PATCH v2] virtio-balloon: fix managed page counts when migrating pages between zones

2019-12-10 Thread Michael S. Tsirkin
On Tue, Dec 10, 2019 at 02:44:38PM +0100, David Hildenbrand wrote: > On 05.12.19 10:24, David Hildenbrand wrote: > > In case we have to migrate a ballon page to a newpage of another zone, the > > managed page count of both zones is wrong. Paired with memory offlining > > (which will adjust the

Re: [PATCH] vhost/vsock: accept only packets with the right dst_cid

2019-12-10 Thread Stefano Garzarella
On Tue, Dec 10, 2019 at 09:05:58AM -0500, Michael S. Tsirkin wrote: > On Fri, Dec 06, 2019 at 03:39:12PM +0100, Stefano Garzarella wrote: > > When we receive a new packet from the guest, we check if the > > src_cid is correct, but we forgot to check the dst_cid. > > > > The host should accept

Re: [PATCH RFC net-next v8 1/3] netdev: pass the stuck queue to the timeout handler

2019-12-10 Thread Michael S. Tsirkin
On Mon, Dec 09, 2019 at 08:40:06AM +0100, Geert Uytterhoeven wrote: > Hi Michael, > > On Tue, Dec 3, 2019 at 9:21 PM Michael S. Tsirkin wrote: > > This allows incrementing the correct timeout statistic without any mess. > > Down the road, devices can learn to reset just the specific queue. > > >

[PATCH net-next v12 3/3] netronome: use the new txqueue timeout argument

2019-12-10 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin Acked-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c

[PATCH net-next v12 0/3] netdev: ndo_tx_timeout cleanup

2019-12-10 Thread Michael S. Tsirkin
Yet another forward declaration I missed. Hopfully the last one ... A bunch of drivers want to know which tx queue triggered a timeout, and virtio wants to do the same. We actually have the info to hand, let's just pass it on to drivers. Note: tested with an experimental virtio patch by

[PATCH net-next v12 2/3] mlx4: use new txqueue timeout argument

2019-12-10 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c index

Re: [PATCH] vhost/vsock: accept only packets with the right dst_cid

2019-12-10 Thread Michael S. Tsirkin
On Fri, Dec 06, 2019 at 03:39:12PM +0100, Stefano Garzarella wrote: > When we receive a new packet from the guest, we check if the > src_cid is correct, but we forgot to check the dst_cid. > > The host should accept only packets where dst_cid is > equal to the host CID. > > Signed-off-by:

Re: [PATCH v2] virtio-balloon: fix managed page counts when migrating pages between zones

2019-12-10 Thread David Hildenbrand
On 05.12.19 10:24, David Hildenbrand wrote: > In case we have to migrate a ballon page to a newpage of another zone, the > managed page count of both zones is wrong. Paired with memory offlining > (which will adjust the managed page count), we can trigger kernel crashes > and all kinds of

Re: [PATCH] virtio-balloon: fix managed page counts when migrating pages between zones

2019-12-10 Thread David Hildenbrand
On 10.12.19 14:31, Michael S. Tsirkin wrote: > On Wed, Dec 04, 2019 at 09:48:07PM +0100, David Hildenbrand wrote: >> In case we have to migrate a ballon page to a newpage of another zone, the >> managed page count of both zones is wrong. Paired with memory offlining >> (which will adjust the

Re: [PATCH] virtio-balloon: fix managed page counts when migrating pages between zones

2019-12-10 Thread Michael S. Tsirkin
On Wed, Dec 04, 2019 at 09:48:07PM +0100, David Hildenbrand wrote: > In case we have to migrate a ballon page to a newpage of another zone, the > managed page count of both zones is wrong. Paired with memory offlining > (which will adjust the managed page count), we can trigger kernel crashes >

[PATCH net-next v11 2/3] mlx4: use new txqueue timeout argument

2019-12-10 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c index

[PATCH net-next v11 0/3] netdev: ndo_tx_timeout cleanup

2019-12-10 Thread Michael S. Tsirkin
Sorry about the churn, v10 was based on net - not on net-next by mistake. A bunch of drivers want to know which tx queue triggered a timeout, and virtio wants to do the same. We actually have the info to hand, let's just pass it on to drivers. Note: tested with an experimental virtio patch by

[PATCH net-next v11 3/3] netronome: use the new txqueue timeout argument

2019-12-10 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin Acked-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c

[PATCH net-next v10 2/3] mlx4: use new txqueue timeout argument

2019-12-10 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c index

[PATCH net-next v10 3/3] netronome: use the new txqueue timeout argument

2019-12-10 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin Acked-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c

[PATCH net-next v2 4/6] vsock: add vsock_loopback transport

2019-12-10 Thread Stefano Garzarella
This patch adds a new vsock_loopback transport to handle local communication. This transport is based on the loopback implementation of virtio_transport, so it uses the virtio_transport_common APIs to interface with the vsock core. Signed-off-by: Stefano Garzarella --- v1 -> v2: - fixed reverse

[PATCH net-next v2 5/6] vsock: use local transport when it is loaded

2019-12-10 Thread Stefano Garzarella
Now that we have a transport that can handle the local communication, we can use it when it is loaded. A socket will use the local transport (loopback) when the remote CID is: - equal to VMADDR_CID_LOCAL - or equal to transport_g2h->get_local_cid(), if transport_g2h is loaded (this allows us to

[PATCH net-next v2 6/6] vsock/virtio: remove loopback handling

2019-12-10 Thread Stefano Garzarella
We can remove the loopback handling from virtio_transport, because now the vsock core is able to handle local communication using the new vsock_loopback device. Reviewed-by: Stefan Hajnoczi Signed-off-by: Stefano Garzarella --- net/vmw_vsock/virtio_transport.c | 61

[PATCH net-next v2 2/6] vsock: add VMADDR_CID_LOCAL definition

2019-12-10 Thread Stefano Garzarella
The VMADDR_CID_RESERVED (1) was used by VMCI, but now it is not used anymore, so we can reuse it for local communication (loopback) adding the new well-know CID: VMADDR_CID_LOCAL. Cc: Jorgen Hansen Reviewed-by: Stefan Hajnoczi Reviewed-by: Jorgen Hansen Signed-off-by: Stefano Garzarella ---

[PATCH net-next v2 1/6] vsock/virtio_transport_common: remove unused virtio header includes

2019-12-10 Thread Stefano Garzarella
We can remove virtio header includes, because virtio_transport_common doesn't use virtio API, but provides common functions to interface virtio/vhost transports with the af_vsock core, and to handle the protocol. Reviewed-by: Stefan Hajnoczi Signed-off-by: Stefano Garzarella ---

[PATCH net-next v2 0/6] vsock: add local transport support

2019-12-10 Thread Stefano Garzarella
v2: - style fixes [Dave] - removed RCU sync and changed 'the_vsock_loopback' in a global static variable [Stefan] - use G2H transport when local transport is not loaded and remote cid is VMADDR_CID_LOCAL [Stefan] - rebased on net-next v1: https://patchwork.kernel.org/cover/11251735/

[PATCH net-next v2 3/6] vsock: add local transport support in the vsock core

2019-12-10 Thread Stefano Garzarella
This patch allows to register a transport able to handle local communication (loopback). Reviewed-by: Stefan Hajnoczi Signed-off-by: Stefano Garzarella --- include/net/af_vsock.h | 2 ++ net/vmw_vsock/af_vsock.c | 17 - 2 files changed, 18 insertions(+), 1 deletion(-) diff

Re: [PATCH] drm/virtio: fix mmap page attributes

2019-12-10 Thread Thomas Zimmermann
Hi Am 10.12.19 um 09:57 schrieb Gerd Hoffmann: > virtio-gpu uses cached mappings. shmem helpers use writecombine though. > So roll our own mmap function, wrapping drm_gem_shmem_mmap(), to tweak > vm_page_prot accordingly. > > Reported-by: Gurchetan Singh > Signed-off-by: Gerd Hoffmann > --- >

[PATCH] drm/virtio: fix mmap page attributes

2019-12-10 Thread Gerd Hoffmann
virtio-gpu uses cached mappings. shmem helpers use writecombine though. So roll our own mmap function, wrapping drm_gem_shmem_mmap(), to tweak vm_page_prot accordingly. Reported-by: Gurchetan Singh Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_object.c | 18