Re: [PATCH] Allow RDTSC and RDTSCP from userspace

2020-04-24 Thread Dave Hansen
On 4/24/20 2:27 PM, Tom Lendacky wrote: > On 4/24/20 4:24 PM, Dave Hansen wrote: >> On 4/24/20 2:03 PM, Mike Stunes wrote: >>> I needed to allow RDTSC(P) from userspace and in early boot in order to >>> get userspace started properly. Patch below. >>> >>> --- >>> SEV-ES guests will need to execute

Re: [PATCH] Allow RDTSC and RDTSCP from userspace

2020-04-24 Thread Tom Lendacky
On 4/24/20 4:24 PM, Dave Hansen wrote: On 4/24/20 2:03 PM, Mike Stunes wrote: I needed to allow RDTSC(P) from userspace and in early boot in order to get userspace started properly. Patch below. --- SEV-ES guests will need to execute rdtsc and rdtscp from userspace and during early boot. Move

Re: [PATCH] Allow RDTSC and RDTSCP from userspace

2020-04-24 Thread Dave Hansen
On 4/24/20 2:03 PM, Mike Stunes wrote: > I needed to allow RDTSC(P) from userspace and in early boot in order to > get userspace started properly. Patch below. > > --- > SEV-ES guests will need to execute rdtsc and rdtscp from userspace and > during early boot. Move the rdtsc(p) #VC handler into

Re: [PATCH 59/59] drm/bochs: Remove explicit drm_connector_register

2020-04-24 Thread Sam Ravnborg
On Wed, Apr 15, 2020 at 09:40:34AM +0200, Daniel Vetter wrote: > This is leftovers from the old drm_driver->load callback > upside-down issues. It doesn't do anything for not-hotplugged > connectors since drm_dev_register takes care of that. > > Signed-off-by: Daniel Vetter > Cc: Gerd Hoffmann

Re: [PATCH 37/59] drm/cirrus: Move to drm/tiny

2020-04-24 Thread Sam Ravnborg
On Wed, Apr 15, 2020 at 09:40:12AM +0200, Daniel Vetter wrote: > Because it is. Huge congrats to everyone who made this kind of > refactoring happen! > > Signed-off-by: Daniel Vetter > Cc: Dave Airlie > Cc: Gerd Hoffmann > Cc: virtualization@lists.linux-foundation.org Acked-by: Sam Ravnborg >

[PATCH v2] virtio-balloon: Disable free page reporting if page poison reporting is not enabled

2020-04-24 Thread Alexander Duyck
From: Alexander Duyck We should disable free page reporting if page poisoning is enabled in the kernel but we cannot report it via the balloon interface. This way we can avoid the possibility of corrupting guest memory. Normally the page poison reporting feature should always be present when

Re: [PATCH 27/59] drm/qxl: Don't use drm_device->dev_private

2020-04-24 Thread Sam Ravnborg
On Wed, Apr 15, 2020 at 09:40:02AM +0200, Daniel Vetter wrote: > Upcasting using a container_of macro is more typesafe, faster and > easier for the compiler to optimize. > > Acked-by: Gerd Hoffmann > Signed-off-by: Daniel Vetter > Cc: Dave Airlie > Cc: Gerd Hoffmann > Cc:

[PATCH net v2 0/2] vsock/virtio: fixes about packet delivery to monitoring devices

2020-04-24 Thread Stefano Garzarella
During the review of v1, Stefan pointed out an issue introduced by that patch, where replies can appear in the packet capture before the transmitted packet. While fixing my patch, reverting it and adding a new flag in 'struct virtio_vsock_pkt' (patch 2/2), I found that we already had that issue

[PATCH net v2 2/2] vsock/virtio: fix multiple packet delivery to monitoring devices

2020-04-24 Thread Stefano Garzarella
In virtio_transport.c, if the virtqueue is full, the transmitting packet is queued up and it will be sent in the next iteration. This causes the same packet to be delivered multiple times to monitoring devices. We want to continue to deliver packets to monitoring devices before it is put in the

Re: [PATCH 26/59] drm/qxl: Use devm_drm_dev_alloc

2020-04-24 Thread Sam Ravnborg
Hi Daniel On Wed, Apr 15, 2020 at 09:40:01AM +0200, Daniel Vetter wrote: > Also need to remove the drm_dev_put from the remove hook. > > Acked-by: Gerd Hoffmann > Signed-off-by: Daniel Vetter > Cc: Dave Airlie > Cc: Gerd Hoffmann > Cc: virtualization@lists.linux-foundation.org > Cc:

[PATCH net v2 1/2] vhost/vsock: fix packet delivery order to monitoring devices

2020-04-24 Thread Stefano Garzarella
We want to deliver packets to monitoring devices before it is put in the virtqueue, to avoid that replies can appear in the packet capture before the transmitted packet. Signed-off-by: Stefano Garzarella --- drivers/vhost/vsock.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)

Re: [PATCH] virtio-blk: handle block_device_operations callbacks after hot unplug

2020-04-24 Thread Stefan Hajnoczi
On Thu, Apr 23, 2020 at 07:13:38AM -0700, Christoph Hellwig wrote: > On Thu, Apr 23, 2020 at 01:37:17PM +0100, Stefan Hajnoczi wrote: > > A virtio_blk block device can still be referenced after hot unplug by > > userspace processes that hold the file descriptor. In this case > > virtblk_getgeo()

Re: [PATCH net] vsock/virtio: postpone packet delivery to monitoring devices

2020-04-24 Thread Stefano Garzarella
On Wed, Apr 22, 2020 at 05:54:20PM +0100, Stefan Hajnoczi wrote: > On Tue, Apr 21, 2020 at 06:17:24PM +0200, Stefano Garzarella wrote: > > On Tue, Apr 21, 2020 at 04:42:46PM +0100, Stefan Hajnoczi wrote: > > > On Tue, Apr 21, 2020 at 11:25:27AM +0200, Stefano Garzarella wrote: > > > > We

Re: [PATCH Resend] drm/qxl: Use correct notify port address when creating cursor ring

2020-04-24 Thread Gerd Hoffmann
On Fri, Apr 24, 2020 at 05:57:37PM +0800, Huacai Chen wrote: > Hi, Gerd > > On Tue, Mar 31, 2020 at 10:53 PM Gerd Hoffmann wrote: > > > > On Tue, Mar 31, 2020 at 02:18:08PM +0800, Huacai Chen wrote: > > > The command ring and cursor ring use different notify port addresses > > > definition:

Re: [PATCH Resend] drm/qxl: Use correct notify port address when creating cursor ring

2020-04-24 Thread Huacai Chen
Hi, Gerd On Tue, Mar 31, 2020 at 10:53 PM Gerd Hoffmann wrote: > > On Tue, Mar 31, 2020 at 02:18:08PM +0800, Huacai Chen wrote: > > The command ring and cursor ring use different notify port addresses > > definition: QXL_IO_NOTIFY_CMD and QXL_IO_NOTIFY_CURSOR. However, in > > qxl_device_init()

Re: [PATCH] virtio-blk: handle block_device_operations callbacks after hot unplug

2020-04-24 Thread Stefano Garzarella
On Thu, Apr 23, 2020 at 01:37:17PM +0100, Stefan Hajnoczi wrote: > A virtio_blk block device can still be referenced after hot unplug by > userspace processes that hold the file descriptor. In this case > virtblk_getgeo() can be invoked after virtblk_remove() was called. For > example, a program