Re: [PATCH V3 0/2] remove unused argument from blk_execute_rq_nowait and blk_execute_rq

2021-01-24 Thread Jens Axboe
On 1/24/21 9:49 PM, Guoqing Jiang wrote: > V3 changes: > 1. rebase with for-5.12/block branch. > 2. add Ulf's Acked-by. > > V2 changes: > 1. update commit header per Christoph's comment. > > Hi Jens, > > This series remove unused 'q' from blk_execute_rq_nowait and blk_execute_rq. > Also update

[PATCH V3 2/2] block: remove unnecessary argument from blk_execute_rq

2021-01-24 Thread Guoqing Jiang
We can remove 'q' from blk_execute_rq as well after the previous change in blk_execute_rq_nowait. And more importantly it never really was needed to start with given that we can trivial derive it from struct request. Cc: linux-s...@vger.kernel.org Cc: virtualization@lists.linux-foundation.org

[PATCH V3 0/2] remove unused argument from blk_execute_rq_nowait and blk_execute_rq

2021-01-24 Thread Guoqing Jiang
V3 changes: 1. rebase with for-5.12/block branch. 2. add Ulf's Acked-by. V2 changes: 1. update commit header per Christoph's comment. Hi Jens, This series remove unused 'q' from blk_execute_rq_nowait and blk_execute_rq. Also update the comment for blk_execute_rq_nowait. Thanks, Guoqing

[PATCH V3 1/2] block: remove unnecessary argument from blk_execute_rq_nowait

2021-01-24 Thread Guoqing Jiang
The 'q' is not used since commit a1ce35fa4985 ("block: remove dead elevator code"), also update the comment of the function. And more importantly it never really was needed to start with given that we can trivial derive it from struct request. Cc: target-de...@vger.kernel.org Cc:

Re: [PATCH V2 2/2] block: remove unnecessary argument from blk_execute_rq

2021-01-24 Thread Guoqing Jiang
On 1/22/21 10:50, Ulf Hansson wrote: On Fri, 22 Jan 2021 at 10:28, Guoqing Jiang wrote: We can remove 'q' from blk_execute_rq as well after the previous change in blk_execute_rq_nowait. And more importantly it never really was needed to start with given that we can trivial derive it from

Re: [PATCH V2 0/2] remove unused argument from blk_execute_rq_nowait and blk_execute_rq

2021-01-24 Thread Guoqing Jiang
On 1/25/21 02:24, Jens Axboe wrote: On 1/22/21 2:28 AM, Guoqing Jiang wrote: V2 changes: 1. update commit header per Christoph's comment. Hi Jens, This series remove unused 'q' from blk_execute_rq_nowait and blk_execute_rq. Also update the comment for blk_execute_rq_nowait. What's this

Re: [PATCH 21/21] vdpasim: control virtqueue support

2021-01-24 Thread Jason Wang
On 2021/1/23 上午3:43, Eugenio Perez Martin wrote: On Tue, Jan 12, 2021 at 4:12 AM Jason Wang wrote: On 2021/1/11 下午8:26, Eli Cohen wrote: On Wed, Dec 16, 2020 at 02:48:18PM +0800, Jason Wang wrote: This patch introduces the control virtqueue support for vDPA simulator. This is a requirement

Re: [PATCH v2 1/1] vhost scsi: alloc vhost_scsi with kvzalloc() to avoid delay

2021-01-24 Thread Jason Wang
On 2021/1/23 下午4:08, Dongli Zhang wrote: The size of 'struct vhost_scsi' is order-10 (~2.3MB). It may take long time delay by kzalloc() to compact memory pages by retrying multiple times when there is a lack of high-order pages. As a result, there is latency to create a VM (with vhost-scsi) or

Re: [PATCH V2 0/2] remove unused argument from blk_execute_rq_nowait and blk_execute_rq

2021-01-24 Thread Jens Axboe
On 1/22/21 2:28 AM, Guoqing Jiang wrote: > V2 changes: > 1. update commit header per Christoph's comment. > > Hi Jens, > > This series remove unused 'q' from blk_execute_rq_nowait and blk_execute_rq. > Also update the comment for blk_execute_rq_nowait. What's this against? The lightnvm patch

[PATCH v2 9/9] ALSA: virtio: introduce device suspend/resume support

2021-01-24 Thread Anton Yakovlev
All running PCM substreams are stopped on device suspend and restarted on device resume. Signed-off-by: Anton Yakovlev --- sound/virtio/virtio_card.c| 54 sound/virtio/virtio_pcm.c | 40 +++ sound/virtio/virtio_pcm.h | 6 +++

[PATCH v2 8/9] ALSA: virtio: introduce PCM channel map support

2021-01-24 Thread Anton Yakovlev
Enumerate all available PCM channel maps and create ALSA controls. Signed-off-by: Anton Yakovlev --- sound/virtio/Makefile | 1 + sound/virtio/virtio_card.c | 15 +++ sound/virtio/virtio_card.h | 8 ++ sound/virtio/virtio_chmap.c | 237

[PATCH v2 7/9] ALSA: virtio: introduce jack support

2021-01-24 Thread Anton Yakovlev
Enumerate all available jacks and create ALSA controls. At the moment jacks have a simple implementation and can only be used to receive notifications about a plugged in/out device. Signed-off-by: Anton Yakovlev --- sound/virtio/Makefile | 1 + sound/virtio/virtio_card.c | 18 +++

[PATCH v2 6/9] ALSA: virtio: PCM substream operators

2021-01-24 Thread Anton Yakovlev
Introduce the operators required for the operation of substreams. Signed-off-by: Anton Yakovlev --- sound/virtio/Makefile | 3 +- sound/virtio/virtio_pcm.c | 5 +- sound/virtio/virtio_pcm.h | 2 + sound/virtio/virtio_pcm_ops.c | 513 ++ 4

[PATCH v2 5/9] ALSA: virtio: handling control and I/O messages for the PCM device

2021-01-24 Thread Anton Yakovlev
The driver implements a message-based transport for I/O substream operations. Before the start of the substream, the hardware buffer is sliced into I/O messages, the number of which is equal to the current number of periods. The size of each message is equal to the current size of one period. I/O

[PATCH v2 4/9] ALSA: virtio: build PCM devices and substream hardware descriptors

2021-01-24 Thread Anton Yakovlev
Like the HDA specification, the virtio sound device specification links PCM substreams, jacks and PCM channel maps into functional groups. For each discovered group, a PCM device is created, the number of which coincides with the group number. Introduce the module parameters for setting the

[PATCH v2 3/9] ALSA: virtio: handling control messages

2021-01-24 Thread Anton Yakovlev
The control queue can be used by different parts of the driver to send commands to the device. Control messages can be either synchronous or asynchronous. The lifetime of a message is controlled by a reference count. Introduce a module parameter to set the message completion timeout:

[PATCH v2 2/9] ALSA: virtio: add virtio sound driver

2021-01-24 Thread Anton Yakovlev
Introduce skeleton of the virtio sound driver. The driver implements the virtio sound device specification, which has become part of the virtio standard. Initial initialization of the device, virtqueues and creation of an empty ALSA sound device. Also, handling DEVICE_NEEDS_RESET device status.

[PATCH v2 1/9] uapi: virtio_ids: add a sound device type ID from OASIS spec

2021-01-24 Thread Anton Yakovlev
The OASIS virtio spec defines a sound device type ID that is not present in the header yet. Signed-off-by: Anton Yakovlev --- include/uapi/linux/virtio_ids.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/virtio_ids.h b/include/uapi/linux/virtio_ids.h index

[PATCH v2 0/9] ALSA: add virtio sound driver

2021-01-24 Thread Anton Yakovlev
This series implements a driver part of the virtio sound device specification v8 [1]. The driver supports PCM playback and capture substreams, jack and channel map controls. A message-based transport is used to write/read PCM frames to/from a device. The series is based (and was actually tested)

Re: [PATCH 0/7] ALSA: add virtio sound driver

2021-01-24 Thread Anton Yakovlev
Hi, Liam! On 20.01.2021 11:10, Girdwood, Liam R wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. Hi Anton, On Wed, 2021-01-20 at 01:36 +0100, Anton Yakovlev wrote:

Re: [PATCH 5/7] ALSA: virtio: PCM substream operators

2021-01-24 Thread Anton Yakovlev
On 20.01.2021 09:36, Michael S. Tsirkin wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. On Wed, Jan 20, 2021 at 01:36:33AM +0100, Anton Yakovlev wrote: Introduce the

Re: [PATCH 4/7] ALSA: virtio: handling control and I/O messages for the PCM device

2021-01-24 Thread Anton Yakovlev
On 20.01.2021 09:29, Michael S. Tsirkin wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. On Wed, Jan 20, 2021 at 01:36:32AM +0100, Anton Yakovlev wrote: The driver

Re: [PATCH 3/7] ALSA: virtio: add virtio sound driver

2021-01-24 Thread Anton Yakovlev
On 20.01.2021 09:26, Michael S. Tsirkin wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. On Wed, Jan 20, 2021 at 01:36:31AM +0100, Anton Yakovlev wrote: Introduce

Re: [PATCH 2/7] uapi: virtio_snd: add the sound device header file

2021-01-24 Thread Anton Yakovlev
Hello, Michael. Thanks you for your comments! On 20.01.2021 09:19, Michael S. Tsirkin wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. On Wed, Jan 20, 2021 at

RE: [PATCH v4 07/15] x86/paravirt: switch time pvops functions to use static_call()

2021-01-24 Thread Michael Kelley via Virtualization
From: Juergen Gross Sent: Wednesday, January 20, 2021 5:56 AM > > The time pvops functions are the only ones left which might be > used in 32-bit mode and which return a 64-bit value. > > Switch them to use the static_call() mechanism instead of pvops, as > this allows quite some simplification

Re: [RFC PATCH 3/7] tun: allow use of BPF_PROG_TYPE_SCHED_CLS program type

2021-01-24 Thread Yuri Benditovich
On Wed, Jan 20, 2021 at 8:45 PM Alexei Starovoitov wrote: > > On Tue, Jan 12, 2021 at 12:55 PM Yuri Benditovich > wrote: > > > > On Tue, Jan 12, 2021 at 10:40 PM Yuri Benditovich > > wrote: > > > > > > On Tue, Jan 12, 2021 at 9:42 PM Yuri Benditovich > > > wrote: > > > > > > > > This program