Re: [PATCH v2 7/9] ALSA: virtio: introduce jack support

2021-01-25 Thread Guennadi Liakhovetski
On Sun, 24 Jan 2021, Anton Yakovlev wrote: Enumerate all available jacks and create ALSA controls. At the moment jacks have a simple implementation and can only be used to receive notifications about a plugged in/out device. Signed-off-by: Anton Yakovlev --- sound/virtio/Makefile |

Re: [PATCH v2 6/9] ALSA: virtio: PCM substream operators

2021-01-25 Thread Guennadi Liakhovetski
One more thing I missed yesterday: On Mon, 25 Jan 2021, Guennadi Liakhovetski wrote: On Sun, 24 Jan 2021, Anton Yakovlev wrote: Introduce the operators required for the operation of substreams. Signed-off-by: Anton Yakovlev --- sound/virtio/Makefile | 3 +-

Re: [PATCH iproute2-next 2/2] vdpa: Add vdpa tool

2021-01-25 Thread David Ahern
Looks fine. A few comments below around code re-use. On 1/22/21 4:26 AM, Parav Pandit wrote: > diff --git a/vdpa/vdpa.c b/vdpa/vdpa.c > new file mode 100644 > index ..942524b7 > --- /dev/null > +++ b/vdpa/vdpa.c > @@ -0,0 +1,828 @@ > +// SPDX-License-Identifier: GPL-2.0+ > + > +#include

RE: [PATCH v5 12/16] asm-generic/hyperv: update hv_interrupt_entry

2021-01-25 Thread Michael Kelley via Virtualization
From: Wei Liu Sent: Wednesday, January 20, 2021 4:01 AM > > We will soon use the same structure to handle IO-APIC interrupts as > well. Introduce an enum to identify the source and a data structure for > IO-APIC RTE. > > While at it, update pci-hyperv.c to use the enum. > > No functional

RE: [PATCH v5 09/16] x86/hyperv: provide a bunch of helper functions

2021-01-25 Thread Michael Kelley via Virtualization
From: Wei Liu Sent: Wednesday, January 20, 2021 4:01 AM > > They are used to deposit pages into Microsoft Hypervisor and bring up > logical and virtual processors. > > Signed-off-by: Lillian Grassin-Drake > Signed-off-by: Sunil Muthuswamy > Signed-off-by: Nuno Das Neves > Co-Developed-by:

RE: [PATCH v5 10/16] x86/hyperv: implement and use hv_smp_prepare_cpus

2021-01-25 Thread Michael Kelley via Virtualization
From: Wei Liu Sent: Wednesday, January 20, 2021 4:01 AM > > Microsoft Hypervisor requires the root partition to make a few > hypercalls to setup application processors before they can be used. > > Signed-off-by: Lillian Grassin-Drake > Signed-off-by: Sunil Muthuswamy > Co-Developed-by:

RE: [PATCH v5 11/16] asm-generic/hyperv: update hv_msi_entry

2021-01-25 Thread Michael Kelley via Virtualization
From: Wei Liu Sent: Wednesday, January 20, 2021 4:01 AM > > We will soon need to access fields inside the MSI address and MSI data > fields. Introduce hv_msi_address_register and hv_msi_data_register. > > Fix up one user of hv_msi_entry in mshyperv.h. > > No functional change expected. > >

RE: [PATCH v5 06/16] x86/hyperv: allocate output arg pages if required

2021-01-25 Thread Michael Kelley via Virtualization
From: Wei Liu Sent: Wednesday, January 20, 2021 4:01 AM > > When Linux runs as the root partition, it will need to make hypercalls > which return data from the hypervisor. > > Allocate pages for storing results when Linux runs as the root > partition. > > Signed-off-by: Lillian Grassin-Drake

RE: [PATCH v5 14/16] asm-generic/hyperv: import data structures for mapping device interrupts

2021-01-25 Thread Michael Kelley via Virtualization
From: Wei Liu Sent: Wednesday, January 20, 2021 4:01 AM > > Signed-off-by: Sunil Muthuswamy > Co-Developed-by: Sunil Muthuswamy > Signed-off-by: Wei Liu > --- > arch/x86/include/asm/hyperv-tlfs.h | 13 +++ > include/asm-generic/hyperv-tlfs.h | 36 ++ > 2

RE: [PATCH v5 13/16] asm-generic/hyperv: introduce hv_device_id and auxiliary structures

2021-01-25 Thread Michael Kelley via Virtualization
From: Wei Liu Sent: Wednesday, January 20, 2021 4:01 AM > > We will need to identify the device we want Microsoft Hypervisor to > manipulate. Introduce the data structures for that purpose. > > They will be used in a later patch. > > Signed-off-by: Sunil Muthuswamy > Co-Developed-by: Sunil

RE: [PATCH v5 08/16] x86/hyperv: handling hypercall page setup for root

2021-01-25 Thread Michael Kelley via Virtualization
From: Wei Liu Sent: Wednesday, January 20, 2021 4:01 AM > > When Linux is running as the root partition, the hypercall page will > have already been setup by Hyper-V. Copy the content over to the > allocated page. > > Add checks to hv_suspend & co to bail early because they are not > supported

RE: [PATCH v5 07/16] x86/hyperv: extract partition ID from Microsoft Hypervisor if necessary

2021-01-25 Thread Michael Kelley via Virtualization
From: Wei Liu Sent: Wednesday, January 20, 2021 4:01 AM > > We will need the partition ID for executing some hypercalls later. > > Signed-off-by: Lillian Grassin-Drake > Co-Developed-by: Sunil Muthuswamy > Signed-off-by: Wei Liu > --- > v3: > 1. Make hv_get_partition_id static. > 2. Change

RE: [PATCH v5 01/16] asm-generic/hyperv: change HV_CPU_POWER_MANAGEMENT to HV_CPU_MANAGEMENT

2021-01-25 Thread Michael Kelley via Virtualization
From: Wei Liu Sent: Wednesday, January 20, 2021 4:01 AM > > This makes the name match Hyper-V TLFS. > > Signed-off-by: Wei Liu > Reviewed-by: Vitaly Kuznetsov > --- > include/asm-generic/hyperv-tlfs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

RE: [PATCH v5 05/16] clocksource/hyperv: use MSR-based access if running as root

2021-01-25 Thread Michael Kelley via Virtualization
From: Wei Liu Sent: Wednesday, January 20, 2021 4:01 AM > > When Linux runs as the root partition, the setup required for TSC page > is different. Luckily Linux also has access to the MSR based > clocksource. We can just disable the TSC page clocksource if Linux is > the root partition. > >

RE: [PATCH v5 04/16] iommu/hyperv: don't setup IRQ remapping when running as root

2021-01-25 Thread Michael Kelley via Virtualization
From: Wei Liu Sent: Wednesday, January 20, 2021 4:01 AM > > The IOMMU code needs more work. We're sure for now the IRQ remapping > hooks are not applicable when Linux is the root partition. > > Signed-off-by: Wei Liu > Acked-by: Joerg Roedel > Reviewed-by: Vitaly Kuznetsov > --- >

RE: [PATCH v5 03/16] Drivers: hv: vmbus: skip VMBus initialization if Linux is root

2021-01-25 Thread Michael Kelley via Virtualization
From: Wei Liu Sent: Wednesday, January 20, 2021 4:01 AM > > There is no VMBus and the other infrastructures initialized in > hv_acpi_init when Linux is running as the root partition. > > Signed-off-by: Wei Liu > --- > v3: Return 0 instead of -ENODEV. > --- > drivers/hv/vmbus_drv.c | 3 +++ >

RE: [PATCH v5 02/16] x86/hyperv: detect if Linux is the root partition

2021-01-25 Thread Michael Kelley via Virtualization
From: Wei Liu Sent: Wednesday, January 20, 2021 4:01 AM > > For now we can use the privilege flag to check. Stash the value to be > used later. > > Put in a bunch of defines for future use when we want to have more > fine-grained detection. > > Signed-off-by: Wei Liu > --- > v3: move

Re: [PATCH v2 6/9] ALSA: virtio: PCM substream operators

2021-01-25 Thread Guennadi Liakhovetski
On Sun, 24 Jan 2021, Anton Yakovlev wrote: Introduce the operators required for the operation of substreams. Signed-off-by: Anton Yakovlev --- sound/virtio/Makefile | 3 +- sound/virtio/virtio_pcm.c | 5 +- sound/virtio/virtio_pcm.h | 2 + sound/virtio/virtio_pcm_ops.c |

Re: [PATCH v2 5/9] ALSA: virtio: handling control and I/O messages for the PCM device

2021-01-25 Thread Guennadi Liakhovetski
On Sun, 24 Jan 2021, Anton Yakovlev wrote: The driver implements a message-based transport for I/O substream operations. Before the start of the substream, the hardware buffer is sliced into I/O messages, the number of which is equal to the current number of periods. The size of each message

Re: [PATCH v2 4/9] ALSA: virtio: build PCM devices and substream hardware descriptors

2021-01-25 Thread Guennadi Liakhovetski
On Sun, 24 Jan 2021, Anton Yakovlev wrote: Like the HDA specification, the virtio sound device specification links PCM substreams, jacks and PCM channel maps into functional groups. For each discovered group, a PCM device is created, the number of which coincides with the group number.

Re: [PATCH v2 3/9] ALSA: virtio: handling control messages

2021-01-25 Thread Guennadi Liakhovetski
I think the use of (devm_)kmalloc() and friends needs some refinement in several patches in the series. On Sun, 24 Jan 2021, Anton Yakovlev wrote: The control queue can be used by different parts of the driver to send commands to the device. Control messages can be either synchronous or

Re: [PATCH v2 2/9] ALSA: virtio: add virtio sound driver

2021-01-25 Thread Guennadi Liakhovetski
Hi Anton, A couple of mostly cosmetic comments inline. On Sun, 24 Jan 2021, Anton Yakovlev wrote: Introduce skeleton of the virtio sound driver. The driver implements the virtio sound device specification, which has become part of the virtio standard. Initial initialization of the device,

Re: [PATCH v3 2/4] drm/qxl: unpin release objects

2021-01-25 Thread Gerd Hoffmann
> > Just calling ttm_bo_unpin() here makes lockdep unhappy. > > How does that one splat? But yeah if that's a problem should be > explained in the comment. I'd then also only do a pin_count--; to make > sure you can still catch other pin leaks if you have them. Setting it > to 0 kinda defeats the

Re: [PATCH][next] vpda: Fix memory leaks of msg on error return paths

2021-01-25 Thread Stefano Garzarella
On Fri, Jan 22, 2021 at 02:52:35PM +, Colin King wrote: From: Colin Ian King There are two error return paths that neglect to free the allocated object msg that lead to memory leaks. Fix this by adding an error exit path that frees msg. Addresses-Coverity: ("Resource leak") Fixes:

Re: [PATCH RFC v1 00/15] iommu/virtio: Nested stage support with Arm

2021-01-25 Thread Auger Eric
Hi Vivek, On 1/21/21 6:34 PM, Vivek Kumar Gautam wrote: > Hi Eric, > > > On 1/19/21 2:33 PM, Auger Eric wrote: >> Hi Vivek, >> >> On 1/15/21 1:13 PM, Vivek Gautam wrote: >>> This patch-series aims at enabling Nested stage translation in guests >>> using virtio-iommu as the paravirtualized