Re: [PATCH v2 04/10] drm/aperture: Add infrastructure for aperture ownership

2021-04-14 Thread Thomas Zimmermann
Hi Am 09.04.21 um 11:22 schrieb Daniel Vetter: Is it that easy? simepldrm's detach function has code to synchronize with concurrent hotplug removals. If we can use drm_dev_unplug() for everything, I'm all for it. Uh, I should have looked at the code instead of just asking silly questions :-)

Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver

2021-04-14 Thread Jie Deng
On 2021/4/15 14:45, Viresh Kumar wrote: On 23-03-21, 10:27, Arnd Bergmann wrote: I usually recommend the use of __maybe_unused for the suspend/resume callbacks for drivers that use SIMPLE_DEV_PM_OPS() or similar helpers that hide the exact conditions under which the functions get called. In t

Re: [PATCH 2/3] vDPA/ifcvf: enable Intel C5000X-PL virtio-block for vDPA

2021-04-14 Thread Zhu Lingshan
On 4/15/2021 2:31 PM, Jason Wang wrote: 在 2021/4/15 下午1:55, Zhu Lingshan 写道: On 4/15/2021 11:34 AM, Jason Wang wrote: 在 2021/4/14 下午5:18, Zhu Lingshan 写道: This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-block for vDPA. Signed-off-by: Zhu Lingshan ---   drivers/vdpa/ifcvf/ifcvf

Re: [PATCH 1/3] vDPA/ifcvf: deduce VIRTIO device ID when probe

2021-04-14 Thread Zhu Lingshan
On 4/15/2021 2:30 PM, Jason Wang wrote: 在 2021/4/15 下午1:52, Zhu Lingshan 写道: On 4/15/2021 11:30 AM, Jason Wang wrote: 在 2021/4/14 下午5:18, Zhu Lingshan 写道: This commit deduces VIRTIO device ID as device type when probe, then ifcvf_vdpa_get_device_id() can simply return the ID. ifcvf_vdpa_

Re: [PATCH 2/3] vDPA/ifcvf: enable Intel C5000X-PL virtio-block for vDPA

2021-04-14 Thread Jason Wang
在 2021/4/15 下午1:55, Zhu Lingshan 写道: On 4/15/2021 11:34 AM, Jason Wang wrote: 在 2021/4/14 下午5:18, Zhu Lingshan 写道: This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-block for vDPA. Signed-off-by: Zhu Lingshan ---   drivers/vdpa/ifcvf/ifcvf_base.h | 17 -   drivers/vd

Re: [PATCH 1/3] vDPA/ifcvf: deduce VIRTIO device ID when probe

2021-04-14 Thread Jason Wang
在 2021/4/15 下午1:52, Zhu Lingshan 写道: On 4/15/2021 11:30 AM, Jason Wang wrote: 在 2021/4/14 下午5:18, Zhu Lingshan 写道: This commit deduces VIRTIO device ID as device type when probe, then ifcvf_vdpa_get_device_id() can simply return the ID. ifcvf_vdpa_get_features() and ifcvf_vdpa_get_config_si

Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver

2021-04-14 Thread Jie Deng
On 2021/4/14 11:52, Viresh Kumar wrote: Is i2c/for-next the right tree to merge it ? It should be. Thanks Viresh. Hi Wolfram, Do you have any comments for this patch ? Your opinion will be important to improve this patch since you are the maintainer of I2C. Thanks, Jie ___

Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver

2021-04-14 Thread Jie Deng
On 2021/4/15 11:51, Jason Wang wrote: +    for (i = 0; i < nr; i++) { +    /* Detach the ith request from the vq */ +    req = virtqueue_get_buf(vq, &len); + +    /* + * Condition (req && req == &reqs[i]) should always meet since + * we have total nr requests in the

Re: [PATCH 2/3] vDPA/ifcvf: enable Intel C5000X-PL virtio-block for vDPA

2021-04-14 Thread Zhu Lingshan
On 4/15/2021 11:34 AM, Jason Wang wrote: 在 2021/4/14 下午5:18, Zhu Lingshan 写道: This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-block for vDPA. Signed-off-by: Zhu Lingshan ---   drivers/vdpa/ifcvf/ifcvf_base.h | 17 -   drivers/vdpa/ifcvf/ifcvf_main.c | 10 +-  

Re: [PATCH 1/3] vDPA/ifcvf: deduce VIRTIO device ID when probe

2021-04-14 Thread Zhu Lingshan
On 4/15/2021 11:30 AM, Jason Wang wrote: 在 2021/4/14 下午5:18, Zhu Lingshan 写道: This commit deduces VIRTIO device ID as device type when probe, then ifcvf_vdpa_get_device_id() can simply return the ID. ifcvf_vdpa_get_features() and ifcvf_vdpa_get_config_size() can work properly based on the dev

[PATCH] sound: virtio: correct the function name in kernel-doc comment

2021-04-14 Thread Randy Dunlap
: "Michael S. Tsirkin" Cc: virtualization@lists.linux-foundation.org Cc: alsa-de...@alsa-project.org --- sound/virtio/virtio_ctl_msg.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20210414.orig/sound/virtio/virtio_ctl_msg.c +++ linux-next-20210414/sound/virtio/virtio

Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver

2021-04-14 Thread Jason Wang
在 2021/3/23 下午10:19, Jie Deng 写道: Add an I2C bus driver for virtio para-virtualization. The controller can be emulated by the backend driver in any device model software by following the virtio protocol. The device specification can be found on https://lists.oasis-open.org/archives/virtio-comm

Re: [PATCH 3/3] vDPA/ifcvf: get_config_size should return dev specific config size

2021-04-14 Thread Jason Wang
在 2021/4/14 下午5:18, Zhu Lingshan 写道: get_config_size() should return the size based on the decected device type. Signed-off-by: Zhu Lingshan Acked-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_main.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/driver

Re: [PATCH 2/3] vDPA/ifcvf: enable Intel C5000X-PL virtio-block for vDPA

2021-04-14 Thread Jason Wang
在 2021/4/14 下午5:18, Zhu Lingshan 写道: This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-block for vDPA. Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_base.h | 17 - drivers/vdpa/ifcvf/ifcvf_main.c | 10 +- 2 files changed, 25 insertions(+), 2 deleti

Re: [PATCH 1/3] vDPA/ifcvf: deduce VIRTIO device ID when probe

2021-04-14 Thread Jason Wang
在 2021/4/14 下午5:18, Zhu Lingshan 写道: This commit deduces VIRTIO device ID as device type when probe, then ifcvf_vdpa_get_device_id() can simply return the ID. ifcvf_vdpa_get_features() and ifcvf_vdpa_get_config_size() can work properly based on the device ID. Signed-off-by: Zhu Lingshan ---

Re: Re: [RFC v2] virtio-vsock: add description for datagram type

2021-04-14 Thread Jiang Wang .
On Wed, Apr 14, 2021 at 2:38 AM Stefano Garzarella wrote: > > On Wed, Apr 14, 2021 at 03:20:07AM -0400, Michael S. Tsirkin wrote: > >On Wed, Apr 14, 2021 at 08:57:06AM +0200, Stefano Garzarella wrote: > >> On Tue, Apr 13, 2021 at 03:58:34PM -0400, Michael S. Tsirkin wrote: > >> > On Tue, Apr 13, 2

Re: [PATCH v6 10/10] Documentation: Add documentation for VDUSE

2021-04-14 Thread Stefan Hajnoczi
On Wed, Mar 31, 2021 at 04:05:19PM +0800, Xie Yongji wrote: > VDUSE (vDPA Device in Userspace) is a framework to support > implementing software-emulated vDPA devices in userspace. This > document is intended to clarify the VDUSE design and usage. > > Signed-off-by: Xie Yongji > --- > Documentat

Re: [RFC v2] virtio-vsock: add description for datagram type

2021-04-14 Thread Stefano Garzarella
On Wed, Apr 14, 2021 at 03:20:07AM -0400, Michael S. Tsirkin wrote: On Wed, Apr 14, 2021 at 08:57:06AM +0200, Stefano Garzarella wrote: On Tue, Apr 13, 2021 at 03:58:34PM -0400, Michael S. Tsirkin wrote: > On Tue, Apr 13, 2021 at 04:03:51PM +0200, Stefano Garzarella wrote: > > On Tue, Apr 13, 20

Re: [PATCH net-next v2] virtio-net: page_to_skb() use build_skb when there's sufficient tailroom

2021-04-14 Thread Jason Wang
在 2021/4/14 上午9:52, Xuan Zhuo 写道: In page_to_skb(), if we have enough tailroom to save skb_shared_info, we can use build_skb to create skb directly. No need to alloc for additional space. And it can save a 'frags slot', which is very friendly to GRO. Here, if the payload of the received package

Re: [PATCH] virtio_blk: Add support for lifetime feature

2021-04-14 Thread Stefan Hajnoczi
On Mon, Apr 12, 2021 at 10:42:17AM +0100, Christoph Hellwig wrote: > A note to the virtio committee: eMMC is the worst of all the currently > active storage standards by a large margin. It defines very strange > ad-hoc interfaces that expose very specific internals and often provides > very poor

Re: [PATCH] virtiofs: remove useless function

2021-04-14 Thread Stefan Hajnoczi
On Tue, Apr 13, 2021 at 05:22:23PM +0800, Jiapeng Chong wrote: > Fix the following clang warning: > > fs/fuse/virtio_fs.c:130:35: warning: unused function 'vq_to_fpq' > [-Wunused-function]. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > fs/fuse/virtio_fs.c | 5 - > 1 f

Re: [PATCH v6 09/10] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-04-14 Thread Jason Wang
在 2021/4/13 下午12:28, Yongji Xie 写道: On Tue, Apr 13, 2021 at 11:35 AM Jason Wang wrote: 在 2021/4/12 下午5:59, Yongji Xie 写道: On Mon, Apr 12, 2021 at 5:37 PM Jason Wang wrote: 在 2021/4/12 下午4:02, Yongji Xie 写道: On Mon, Apr 12, 2021 at 3:16 PM Jason Wang wrote: 在 2021/4/9 下午4:02, Yongji Xie

Re: [PATCH net-next v4 08/10] virtio-net: xsk zero copy xmit setup

2021-04-14 Thread Jason Wang
在 2021/4/14 下午3:36, Magnus Karlsson 写道: On Tue, Apr 13, 2021 at 9:58 AM Xuan Zhuo wrote: xsk is a high-performance packet receiving and sending technology. This patch implements the binding and unbinding operations of xsk and the virtio-net queue for xsk zero copy xmit. The xsk zero copy xmi

Re: [PATCH v6 00/10] Introduce VDUSE - vDPA Device in Userspace

2021-04-14 Thread Jason Wang
在 2021/4/14 下午3:34, Michael S. Tsirkin 写道: On Wed, Mar 31, 2021 at 04:05:09PM +0800, Xie Yongji wrote: This series introduces a framework, which can be used to implement vDPA Devices in a userspace program. The work consist of two parts: control path forwarding and data path offloading. In the

Re: [PATCH v6 00/10] Introduce VDUSE - vDPA Device in Userspace

2021-04-14 Thread Michael S. Tsirkin
On Wed, Mar 31, 2021 at 04:05:09PM +0800, Xie Yongji wrote: > This series introduces a framework, which can be used to implement > vDPA Devices in a userspace program. The work consist of two parts: > control path forwarding and data path offloading. > > In the control path, the VDUSE driver will

Re: [RFC v2] virtio-vsock: add description for datagram type

2021-04-14 Thread Michael S. Tsirkin
On Wed, Apr 14, 2021 at 08:57:06AM +0200, Stefano Garzarella wrote: > On Tue, Apr 13, 2021 at 03:58:34PM -0400, Michael S. Tsirkin wrote: > > On Tue, Apr 13, 2021 at 04:03:51PM +0200, Stefano Garzarella wrote: > > > On Tue, Apr 13, 2021 at 09:50:45AM -0400, Michael S. Tsirkin wrote: > > > > On Tue,

Re: [RFC v2] virtio-vsock: add description for datagram type

2021-04-14 Thread Stefano Garzarella
On Tue, Apr 13, 2021 at 03:00:50PM -0700, Jiang Wang . wrote: On Tue, Apr 13, 2021 at 12:58 PM Michael S. Tsirkin wrote: On Tue, Apr 13, 2021 at 04:03:51PM +0200, Stefano Garzarella wrote: > On Tue, Apr 13, 2021 at 09:50:45AM -0400, Michael S. Tsirkin wrote: > > On Tue, Apr 13, 2021 at 03:38:5