Re: [Patch v1 3/3] vdpa/mlx5: Add multiqueue support

On Thu, Aug 12, 2021 at 12:55 PM Eli Cohen wrote: > > On Thu, Aug 12, 2021 at 11:19:19AM +0800, Jason Wang wrote: > > > > 在 2021/8/11 下午7:04, Eli Cohen 写道: > > > On Wed, Aug 11, 2021 at 04:37:44PM +0800, Jason Wang wrote: > > > > 在 2021/8/11 下午3:53, Eli Cohen 写道: > > > > > > One thing need to solv

Re: [RFC PATCH] virtio-net: use NETIF_F_GRO_HW instead of NETIF_F_LRO

在 2021/8/12 下午12:50, Michael S. Tsirkin 写道: On Thu, Aug 12, 2021 at 11:23:04AM +0800, Jason Wang wrote: 在 2021/8/12 上午6:17, Jakub Kicinski 写道: On Wed, 11 Aug 2021 16:16:23 +0800 Jason Wang wrote: Try to fix this by using NETIF_F_GRO_HW instead so we're not guaranteed to be re-segmented as ori

[PATCH 1/2] fuse: disable atomic_o_trunc if no_open is enabled

From: Liu Bo When 'no_open' is used by virtiofsd, guest kernel won't send OPEN request any more. However, with atomic_o_trunc, SETATTR request is also omitted in OPEN(O_TRUNC) so that the backend file is not truncated. With a following GETATTR, inode size on guest side is updated to be same wit

[PATCH 2/2] virtiofs: reduce lock contention on fpq->lock

From: Liu Bo Since %req has been removed from fpq->processing_list, no one except request_wait_answer() is looking at this %req and request_wait_answer() waits only on FINISH flag, it's OK to remove fpq->lock after %req is dropped from the list. Signed-off-by: Liu Bo Signed-off-by: Jeffle Xu -

[PATCH 0/2] virtiofs: miscellaneous fixes

Some fixes or optimization for virtiofs, which are authored by Liu Bo. Liu Bo (2): virtio-fs: disable atomic_o_trunc if no_open is enabled virtiofs: reduce lock contention on fpq->lock fs/fuse/file.c | 11 +-- fs/fuse/virtio_fs.c | 3 --- 2 files changed, 9 insertions(+), 5 del

Re: [RFC PATCH] virtio-net: use NETIF_F_GRO_HW instead of NETIF_F_LRO

On Wed, Aug 11, 2021 at 08:20:03PM -0500, ivan wrote: > On Wed, Aug 11, 2021 at 3:16 AM Jason Wang wrote: > > > > Commit a02e8964eaf92 ("virtio-net: ethtool configurable LRO") tries to > > advertise LRO on behalf of the guest offloading features and allow the > > administrator to enable and disabl

Re: [RFC PATCH] virtio-net: use NETIF_F_GRO_HW instead of NETIF_F_LRO

On Thu, Aug 12, 2021 at 11:23:04AM +0800, Jason Wang wrote: > > 在 2021/8/12 上午6:17, Jakub Kicinski 写道: > > On Wed, 11 Aug 2021 16:16:23 +0800 Jason Wang wrote: > > > Try to fix this by using NETIF_F_GRO_HW instead so we're not > > > guaranteed to be re-segmented as original. > > This sentence may

Re: [RFC PATCH] virtio-net: use NETIF_F_GRO_HW instead of NETIF_F_LRO

在 2021/8/12 上午6:17, Jakub Kicinski 写道: On Wed, 11 Aug 2021 16:16:23 +0800 Jason Wang wrote: Try to fix this by using NETIF_F_GRO_HW instead so we're not guaranteed to be re-segmented as original. This sentence may need rephrasing. Right, actually, I meant: Try to fix this by using NETIF_F

Re: [Patch v1 3/3] vdpa/mlx5: Add multiqueue support

在 2021/8/11 下午7:04, Eli Cohen 写道: On Wed, Aug 11, 2021 at 04:37:44PM +0800, Jason Wang wrote: 在 2021/8/11 下午3:53, Eli Cohen 写道: One thing need to solve for mq is that the: +static u16 ctrl_vq_idx(struct mlx5_vdpa_dev *mvdev) +{ +     return 2 * mlx5_vdpa_max_qps(mvdev->max_vqs); +} We sh

Re: [PATCH v3 0/8] fuse,virtiofs: support per-file DAX

ping? Corresponding patches for virtiofsd are also included in this patch set. On 8/4/21 3:06 PM, Jeffle Xu wrote: > changes since v2: > - modify fuse_show_options() accordingly to make it compatible with > new tri-state mount option (patch 2) > - extract FUSE protocol changes into one seperate

Re: [PATCH v1 1/3] /dev/mem: disallow access to explicitly excluded system RAM regions

On Wednesday, August 11, 2021, David Hildenbrand wrote: > virtio-mem dynamically exposes memory inside a device memory region as > system RAM to Linux, coordinating with the hypervisor which parts are > actually "plugged" and consequently usable/accessible. On the one hand, the > virtio-mem drive

Re: [PATCH v1 3/3] kernel/resource: cleanup and optimize iomem_is_exclusive()

On Wednesday, August 11, 2021, David Hildenbrand wrote: > Let's clean it up a bit, removing the unnecessary usage of r_next() by > next_resource(), and use next_range_resource() in case we are not > interested in a certain subtree. > > Signed-off-by: David Hildenbrand > --- > kernel/resource.c

[PATCH v1 3/3] kernel/resource: cleanup and optimize iomem_is_exclusive()

Let's clean it up a bit, removing the unnecessary usage of r_next() by next_resource(), and use next_range_resource() in case we are not interested in a certain subtree. Signed-off-by: David Hildenbrand --- kernel/resource.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions

[PATCH v1 1/3] /dev/mem: disallow access to explicitly excluded system RAM regions

virtio-mem dynamically exposes memory inside a device memory region as system RAM to Linux, coordinating with the hypervisor which parts are actually "plugged" and consequently usable/accessible. On the one hand, the virtio-mem driver adds/removes whole memory blocks, creating/removing busy IORESOU

[PATCH v1 2/3] virtio-mem: disallow mapping virtio-mem memory via /dev/mem

By creating our parent IORESOURCE_SYSTEM_RAM resource with IORESOURCE_EXCLUSIVE, we will disallow any /dev/mem access to our device-managed region. Note that access to the region would still be possible if someone simply doesn't load the virtio-mem driver; however, there is no way of protecting ag

[PATCH v1 0/3] virtio-mem: disallow mapping virtio-mem memory via /dev/mem

Let's add the basic infrastructure to exclude some physical memory regions completely from /dev/mem access, on any architecture and under any system configuration (independent of CONFIG_STRICT_DEVMEM and independent of "iomem="). Use it for virtio-mem, to disallow mapping any virtio-mem memory via

Re: [bug report] vhost_net: basic polling support

On Wed, Aug 11, 2021 at 08:51:22PM +0800, Jason Wang wrote: > Hi Dan: > > On Wed, Aug 11, 2021 at 8:14 PM Dan Carpenter > wrote: > > > > Hello Jason Wang, > > > > The patch 030881372460: "vhost_net: basic polling support" from Mar > > 4, 2016, leads to the following > > Smatch static checker war

Re: [bug report] vhost_net: basic polling support

Hi Dan: On Wed, Aug 11, 2021 at 8:14 PM Dan Carpenter wrote: > > Hello Jason Wang, > > The patch 030881372460: "vhost_net: basic polling support" from Mar > 4, 2016, leads to the following > Smatch static checker warning: > > drivers/vhost/vhost.c:2565 vhost_new_msg() > warn: slee

Re: [PATCH V5 2/2] gpio: virtio: Add IRQ support

On Tue, Aug 10, 2021 at 12:25 PM Viresh Kumar wrote: > This patch adds IRQ support for the virtio GPIO driver. Note that this > uses the irq_bus_lock/unlock() callbacks, since those operations over > virtio may sleep. Also the notifications for the eventq are processed > using a work item to allo

Re: [PATCH V5 1/2] gpio: Add virtio-gpio driver

On Tue, Aug 10, 2021 at 12:25 PM Viresh Kumar wrote: > This patch adds a new driver for Virtio based GPIO devices. > > This allows a guest VM running Linux to access GPIO lines provided by > the host. It supports all basic operations, except interrupts for the > GPIO lines. > > Based on the initi

[bug report] vhost_net: basic polling support

Hello Jason Wang, The patch 030881372460: "vhost_net: basic polling support" from Mar 4, 2016, leads to the following Smatch static checker warning: drivers/vhost/vhost.c:2565 vhost_new_msg() warn: sleeping in atomic context vers/vhost/net.c 509 static void vhost_net_busy_pol

Re: [virtio-comment] [RFC PATCH v7 2/2] virtio-vsock: SOCK_SEQPACKET description

On Tue, Aug 10, 2021 at 02:47:06PM +0300, Arseny Krasnov wrote: This adds description of SOCK_SEQPACKET socket type support for virtio-vsock. Signed-off-by: Arseny Krasnov --- virtio-vsock.tex | 35 ++- 1 file changed, 30 insertions(+), 5 deletions(-) diff --git

Re: [virtio-comment] [RFC PATCH v7 1/2] virtio-vsock: use C style defines for constants

On Tue, Aug 10, 2021 at 02:46:49PM +0300, Arseny Krasnov wrote: This: 1) Replaces enums with C style "defines", because use of enums is not documented, while "defines" are widely used in spec. 2) Adds defines for some constants. Reviewed-by: Stefan Hajnoczi Signed-off-by: Arseny Krasnov --

Re: [RFC PATCH v2 5/5] vsock_test: update message bounds test for MSG_EOR

On Tue, Aug 10, 2021 at 02:41:16PM +0300, Arseny Krasnov wrote: Set 'MSG_EOR' in one of message sent, check that 'MSG_EOR' is visible in corresponding message at receiver. Signed-off-by: Arseny Krasnov --- tools/testing/vsock/vsock_test.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion

[virtiofsd PATCH v3 4/4] virtiofsd: support per-file DAX in FUSE_LOOKUP

For passthrough, when the corresponding virtiofs in guest is mounted with '-o dax=inode', advertise that the file is capable of per-file DAX if the inode in the backend fs is marked with FS_DAX_FL flag. Signed-off-by: Jeffle Xu --- Sorry I forget to add staged changes to the latest commit. Pleas

Re: [RFC PATCH v2 4/5] af_vsock: rename variables in receive loop

On Tue, Aug 10, 2021 at 02:41:00PM +0300, Arseny Krasnov wrote: Record is supported via MSG_EOR flag, while current logic operates with message, so rename variables from 'record' to 'message'. Signed-off-by: Arseny Krasnov --- net/vmw_vsock/af_vsock.c | 10 +- 1 file changed, 5 insertion

Re: [RFC PATCH v2 3/5] virito/vsock: support MSG_EOR bit processing

On Tue, Aug 10, 2021 at 02:40:32PM +0300, Arseny Krasnov wrote: If packet has 'EOR' bit - set MSG_EOR in 'recvmsg()' flags. Signed-off-by: Arseny Krasnov --- net/vmw_vsock/virtio_transport_common.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/net/vmw_vsock/virtio_t

Re: [RFC PATCH v2 2/5] vhost/vsock: support MSG_EOR bit processing

On Tue, Aug 10, 2021 at 02:40:15PM +0300, Arseny Krasnov wrote: It works in the same way as 'end-of-message' bit: if packet has 'EOM' bit, also check for 'EOR' bit. Please describe all changes, e.g. the new variable to accumulate flags to restore. Signed-off-by: Arseny Krasnov --- drivers

[WorldCIST'22]: Call for Workshops Proposals

- Call for Workshops Proposals WorldCist'22 - 10th World Conference on Information Systems and Technologies Budva, Montenegro, 12 - 14 April 2022 http://worldcist.org/ --

Re: [RFC PATCH v2 1/5] virtio/vsock: add 'VIRTIO_VSOCK_SEQ_EOM' bit

On Tue, Aug 10, 2021 at 02:39:53PM +0300, Arseny Krasnov wrote: The title is confusing, we are renaming EOR in EOM. This bit is used to mark end of messages('EOM' - end of message), while 'VIRIO_VSOCK_SEQ_EOR' is used to pass MSG_EOR. Also rename 'record' to 'message' in implementation as it is

Re: [Patch v1 3/3] vdpa/mlx5: Add multiqueue support

在 2021/8/11 下午3:53, Eli Cohen 写道: One thing need to solve for mq is that the: +static u16 ctrl_vq_idx(struct mlx5_vdpa_dev *mvdev) +{ +     return 2 * mlx5_vdpa_max_qps(mvdev->max_vqs); +} We should handle the case when MQ is supported by the device but not the driver. E.g in the case whe

Re: PROBLEM: virtio_net LRO kernel panics

在 2021/8/11 下午4:01, Michael S. Tsirkin 写道: On Wed, Aug 11, 2021 at 03:45:48PM +0800, Jason Wang wrote: 在 2021/8/11 下午3:39, Michael S. Tsirkin 写道: On Wed, Aug 11, 2021 at 11:38:59AM +0800, Jason Wang wrote: On Tue, Aug 10, 2021 at 11:31 PM Michael S. Tsirkin wrote: On Mon, Aug 02, 2021 at 04

[RFC PATCH] virtio-net: use NETIF_F_GRO_HW instead of NETIF_F_LRO

Commit a02e8964eaf92 ("virtio-net: ethtool configurable LRO") tries to advertise LRO on behalf of the guest offloading features and allow the administrator to enable and disable those features via ethtool. This may lead several issues: - For the device that doesn't support control guest offloads,

Re: PROBLEM: virtio_net LRO kernel panics

On Wed, Aug 11, 2021 at 03:45:48PM +0800, Jason Wang wrote: > > 在 2021/8/11 下午3:39, Michael S. Tsirkin 写道: > > On Wed, Aug 11, 2021 at 11:38:59AM +0800, Jason Wang wrote: > > > On Tue, Aug 10, 2021 at 11:31 PM Michael S. Tsirkin > > > wrote: > > > > On Mon, Aug 02, 2021 at 04:23:12PM -0500, Ivan

Re: PROBLEM: virtio_net LRO kernel panics

在 2021/8/11 下午3:39, Michael S. Tsirkin 写道: On Wed, Aug 11, 2021 at 11:38:59AM +0800, Jason Wang wrote: On Tue, Aug 10, 2021 at 11:31 PM Michael S. Tsirkin wrote: On Mon, Aug 02, 2021 at 04:23:12PM -0500, Ivan wrote: On Mon, Aug 2, 2021 at 2:52 PM Michael S. Tsirkin wrote: On Mon, Aug 02, 2

Re: PROBLEM: virtio_net LRO kernel panics

On Wed, Aug 11, 2021 at 11:38:59AM +0800, Jason Wang wrote: > On Tue, Aug 10, 2021 at 11:31 PM Michael S. Tsirkin wrote: > > > > On Mon, Aug 02, 2021 at 04:23:12PM -0500, Ivan wrote: > > > On Mon, Aug 2, 2021 at 2:52 PM Michael S. Tsirkin wrote: > > > > > > > > On Mon, Aug 02, 2021 at 01:32:05PM