Thanks!
Parav Pandit 于2021年10月26日周二 下午1:00写道：
>
> > From: leohou1402
> > Sent: Tuesday, October 26, 2021 10:28 AM
>
> > Which device does mlX5 refer to ? Connectx-4 or ConnectX-5 ?
> > I want to test it out.
> ConnectX-6 dx.
>
>
___
Virtualization
在 2021/10/22 下午1:19, Mike Christie 写道:
This patch allows userspace to create workers and bind them to vqs. You
can have N workers per dev and also share N workers with M vqs.
Signed-off-by: Mike Christie
A question, who is the best one to determine the binding? Is it the VMM
(Qemu etc) or
> From: leohou1402
> Sent: Tuesday, October 26, 2021 10:28 AM
> Which device does mlX5 refer to ? Connectx-4 or ConnectX-5 ?
> I want to test it out.
ConnectX-6 dx.
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
Which device does mlX5 refer to ? Connectx-4 or ConnectX-5 ?I want to test it out.Thanks.On 10/25/2021 20:54，Parav Pandit via Virtualization wrote：>From: Eli Cohen >Add code to accept MAC configuration through vdpa tool. The MAC is>written into the config struct and later can be
On Mon, Oct 25, 2021 at 2:25 PM Wu Zongyong
wrote:
>
> On Mon, Oct 25, 2021 at 12:45:44PM +0800, Jason Wang wrote:
> >
> > 在 2021/10/25 上午10:44, Wu Zongyong 写道:
> > > On Mon, Oct 25, 2021 at 10:22:30AM +0800, Jason Wang wrote:
> > > > On Fri, Oct 22, 2021 at 10:45 AM Wu Zongyong
> > > > wrote:
>
On Mon, Oct 25, 2021 at 3:59 PM Michael S. Tsirkin wrote:
>
> virtblk_setup_cmd returns blk_status_t in an int, callers then assign it
> back to a blk_status_t variable. blk_status_t is either u32 or (more
> typically) u8 so it works, but is inelegant and causes sparse warnings.
>
> Pass the
On Wed, Oct 20, 2021 at 7:57 PM Eugenio Perez Martin
wrote:
>
> On Wed, Oct 20, 2021 at 11:03 AM Jason Wang wrote:
> >
> > On Wed, Oct 20, 2021 at 2:52 PM Eugenio Perez Martin
> > wrote:
> > >
> > > On Wed, Oct 20, 2021 at 4:07 AM Jason Wang wrote:
> > > >
> > > > On Wed, Oct 20, 2021 at 10:02
On Tue, Oct 26, 2021 at 12:03 PM Parav Pandit wrote:
>
> From: Eli Cohen
>
> Add rules to forward packets to the net device's TIR only if the
> destination MAC is equal to the configured MAC. This is required to
> prevent the netdevice from receiving traffic not destined to its
> configured MAC.
On Tue, Oct 26, 2021 at 12:03 PM Parav Pandit wrote:
>
> Cited patch in the fixes tag clears the features bit during reset.
> mlx5 vdpa device feature bits are static decided by device capabilities.
> These feature bits (including VIRTIO_NET_F_MAC) are initialized during
> device addition time.
>
On Tue, Oct 26, 2021 at 12:03 PM Parav Pandit wrote:
>
> Enable user to set the mac address and mtu so that each vdpa device
> can have its own user specified mac address and mtu.
>
> Now that user is enabled to set the mac address, remove the module
> parameter for same.
>
> And example of
> From: Michael S. Tsirkin
> Sent: Tuesday, October 26, 2021 2:45 AM
>
> On Mon, Oct 25, 2021 at 06:35:35PM +, Parav Pandit wrote:
> >
> > > From: Parav Pandit
> > > Sent: Monday, October 25, 2021 6:23 PM
> > >
> > > From: Eli Cohen
> > >
> > > Add code to accept MAC configuration
From: Eli Cohen
Add rules to forward packets to the net device's TIR only if the
destination MAC is equal to the configured MAC. This is required to
prevent the netdevice from receiving traffic not destined to its
configured MAC.
Signed-off-by: Eli Cohen
Reviewed-by: Parav Pandit
---
From: Eli Cohen
Add code to accept MAC configuration through vdpa tool. The MAC is
written into the config struct and later can be retrieved through
get_config().
Examples:
1. Configure MAC while adding a device:
$ vdpa dev add mgmtdev pci/:06:00.2 name vdpa0 mac 00:11:22:33:44:55
2. Show
Cited patch in the fixes tag clears the features bit during reset.
mlx5 vdpa device feature bits are static decided by device capabilities.
These feature bits (including VIRTIO_NET_F_MAC) are initialized during
device addition time.
Clearing features bit in reset callback cleared the
Enable user to set the mac address and mtu so that each vdpa device
can have its own user specified mac address and mtu.
Now that user is enabled to set the mac address, remove the module
parameter for same.
And example of setting mac addr and mtu and view the configuration:
$ vdpa mgmtdev show
$ vdpa dev add name bar mgmtdev vdpasim_net mac 00:11:22:33:44:55 mtu 9000
$ vdpa dev config show
bar: mac 00:11:22:33:44:55 link up link_announce false mtu 9000
$ vdpa dev config show -jp
{
"config": {
"bar": {
"mac": "00:11:22:33:44:55",
"link ": "up",
As subsequent patch adds new structure field with comment, move the
structure comment to follow kernel coding style.
Signed-off-by: Parav Pandit
Reviewed-by: Eli Cohen
Acked-by: Jason Wang
---
include/linux/vdpa.h | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git
Introduce a command to query a device config layout.
An example query of network vdpa device:
$ vdpa dev add name bar mgmtdev vdpasim_net
$ vdpa dev config show
bar: mac 00:35:09:19:48:05 link up link_announce false mtu 1500
$ vdpa dev config show -jp
{
"config": {
"bar": {
Subsequent patches enable get and set configuration either
via management device or via vdpa device' config ops.
This requires synchronization between multiple callers to get and set
config callbacks. Features setting also influence the layout of the
configuration fields endianness.
To avoid
Currently user cannot view the vdpa device config space. Also user
cannot set the mac address and mtu of the vdpa device.
This patchset enables users to set the mac address and mtu of the vdpa
device once the device is created.
If a vendor driver supports such configuration user can set it
On Mon, Oct 25, 2021 at 8:53 PM Parav Pandit wrote:
>
> $ vdpa dev add name bar mgmtdev vdpasim_net mac 00:11:22:33:44:55 mtu 9000
>
> $ vdpa dev config show
> bar: mac 00:11:22:33:44:55 link up link_announce false mtu 9000
>
> $ vdpa dev config show -jp
> {
> "config": {
> "bar": {
>
On Mon, Oct 25, 2021 at 8:53 PM Parav Pandit wrote:
>
> Introduce a command to query a device config layout.
>
> An example query of network vdpa device:
>
> $ vdpa dev add name bar mgmtdev vdpasim_net
>
> $ vdpa dev config show
> bar: mac 00:35:09:19:48:05 link up link_announce false mtu 1500
>
在 2021/10/25 下午2:59, Parav Pandit 写道:
From: Jason Wang
Sent: Monday, October 25, 2021 11:36 AM
在 2021/10/22 上午12:35, Parav Pandit 写道:
Introduce a command to query a device config layout.
An example query of network vdpa device:
$ vdpa dev add name bar mgmtdev vdpasim_net
$ vdpa dev
在 2021/10/25 下午3:08, Parav Pandit 写道:
From: Jason Wang
Sent: Monday, October 25, 2021 12:35 PM
在 2021/10/22 上午12:35, Parav Pandit 写道:
Cited patch in the fixes tag clears the features bit during reset.
mlx5 vdpa device feature bits are static decided by device capabilities.
This is not
在 2021/10/25 下午3:06, Parav Pandit 写道:
From: Jason Wang
Sent: Monday, October 25, 2021 12:31 PM
在 2021/10/22 上午12:35, Parav Pandit 写道:
$ vdpa dev add name bar mgmtdev vdpasim_net mac 00:11:22:33:44:55 mtu
9000
$ vdpa dev config show
bar: mac 00:11:22:33:44:55 link up link_announce false
On Mon, Oct 25, 2021 at 6:22 PM Colin Ian King
wrote:
>
> There is a spelling mistake in a dev_err error message. Fix it.
>
> Signed-off-by: Colin Ian King
> ---
Acked-by: Jason Wang
> drivers/block/virtio_blk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
On Mon, Oct 25, 2021 at 06:35:35PM +, Parav Pandit wrote:
>
> > From: Parav Pandit
> > Sent: Monday, October 25, 2021 6:23 PM
> >
> > From: Eli Cohen
> >
> > Add code to accept MAC configuration through vdpa tool. The MAC is written
> > into the config struct and later can be retrieved
On Mon, Oct 25, 2021 at 01:30:19AM +0300, Max Gurtovoy wrote:
>
> On 10/24/2021 6:49 PM, Michael S. Tsirkin wrote:
> > On Sun, Oct 24, 2021 at 06:29:59PM +0300, Max Gurtovoy wrote:
> > > On 10/24/2021 6:11 PM, Michael S. Tsirkin wrote:
> > > > On Sun, Oct 24, 2021 at 05:19:33PM +0300, Max
> From: Parav Pandit
> Sent: Monday, October 25, 2021 6:23 PM
>
> From: Eli Cohen
>
> Add code to accept MAC configuration through vdpa tool. The MAC is written
> into the config struct and later can be retrieved through get_config().
>
> Examples:
> 1. Configure MAC while adding a device:
On Mon, Oct 25, 2021 at 09:47:34PM +0800, Yongji Xie wrote:
> On Mon, Oct 25, 2021 at 9:20 PM Michael S. Tsirkin wrote:
> >
> > On Mon, Oct 25, 2021 at 05:43:06PM +0800, Xie Yongji wrote:
> > > The block layer can't support the block size larger than
> > > page size yet. If an untrusted device
On Mon, Oct 25, 2021 at 11:04:42AM -0500, michael.chris...@oracle.com wrote:
> On 10/23/21 3:11 PM, Michael S. Tsirkin wrote:
> > On Fri, Oct 22, 2021 at 01:17:26PM -0500, michael.chris...@oracle.com wrote:
> >> On 10/22/21 11:12 AM, michael.chris...@oracle.com wrote:
> >>> On 10/22/21 5:47 AM,
On Mon, Oct 25, 2021 at 10:25:06PM +0800, Xie Yongji wrote:
> The block layer can't support the block size larger than
the block size -> block sizes, or a block size
> page size yet.
And to add to that, a block size that's too small or
not a power of two won't work either, right?
Mention that
On Mon, Oct 25, 2021 at 10:25:02PM +0800, Xie Yongji wrote:
> The block layer can't support the block size larger than
> page size yet, so driver needs to validate the block size
> before setting it. Now this validation is done in device drivers
> with some duplicated codes. This series tries to
On 10/25/21 4:08 AM, Stefano Garzarella wrote:
> On Fri, Oct 22, 2021 at 12:19:06AM -0500, Mike Christie wrote:
>> Convert from vhost dev based helpers to vq ones.
>>
>> Signed-off-by: Mike Christie
>> ---
>> drivers/vhost/vsock.c | 8 +---
>> 1 file changed, 5 insertions(+), 3 deletions(-)
>>
On 10/23/21 3:11 PM, Michael S. Tsirkin wrote:
> On Fri, Oct 22, 2021 at 01:17:26PM -0500, michael.chris...@oracle.com wrote:
>> On 10/22/21 11:12 AM, michael.chris...@oracle.com wrote:
>>> On 10/22/21 5:47 AM, Michael S. Tsirkin wrote:
> diff --git a/include/uapi/linux/vhost.h
On Mon, Oct 25, 2021 at 05:43:06PM +0800, Xie Yongji wrote:
> The block layer can't support the block size larger than
> page size yet. If an untrusted device presents an invalid
> block size in configuration space, it will result in the
> kernel crash something like below:
>
> [ 506.154324]
From: Eli Cohen
Add rules to forward packets to the net device's TIR only if the
destination MAC is equal to the configured MAC. This is required to
prevent the netdevice from receiving traffic not destined to its
configured MAC.
Signed-off-by: Eli Cohen
Reviewed-by: Parav Pandit
---
From: Eli Cohen
Add code to accept MAC configuration through vdpa tool. The MAC is
written into the config struct and later can be retrieved through
get_config().
Examples:
1. Configure MAC while adding a device:
$ vdpa dev add mgmtdev pci/:06:00.2 name vdpa0 mac 00:11:22:33:44:55
2. Show
Cited patch in the fixes tag clears the features bit during reset.
mlx5 vdpa device feature bits are static decided by device capabilities.
Clearing features bit cleared the VIRTIO_NET_F_MAC. Due to this MAC address
provided by the device is not honored.
Fix it by not clearing the static feature
$ vdpa dev add name bar mgmtdev vdpasim_net mac 00:11:22:33:44:55 mtu 9000
$ vdpa dev config show
bar: mac 00:11:22:33:44:55 link up link_announce false mtu 9000
$ vdpa dev config show -jp
{
"config": {
"bar": {
"mac": "00:11:22:33:44:55",
"link ": "up",
Enable user to set the mac address and mtu so that each vdpa device
can have its own user specified mac address and mtu.
Now that user is enabled to set the mac address, remove the module
parameter for same.
And example of setting mac addr and mtu and view the configuration:
$ vdpa mgmtdev show
Introduce a command to query a device config layout.
An example query of network vdpa device:
$ vdpa dev add name bar mgmtdev vdpasim_net
$ vdpa dev config show
bar: mac 00:35:09:19:48:05 link up link_announce false mtu 1500
$ vdpa dev config show -jp
{
"config": {
"bar": {
As subsequent patch adds new structure field with comment, move the
structure comment to follow kernel coding style.
Signed-off-by: Parav Pandit
Reviewed-by: Eli Cohen
Acked-by: Jason Wang
---
include/linux/vdpa.h | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git
Currently user cannot view the vdpa device config space. Also user
cannot set the mac address and mtu of the vdpa device.
This patchset enables users to set the mac address and mtu of the vdpa
device once the device is created.
If a vendor driver supports such configuration user can set it
Subsequent patches enable get and set configuration either
via management device or via vdpa device' config ops.
This requires synchronization between multiple callers to get and set
config callbacks. Features setting also influence the layout of the
configuration fields endianness.
To avoid
> From: Jason Wang
> Sent: Monday, October 25, 2021 11:36 AM
>
> 在 2021/10/22 上午12:35, Parav Pandit 写道:
> > Introduce a command to query a device config layout.
> >
> > An example query of network vdpa device:
> >
> > $ vdpa dev add name bar mgmtdev vdpasim_net
> >
> > $ vdpa dev config show
>
> From: Jason Wang
> Sent: Monday, October 25, 2021 11:33 AM
>
> 在 2021/10/22 上午12:35, Parav Pandit 写道:
> > Subsequent patches enable get and set configuration either via
> > management device or via vdpa device' config ops.
> >
> > This requires synchronization between multiple callers to get
On Fri, Oct 22, 2021 at 12:19:06AM -0500, Mike Christie wrote:
Convert from vhost dev based helpers to vq ones.
Signed-off-by: Mike Christie
---
drivers/vhost/vsock.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c
index
On Mon, Oct 25, 2021 at 11:24:57AM +0300, Max Gurtovoy wrote:
> Maybe we can compare the returned status to BLK_STS_OK. But I see we don't
> do it also in NVMe subsystem so I guess we can assume BLK_STS_OK == 0
> forever.
Jes, BLK_STS_OK == 0 is an intentional allowed short cut. It is not
> From: Michael S. Tsirkin
> Sent: Monday, October 25, 2021 1:38 PM
>
> It depends on what will the user be able to do then.
> Inject packets? Affect RX routing? Use up networking resources?
> NET_ADMIN is a safe choice but we didn't check any capability in the past so
> it
> seems reasonable
On Mon, Oct 25, 2021 at 03:58:54AM -0400, Michael S. Tsirkin wrote:
> virtblk_setup_cmd returns blk_status_t in an int, callers then assign it
> back to a blk_status_t variable. blk_status_t is either u32 or (more
> typically) u8 so it works, but is inelegant and causes sparse warnings.
>
> Pass
On Mon, Oct 25, 2021 at 08:10:15AM +, Parav Pandit wrote:
>
>
> > From: Michael S. Tsirkin
> > Sent: Monday, October 25, 2021 1:39 PM
> >
> > On Mon, Oct 25, 2021 at 07:11:23AM +, Parav Pandit wrote:
> > >
> > >
> > > > From: Jason Wang
> > > > Sent: Monday, October 25, 2021 12:32 PM
On Mon, Oct 25, 2021 at 06:59:56AM +, Parav Pandit wrote:
>
>
> > From: Jason Wang
> > Sent: Monday, October 25, 2021 11:36 AM
> >
> >
> > 在 2021/10/22 上午12:35, Parav Pandit 写道:
> > > Introduce a command to query a device config layout.
> > >
> > > An example query of network vdpa device:
> From: Michael S. Tsirkin
> Sent: Monday, October 25, 2021 1:39 PM
>
> On Mon, Oct 25, 2021 at 07:11:23AM +, Parav Pandit wrote:
> >
> >
> > > From: Jason Wang
> > > Sent: Monday, October 25, 2021 12:32 PM
> > >
> > >
> > > 在 2021/10/22 上午12:35, Parav Pandit 写道:
> > > > Enable user to
On Mon, Oct 25, 2021 at 07:11:23AM +, Parav Pandit wrote:
>
>
> > From: Jason Wang
> > Sent: Monday, October 25, 2021 12:32 PM
> >
> >
> > 在 2021/10/22 上午12:35, Parav Pandit 写道:
> > > Enable user to set the mac address and mtu so that each vdpa device
> > > can have its own user specified
On Mon, Oct 25, 2021 at 07:06:42AM +, Parav Pandit wrote:
>
>
> > From: Jason Wang
> > Sent: Monday, October 25, 2021 12:31 PM
> >
> > 在 2021/10/22 上午12:35, Parav Pandit 写道:
> > > $ vdpa dev add name bar mgmtdev vdpasim_net mac 00:11:22:33:44:55 mtu
> > > 9000
> > >
> > > $ vdpa dev config
ting big SGL for data
> config: i386-randconfig-s001-20211025 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> reproduce:
> # apt-get install sparse
> # sparse version: v0.6.4-dirty
> #
> https://git.kernel.org/pub/scm/linux/ke
virtblk_setup_cmd returns blk_status_t in an int, callers then assign it
back to a blk_status_t variable. blk_status_t is either u32 or (more
typically) u8 so it works, but is inelegant and causes sparse warnings.
Pass the status in blk_status_t in a consistent way.
Reported-by: kernel test
Hi Michael,
> From: Parav Pandit
> Sent: Monday, October 25, 2021 9:14 AM
> > > Thanks for the report. Parav, could you help bisect this please?
> > > I also pushed out a new head with some patches dropped.
> > > Could you test that maybe?
> > >
> > > Thanks!
> >
> > OK I think it's due to
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost
head: 2b109044b081148b58974f5696ffd4383c3e9abb
commit: b2c5221fd074fbb0e57d6707bed5b7386bf430ed [4/47] virtio-blk: avoid
preallocating big SGL for data
config: i386-randconfig-s001-20211025 (attached as .config
> From: Jason Wang
> Sent: Monday, October 25, 2021 12:32 PM
>
>
> 在 2021/10/22 上午12:35, Parav Pandit 写道:
> > Enable user to set the mac address and mtu so that each vdpa device
> > can have its own user specified mac address and mtu.
> > This is done by implementing the management device's
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost
head: 2b109044b081148b58974f5696ffd4383c3e9abb
commit: b2c5221fd074fbb0e57d6707bed5b7386bf430ed [4/47] virtio-blk: avoid
preallocating big SGL for data
config: riscv-nommu_virt_defconfig (attached as .config)
compiler:
> From: Jason Wang
> Sent: Monday, October 25, 2021 12:35 PM
>
> 在 2021/10/22 上午12:35, Parav Pandit 写道:
> > Cited patch in the fixes tag clears the features bit during reset.
> > mlx5 vdpa device feature bits are static decided by device capabilities.
>
>
> This is not what I read at least
在 2021/10/22 上午12:35, Parav Pandit 写道:
From: Eli Cohen
Add code to accept MAC configuration through vdpa tool. The MAC is
written into the config struct and later can be retrieved through
get_config().
Examples:
1. Configure MAC while adding a device:
$ vdpa dev add mgmtdev pci/:06:00.2
> From: Jason Wang
> Sent: Monday, October 25, 2021 12:31 PM
>
> 在 2021/10/22 上午12:35, Parav Pandit 写道:
> > $ vdpa dev add name bar mgmtdev vdpasim_net mac 00:11:22:33:44:55 mtu
> > 9000
> >
> > $ vdpa dev config show
> > bar: mac 00:11:22:33:44:55 link up link_announce false mtu 9000
> >
> >
在 2021/10/22 上午12:35, Parav Pandit 写道:
Cited patch in the fixes tag clears the features bit during reset.
mlx5 vdpa device feature bits are static decided by device capabilities.
This is not what I read at least from mlx5_vdpa_get_features:
static u64 mlx5_vdpa_get_features(struct
在 2021/10/22 上午12:35, Parav Pandit 写道:
Enable user to set the mac address and mtu so that each vdpa device
can have its own user specified mac address and mtu.
This is done by implementing the management device's configuration
layout fields setting callback routine.
Now that user is enabled to
在 2021/10/22 上午12:35, Parav Pandit 写道:
$ vdpa dev add name bar mgmtdev vdpasim_net mac 00:11:22:33:44:55 mtu 9000
$ vdpa dev config show
bar: mac 00:11:22:33:44:55 link up link_announce false mtu 9000
$ vdpa dev config show -jp
{
"config": {
"bar": {
"mac":
> From: Jason Wang
> Sent: Monday, October 25, 2021 11:36 AM
>
>
> 在 2021/10/22 上午12:35, Parav Pandit 写道:
> > Introduce a command to query a device config layout.
> >
> > An example query of network vdpa device:
> >
> > $ vdpa dev add name bar mgmtdev vdpasim_net
> >
> > $ vdpa dev config
在 2021/10/22 上午12:35, Parav Pandit 写道:
As subsequent patch adds new structure field with comment, move the
structure comment to follow kernel coding style.
Signed-off-by: Parav Pandit
Reviewed-by: Eli Cohen
Acked-by: Jason Wang
---
include/linux/vdpa.h | 9 -
1 file
在 2021/10/22 上午12:35, Parav Pandit 写道:
Introduce a command to query a device config layout.
An example query of network vdpa device:
$ vdpa dev add name bar mgmtdev vdpasim_net
$ vdpa dev config show
bar: mac 00:35:09:19:48:05 link up link_announce false mtu 1500
Nit: it looks to me this
在 2021/10/22 上午12:35, Parav Pandit 写道:
Subsequent patches enable get and set configuration either
via management device or via vdpa device' config ops.
This requires synchronization between multiple callers to get and set
config callbacks. Features setting also influence the layout of the
72 matches
Mail list logo
