On Wed, Nov 24, 2021 at 3:22 PM Michael S. Tsirkin wrote:
>
> On Wed, Nov 24, 2021 at 10:33:28AM +0800, Jason Wang wrote:
> > On Wed, Nov 24, 2021 at 10:26 AM Jason Wang wrote:
> > >
> > > On Wed, Nov 24, 2021 at 9:30 AM Michael Ellerman
> > > wrote:
> > > >
> > > > "Michael S. Tsirkin"
On Wed, Nov 24, 2021 at 10:33:28AM +0800, Jason Wang wrote:
> On Wed, Nov 24, 2021 at 10:26 AM Jason Wang wrote:
> >
> > On Wed, Nov 24, 2021 at 9:30 AM Michael Ellerman
> > wrote:
> > >
> > > "Michael S. Tsirkin" writes:
> > > > On Tue, Nov 23, 2021 at 10:25:20AM +0800, Jason Wang wrote:
> >
On Tue, Nov 23, 2021 at 03:01:24PM -0800, Darrick J. Wong wrote:
> On Tue, Nov 09, 2021 at 09:33:03AM +0100, Christoph Hellwig wrote:
> > Use the explicit DAX flag instead of checking the inode flag in the
> > iomap code.
> >
> > Signed-off-by: Christoph Hellwig
>
> Any particular reason to
On Tue, Nov 23, 2021 at 06:47:10PM -0800, Dan Williams wrote:
> On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote:
> >
> > Add a flag so that the file system can easily detect DAX operations.
>
> Looks ok, but I would have preferred a quick note about the rationale
> here before needing to
On Tue, Nov 23, 2021 at 06:56:29PM -0800, Dan Williams wrote:
> On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote:
> >
> > Prepare from removing the block_device from the DAX I/O path by returning
>
> s/from removing/for the removal of/
Fixed.
> > td->dm_dev.bdev = bdev;
> > -
On Tue, Nov 23, 2021 at 06:40:47PM -0800, Dan Williams wrote:
> On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote:
> >
> > Hide the DAX device lookup from the xfs_super.c code.
> >
> > Reviewed-by: Christoph Hellwig
>
> That's an interesting spelling of "Signed-off-by", but patch looks
>
On Tue, Nov 23, 2021 at 02:54:30PM -0800, Darrick J. Wong wrote:
> Nit: no space before the paren ^ here.
Fixed.
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
On Tue, Nov 23, 2021 at 02:53:15PM -0800, Darrick J. Wong wrote:
> > -s64 dax_iomap_zero(loff_t pos, u64 length, struct iomap *iomap)
> > +static loff_t dax_zero_iter(struct iomap_iter *iter, bool *did_zero)
>
> Shouldn't this return value remain s64 to match iomap_iter.processed?
I'll switch it
On Tue, Nov 23, 2021 at 01:46:35PM -0800, Dan Williams wrote:
> > + const struct iomap_ops *ops)
> > +{
> > + unsigned int blocksize = i_blocksize(inode);
> > + unsigned int off = pos & (blocksize - 1);
> > +
> > + /* Block boundary? Nothing to do */
> > + if
On Tue, Nov 23, 2021 at 01:22:13PM -0800, Dan Williams wrote:
> On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote:
> >
> > Factor out a helper for the "manual" zeroing of a DAX range to clean
> > up dax_iomap_zero a lot.
> >
>
> Small / optional fixup below:
Incorporated.
On Tue, Nov 23, 2021 at 02:36:42PM -0800, Darrick J. Wong wrote:
> > - phys_addr_t phys_off = (start_sect + sector) * 512;
> > -
> > - if (pgoff)
> > - *pgoff = PHYS_PFN(phys_off);
> > - if (phys_off % PAGE_SIZE || size % PAGE_SIZE)
>
> AFAICT, we're relying on fs_dax_get_by_bdev
On Tue, Nov 23, 2021 at 02:31:23PM -0800, Darrick J. Wong wrote:
> > - struct super_block *sb = mp->m_super;
> > -
> > - if (!xfs_buftarg_is_dax(sb, mp->m_ddev_targp) &&
> > - (!mp->m_rtdev_targp || !xfs_buftarg_is_dax(sb, mp->m_rtdev_targp))) {
> > + if
On Tue, Nov 23, 2021 at 02:25:55PM -0800, Darrick J. Wong wrote:
> > + if ((get_start_sect(bdev) * SECTOR_SIZE) % PAGE_SIZE ||
> > + (bdev_nr_sectors(bdev) * SECTOR_SIZE) % PAGE_SIZE) {
>
> Do we have to be careful about 64-bit division here, or do we not
> support DAX on 32-bit?
I can't
On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote:
>
> The file system DAX code now does not require the block code. So allow
> building a kernel with fuse DAX but not block layer.
Looks good to me.
Reviewed-by: Dan Williams
___
Virtualization
On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote:
>
> Only build the block based iomap code if CONFIG_BLOCK is set. Currently
> that is always the case, but it will change soon.
Looks good.
Reviewed-by: Dan Williams
___
Virtualization mailing
On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote:
>
> The DAX device <-> block device association is only enabled if
> CONFIG_BLOCK is enabled. Update dax.h to account for that and use
> the right conditions for the fs_put_dax stub as well.
Looks good to me.
Reviewed-by: Dan Williams
On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote:
>
> Remove the last user of ->bdev in dax.c by requiring the file system to
> pass in an address that already includes the DAX offset. As part of the
> only set ->bdev or ->daxdev when actually required in the ->iomap_begin
> methods.
On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote:
>
> Prepare from removing the block_device from the DAX I/O path by returning
s/from removing/for the removal of/
> the partition offset from fs_dax_get_by_bdev so that the file systems
> have it at hand for use during I/O.
>
>
On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote:
>
> While the buffered write iomap ops do work due to the fact that zeroing
> never allocates blocks, the DAX zeroing should use the direct ops just
> like actual DAX I/O.
>
I always wondered about this, change looks good to me.
On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote:
>
> Use the explicit DAX flag instead of checking the inode flag in the
> iomap code.
It's not immediately clear to me why this is a net benefit, are you
anticipating inode-less operations? With reflink and multi-inode
operations a single
On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote:
>
> Add a flag so that the file system can easily detect DAX operations.
Looks ok, but I would have preferred a quick note about the rationale
here before needing to read other patches to figure that out.
If you add that you can add:
On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote:
>
> Hide the DAX device lookup from the xfs_super.c code.
>
> Reviewed-by: Christoph Hellwig
That's an interesting spelling of "Signed-off-by", but patch looks
good to me too. I would have expected a robot to complain about
missing
On Wed, Nov 24, 2021 at 10:26 AM Jason Wang wrote:
>
> On Wed, Nov 24, 2021 at 9:30 AM Michael Ellerman wrote:
> >
> > "Michael S. Tsirkin" writes:
> > > On Tue, Nov 23, 2021 at 10:25:20AM +0800, Jason Wang wrote:
> > >> On Tue, Nov 23, 2021 at 4:24 AM Halil Pasic wrote:
> > >> >
> > >> > On
On Wed, Nov 24, 2021 at 9:30 AM Michael Ellerman wrote:
>
> "Michael S. Tsirkin" writes:
> > On Tue, Nov 23, 2021 at 10:25:20AM +0800, Jason Wang wrote:
> >> On Tue, Nov 23, 2021 at 4:24 AM Halil Pasic wrote:
> >> >
> >> > On Mon, 22 Nov 2021 14:25:26 +0800
> >> > Jason Wang wrote:
> >> >
> >>
David Hildenbrand writes:
> On Thu, Nov 11, 2021 at 11:49 PM Luis Chamberlain wrote:
>>
>> I get the following splats with a kvm guest in idle, after a few seconds
>> it starts:
>>
>> [ 242.412806] INFO: task kworker/6:2:271 blockedfor more than 120 seconds.
>> [ 242.415790] Tainted: G
"Michael S. Tsirkin" writes:
> On Tue, Nov 23, 2021 at 10:25:20AM +0800, Jason Wang wrote:
>> On Tue, Nov 23, 2021 at 4:24 AM Halil Pasic wrote:
>> >
>> > On Mon, 22 Nov 2021 14:25:26 +0800
>> > Jason Wang wrote:
>> >
>> > > I think the fixes are:
>> > >
>> > > 1) fixing the vhost vsock
>> > >
Hi Alexander,
On 11/23/21 5:39 PM, Alexander Lobakin wrote:
[...]
Just commenting on ice here as one example (similar applies to other drivers):
diff --git a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
index 1dd7e84f41f8..7dc287bc3a1a 100644
On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote:
>
> Only call fs_dax_get_by_bdev once the sbi has been allocated and remove
> the need for the dax_dev local variable.
Looks good.
Reviewed-by: Dan Williams
___
Virtualization mailing list
On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote:
>
> Only call fs_dax_get_by_bdev once the sbi has been allocated and remove
> the need for the dax_dev local variable.
Looks good.
Reviewed-by: Dan Williams
___
Virtualization mailing list
On Tue, Nov 9, 2021 at 12:33 AM Christoph Hellwig wrote:
>
> Unshare the DAX and iomap buffered I/O page zeroing code. This code
> previously did a IS_DAX check deep inside the iomap code, which in
> fact was the only DAX check in the code. Instead move these checks
> into the callers. Most
On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote:
>
> Factor out a helper for the "manual" zeroing of a DAX range to clean
> up dax_iomap_zero a lot.
>
Small / optional fixup below:
Reviewed-by: Dan Williams
> Signed-off-by: Christoph Hellwig
> ---
> fs/dax.c | 36
On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote:
>
> The file relative offset must have the same alignment as the storage
> offset, so use that and get rid of the call to iomap_sector.
Agree.
Reviewed-by: Dan Williams
___
Virtualization
On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote:
>
> From: Shiyang Ruan
>
> Add helpers to prepare for using different DAX operations.
>
> Signed-off-by: Shiyang Ruan
> [hch: split from a larger patch + slight cleanups]
> Signed-off-by: Christoph Hellwig
Looks good to me.
On Tue, Nov 9, 2021 at 12:33 AM Christoph Hellwig wrote:
>
> Replace the two steps of dax_iomap_sector and bdev_dax_pgoff with a
> single dax_iomap_pgoff helper that avoids lots of cumbersome sector
> conversions.
Looks good,
Reviewed-by: Dan Williams
>
> Signed-off-by: Christoph Hellwig
>
On Tue, Nov 9, 2021 at 12:33 AM Christoph Hellwig wrote:
>
> Just pass the vm_fault and iomap_iter structures, and figure out the rest
> locally. Note that this requires moving dax_iomap_sector up in the file.
Looks good,
Reviewed-by: Dan Williams
>
> Signed-off-by: Christoph Hellwig
> ---
On Mon, Nov 22, 2021 at 9:58 PM Christoph Hellwig wrote:
>
> On Mon, Nov 22, 2021 at 07:33:06PM -0800, Dan Williams wrote:
> > Is it time to add a "DAX" symbol namespace?
>
> What would be the benefit?
Just the small benefit of identifying DAX core users with a common
grep line, and to indicate
On Thu, Nov 18, 2021 at 3:16 AM Dan Carpenter wrote:
>
> The drm_gem_shmem_get_sg_table() function never returns NULL. It returns
> error pointers on error.
>
> Fixes: c66df701e783 ("drm/virtio: switch from ttm to gem shmem helpers")
> Signed-off-by: Dan Carpenter
> ---
> v2: I originally sent
On Fri, Nov 19, 2021 at 12:37 PM Alejandro Colomar
wrote:
>
> Signed-off-by: Alejandro Colomar
> Cc: Ajit Khaparde
> Cc: Andrew Morton
> Cc: Andy Shevchenko
> Cc: Arnd Bergmann
> Cc: Bjorn Andersson
> Cc: Borislav Petkov
> Cc: Corey Minyard
> Cc: Chris Mason
> Cc: Christian Brauner
>
On 11/23/21 17:35, Zi Yan wrote:
> On 19 Nov 2021, at 10:15, Zi Yan wrote:
From what my understanding, cma required alignment of
max(MAX_ORDER - 1, pageblock_order), because when MIGRATE_CMA was
introduced,
__free_one_page() does not prevent merging two different pageblocks,
On 17.11.21 04:04, Zi Yan wrote:
> On 16 Nov 2021, at 3:58, David Hildenbrand wrote:
>
>> On 15.11.21 20:37, Zi Yan wrote:
>>> From: Zi Yan
>>>
>>> Hi David,
>>
>> Hi,
>>
>> thanks for looking into this.
>>
Hi,
sorry for the delay, I wasn't "actually working" last week, so now I'm
back from
Support identity domains for devices that do not offer the
VIRTIO_IOMMU_F_BYPASS_CONFIG feature, by creating 1:1 mappings between
the virtual and physical address space. Identity domains created this
way still perform noticeably better than DMA domains, because they don't
have the overhead of
To ease identity mapping support, keep the list of reserved regions
sorted.
Reviewed-by: Kevin Tian
Signed-off-by: Jean-Philippe Brucker
---
drivers/iommu/virtio-iommu.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/iommu/virtio-iommu.c
To support identity mappings, the virtio-iommu driver must be able to
represent full 64-bit ranges internally. Pass (start, end) instead of
(start, size) to viommu_add/del_mapping().
Clean comments. The one about the returned size was never true: when
sweeping the whole address space the returned
The VIRTIO_IOMMU_F_BYPASS_CONFIG feature adds a new flag to the ATTACH
request, that creates a bypass domain. Use it to enable identity
domains.
When VIRTIO_IOMMU_F_BYPASS_CONFIG is not supported by the device, we
currently fail attaching to an identity domain. Future patches will
instead create
Add definitions for the VIRTIO_IOMMU_F_BYPASS_CONFIG, which supersedes
VIRTIO_IOMMU_F_BYPASS.
Reviewed-by: Kevin Tian
Signed-off-by: Jean-Philippe Brucker
---
include/uapi/linux/virtio_iommu.h | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git
Support identity domains, allowing to only enable IOMMU protection for a
subset of endpoints (those assigned to userspace, for example). Users
may enable identity domains at compile time
(CONFIG_IOMMU_DEFAULT_PASSTHROUGH), boot time (iommu.passthrough=1) or
runtime (/sys/kernel/iommu_groups/*/type
On Mon, 22 Nov 2021 17:35:24 +0100
Stefano Garzarella wrote:
> The "used length" reported by calling vhost_add_used() must be the
> number of bytes written by the device (using "in" buffers).
>
> In vhost_vsock_handle_tx_kick() the device only reads the guest
> buffers (they are all "out"
On Mon, Nov 22, 2021 at 05:35:23PM +0100, Stefano Garzarella wrote:
> This is a follow-up to Micheal's patch [1] and the discussion with Halil and
> Jason [2].
>
> I made two patches, one to fix the problem and one for cleanup. This should
> simplify the backport of the fix because we've had the
On Mon, Nov 22, 2021 at 04:32:01AM -0500, Michael S. Tsirkin wrote:
> It turns out that vhost vsock violates the virtio spec
> by supplying the out buffer length in the used length
> (should just be the in length).
> As a result, attempts to validate the used length fail with:
>
On Tue, 23 Nov 2021 07:17:05 -0500
"Michael S. Tsirkin" wrote:
> On Mon, Nov 22, 2021 at 02:50:03PM +0100, Halil Pasic wrote:
> > On Mon, 22 Nov 2021 14:25:26 +0800
> > Jason Wang wrote:
> >
> > > On Mon, Nov 22, 2021 at 1:49 PM Halil Pasic wrote:
> > > >
> > > > On Mon, 22 Nov 2021
On Mon, Nov 22, 2021 at 02:50:03PM +0100, Halil Pasic wrote:
> On Mon, 22 Nov 2021 14:25:26 +0800
> Jason Wang wrote:
>
> > On Mon, Nov 22, 2021 at 1:49 PM Halil Pasic wrote:
> > >
> > > On Mon, 22 Nov 2021 06:35:18 +0100
> > > Halil Pasic wrote:
> > >
> > > > > I think it should be a common
On Tue, Nov 23, 2021 at 10:25:20AM +0800, Jason Wang wrote:
> On Tue, Nov 23, 2021 at 4:24 AM Halil Pasic wrote:
> >
> > On Mon, 22 Nov 2021 14:25:26 +0800
> > Jason Wang wrote:
> >
> > > I think the fixes are:
> > >
> > > 1) fixing the vhost vsock
> > > 2) use suppress_used_validation=true to
On 23-11-21, 10:52, Wolfram Sang wrote:
> On Thu, Nov 11, 2021 at 05:04:11PM +0100, Vincent Whitchurch wrote:
> > If a timeout is hit, it can result is incorrect data on the I2C bus
> > and/or memory corruptions in the guest since the device can still be
> > operating on the buffers it was given
On 23.11.21 10:29, Jan Beulich wrote:
On 05.10.2021 09:43, Juergen Gross wrote:
On 30.09.21 14:40, Jan Beulich via Virtualization wrote:
While using a plain (constant) address works, its use needlessly invokes
a SIB addressing mode, making every call site one byte larger than
necessary.
On 05.10.2021 09:43, Juergen Gross wrote:
> On 30.09.21 14:40, Jan Beulich via Virtualization wrote:
>> While using a plain (constant) address works, its use needlessly invokes
>> a SIB addressing mode, making every call site one byte larger than
>> necessary. Instead of using an "i" constraint
On Tue, Nov 23, 2021 at 2:42 PM Eli Cohen wrote:
>
> On Tue, Nov 23, 2021 at 10:28:04AM +0800, Jason Wang wrote:
> > On Mon, Nov 22, 2021 at 11:56 PM Parav Pandit wrote:
> > >
> > >
> > >
> > > > From: Eli Cohen
> > > > Sent: Monday, November 22, 2021 8:37 PM
> > > >
> > > > On Mon, Nov 22,
On Tue, Nov 23, 2021 at 03:49:28PM +0800, Jason Wang wrote:
> On Tue, Nov 23, 2021 at 3:00 PM 苟浩 wrote:
> >
> > Hello,
> >
> > I use `xrandr -o left` to rotate the screen in the kvm virtual machine.
> > When configured as a Virtio graphics card, the screen will freeze after
> > rotating the
On Mon, Nov 22, 2021 at 08:22:21PM +0800, Longpeng(Mike) wrote:
From: Longpeng
The system will crash if we put an uninitialized iova_domain, this
could happen when an error occurs before initializing the iova_domain
in vdpasim_create().
BUG: kernel NULL pointer dereference, address:
58 matches
Mail list logo
