Re: vdpa legacy guest support (was Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero)

2021-12-14 Thread Jason Wang
On Wed, Dec 15, 2021 at 9:05 AM Si-Wei Liu wrote: > > > > On 12/13/2021 9:06 PM, Michael S. Tsirkin wrote: > > On Mon, Dec 13, 2021 at 05:59:45PM -0800, Si-Wei Liu wrote: > >> > >> On 12/12/2021 1:26 AM, Michael S. Tsirkin wrote: > >>> On Fri, Dec 10, 2021 at 05:44:15PM -0800, Si-Wei Liu wrote: >

Re: vdpa legacy guest support (was Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero)

2021-12-14 Thread Si-Wei Liu
On 12/13/2021 9:06 PM, Michael S. Tsirkin wrote: On Mon, Dec 13, 2021 at 05:59:45PM -0800, Si-Wei Liu wrote: On 12/12/2021 1:26 AM, Michael S. Tsirkin wrote: On Fri, Dec 10, 2021 at 05:44:15PM -0800, Si-Wei Liu wrote: Sorry for reviving this ancient thread. I was kinda lost for the

Re: [PATCH 4/5] dax: remove the copy_from_iter and copy_to_iter methods

2021-12-14 Thread Dan Williams
On Tue, Dec 14, 2021 at 12:33 PM Vivek Goyal wrote: > > On Tue, Dec 14, 2021 at 08:41:30AM -0800, Dan Williams wrote: > > On Tue, Dec 14, 2021 at 6:23 AM Vivek Goyal wrote: > > > > > > On Mon, Dec 13, 2021 at 09:23:18AM +0100, Christoph Hellwig wrote: > > > > On Sun, Dec 12, 2021 at 06:44:26AM

Re: [RFC PATCH] virtio: do not reset stateful devices on resume

2021-12-14 Thread Michael S. Tsirkin
On Tue, Dec 14, 2021 at 05:33:05PM +0100, Mikhail Golubev wrote: > From: Anton Yakovlev > > We assume that stateful devices can maintain their state while > suspended. And for this reason they don't have a freeze callback. If > such a device is reset during resume, the device state/context will

Re: [PATCH 4/5] dax: remove the copy_from_iter and copy_to_iter methods

2021-12-14 Thread Vivek Goyal
On Tue, Dec 14, 2021 at 08:41:30AM -0800, Dan Williams wrote: > On Tue, Dec 14, 2021 at 6:23 AM Vivek Goyal wrote: > > > > On Mon, Dec 13, 2021 at 09:23:18AM +0100, Christoph Hellwig wrote: > > > On Sun, Dec 12, 2021 at 06:44:26AM -0800, Dan Williams wrote: > > > > On Fri, Dec 10, 2021 at 6:17 AM

Re: [PATCH 4/5] dax: remove the copy_from_iter and copy_to_iter methods

2021-12-14 Thread Dan Williams
On Tue, Dec 14, 2021 at 6:23 AM Vivek Goyal wrote: > > On Mon, Dec 13, 2021 at 09:23:18AM +0100, Christoph Hellwig wrote: > > On Sun, Dec 12, 2021 at 06:44:26AM -0800, Dan Williams wrote: > > > On Fri, Dec 10, 2021 at 6:17 AM Vivek Goyal wrote: > > > > Going forward, I am wondering should

Re: [PATCH 4/5] dax: remove the copy_from_iter and copy_to_iter methods

2021-12-14 Thread Vivek Goyal
On Mon, Dec 13, 2021 at 09:23:18AM +0100, Christoph Hellwig wrote: > On Sun, Dec 12, 2021 at 06:44:26AM -0800, Dan Williams wrote: > > On Fri, Dec 10, 2021 at 6:17 AM Vivek Goyal wrote: > > > Going forward, I am wondering should virtiofs use flushcache version as > > > well. What if host

Re: [PATCH 5/5] dax: always use _copy_mc_to_iter in dax_copy_to_iter

2021-12-14 Thread Vivek Goyal
On Sun, Dec 12, 2021 at 06:48:05AM -0800, Dan Williams wrote: > On Fri, Dec 10, 2021 at 6:05 AM Vivek Goyal wrote: > > > > On Thu, Dec 09, 2021 at 07:38:28AM +0100, Christoph Hellwig wrote: > > > While using the MC-safe copy routines is rather pointless on a virtual > > > device > > > like

Re: [PATCH v2 00/10] Allow for configuring max number of virtqueue pairs

2021-12-14 Thread Stefano Garzarella
On Tue, Dec 14, 2021 at 11:53:03AM +0200, Eli Cohen wrote: On Tue, Dec 14, 2021 at 10:42:35AM +0100, Stefano Garzarella wrote: Hi Eli, I don't know what's wrong, but I've only received replies through the virtualization@lists.linux-foundation.org mailing list. Even in the archive I can't find

Re: [PATCH v2 00/10] Allow for configuring max number of virtqueue pairs

2021-12-14 Thread Stefano Garzarella
Hi Eli, I don't know what's wrong, but I've only received replies through the virtualization@lists.linux-foundation.org mailing list. Even in the archive I can't find your original series. Adding virtualization-ow...@lists.linux-foundation.org to double check what's going wrong. Thanks,

Re: [PATCH v2 07/10] vdpa: Add support for returning device configuration information

2021-12-14 Thread Jason Wang
On Tue, Dec 14, 2021 at 3:17 PM Eli Cohen wrote: > > On Tue, Dec 14, 2021 at 12:05:38PM +0800, Jason Wang wrote: > > On Mon, Dec 13, 2021 at 10:43 PM Eli Cohen wrote: > > > > > > Add netlink attribute to store flags indicating current state of the > > > device. > > > In addition, introduce a

Re: [PATCH v2 00/10] Allow for configuring max number of virtqueue pairs

2021-12-14 Thread Jason Wang
On Tue, Dec 14, 2021 at 3:32 PM Eli Cohen wrote: > > On Tue, Dec 14, 2021 at 11:17:00AM +0800, Jason Wang wrote: > > On Mon, Dec 13, 2021 at 10:43 PM Eli Cohen wrote: > > > > > > Allow the user to configure the max number of virtqueue pairs for a vdpa > > > instance. The user can then control

Re: [PATCH v2 03/10] vdpa: Read device configuration only if FEATURES_OK

2021-12-14 Thread Jason Wang
On Tue, Dec 14, 2021 at 3:14 PM Eli Cohen wrote: > > On Tue, Dec 14, 2021 at 11:44:06AM +0800, Jason Wang wrote: > > On Mon, Dec 13, 2021 at 10:43 PM Eli Cohen wrote: > > > > > > Avoid reading device configuration during feature negotiation. Read > > > device status and verify that