Re: vdpa legacy guest support (was Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero)

2021-12-15 Thread Michael S. Tsirkin
On Wed, Dec 15, 2021 at 06:01:55PM -0800, Si-Wei Liu wrote: > > > On 12/15/2021 1:33 PM, Michael S. Tsirkin wrote: > > On Wed, Dec 15, 2021 at 12:52:20PM -0800, Si-Wei Liu wrote: > > > > > > On 12/14/2021 6:06 PM, Jason Wang wrote: > > > > On Wed, Dec 15, 2021 at 9:05 AM Si-Wei Liu > > > > wro

Re: [PATCH] virtio_net: fix rx_drops stat for small pkts

2021-12-15 Thread Michael S. Tsirkin
On Thu, Dec 16, 2021 at 11:11:35AM +0800, Wenliang Wang wrote: > We found the stat of rx drops for small pkts does not increment when > build_skb fail, it's not coherent with other mode's rx drops stat. > > Signed-off-by: Wenliang Wang Acked-by: Michael S. Tsirkin > --- > drivers/net/virtio_n

Re: vdpa legacy guest support (was Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero)

2021-12-15 Thread Jason Wang
On Thu, Dec 16, 2021 at 4:52 AM Si-Wei Liu wrote: > > > > On 12/14/2021 6:06 PM, Jason Wang wrote: > > On Wed, Dec 15, 2021 at 9:05 AM Si-Wei Liu wrote: > >> > >> > >> On 12/13/2021 9:06 PM, Michael S. Tsirkin wrote: > >>> On Mon, Dec 13, 2021 at 05:59:45PM -0800, Si-Wei Liu wrote: > On 12/1

Re: [PATCH] virtio_net: fix rx_drops stat for small pkts

2021-12-15 Thread Jason Wang
On Thu, Dec 16, 2021 at 11:12 AM Wenliang Wang wrote: > > We found the stat of rx drops for small pkts does not increment when > build_skb fail, it's not coherent with other mode's rx drops stat. > > Signed-off-by: Wenliang Wang Acked-by: Jason Wang > --- > drivers/net/virtio_net.c | 9 +++---

Re: [PATCH v2 09/10] vdpa: Support reporting max device virtqueues

2021-12-15 Thread Si-Wei Liu
On 12/14/2021 12:22 AM, Eli Cohen wrote: On Mon, Dec 13, 2021 at 05:00:18PM -0800, Si-Wei Liu wrote: On 12/13/2021 6:42 AM, Eli Cohen wrote: Add max_supported_vqs field to struct vdpa_mgmt_dev. Upstream drivers need to feel this value according to the device capabilities. This value is rep

Re: [RFC PATCH] virtio: do not reset stateful devices on resume

2021-12-15 Thread Jason Wang
On Thu, Dec 16, 2021 at 1:27 AM Mikhail Golubev wrote: > > The 12/14/2021 18:26, Michael S. Tsirkin wrote: > > On Tue, Dec 14, 2021 at 05:33:05PM +0100, Mikhail Golubev wrote: > > > From: Anton Yakovlev > > > > > > We assume that stateful devices can maintain their state while > > > suspended. An

Re: vdpa legacy guest support (was Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero)

2021-12-15 Thread Jason Wang
On Thu, Dec 16, 2021 at 10:02 AM Si-Wei Liu wrote: > > > > On 12/15/2021 1:33 PM, Michael S. Tsirkin wrote: > > On Wed, Dec 15, 2021 at 12:52:20PM -0800, Si-Wei Liu wrote: > >> > >> On 12/14/2021 6:06 PM, Jason Wang wrote: > >>> On Wed, Dec 15, 2021 at 9:05 AM Si-Wei Liu wrote: > > On 1

Re: vdpa legacy guest support (was Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero)

2021-12-15 Thread Si-Wei Liu
On 12/15/2021 1:33 PM, Michael S. Tsirkin wrote: On Wed, Dec 15, 2021 at 12:52:20PM -0800, Si-Wei Liu wrote: On 12/14/2021 6:06 PM, Jason Wang wrote: On Wed, Dec 15, 2021 at 9:05 AM Si-Wei Liu wrote: On 12/13/2021 9:06 PM, Michael S. Tsirkin wrote: On Mon, Dec 13, 2021 at 05:59:45PM -080

Re: vdpa legacy guest support (was Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero)

2021-12-15 Thread Michael S. Tsirkin
On Wed, Dec 15, 2021 at 12:52:20PM -0800, Si-Wei Liu wrote: > > > On 12/14/2021 6:06 PM, Jason Wang wrote: > > On Wed, Dec 15, 2021 at 9:05 AM Si-Wei Liu wrote: > > > > > > > > > On 12/13/2021 9:06 PM, Michael S. Tsirkin wrote: > > > > On Mon, Dec 13, 2021 at 05:59:45PM -0800, Si-Wei Liu wrote

Re: vdpa legacy guest support (was Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero)

2021-12-15 Thread Si-Wei Liu
On 12/14/2021 6:06 PM, Jason Wang wrote: On Wed, Dec 15, 2021 at 9:05 AM Si-Wei Liu wrote: On 12/13/2021 9:06 PM, Michael S. Tsirkin wrote: On Mon, Dec 13, 2021 at 05:59:45PM -0800, Si-Wei Liu wrote: On 12/12/2021 1:26 AM, Michael S. Tsirkin wrote: On Fri, Dec 10, 2021 at 05:44:15PM -080

Re: [PATCH 4/5] dax: remove the copy_from_iter and copy_to_iter methods

2021-12-15 Thread Stefan Hajnoczi
On Wed, Dec 15, 2021 at 10:43:33AM -0500, Vivek Goyal wrote: > On Wed, Dec 15, 2021 at 10:30:50AM +, Stefan Hajnoczi wrote: > > On Tue, Dec 14, 2021 at 03:32:43PM -0500, Vivek Goyal wrote: > > > On Tue, Dec 14, 2021 at 08:41:30AM -0800, Dan Williams wrote: > > > > On Tue, Dec 14, 2021 at 6:23 A

Re: [PATCH 4/5] dax: remove the copy_from_iter and copy_to_iter methods

2021-12-15 Thread Dan Williams
On Wed, Dec 15, 2021 at 7:53 AM Vivek Goyal wrote: > > On Tue, Dec 14, 2021 at 03:43:38PM -0800, Dan Williams wrote: > > On Tue, Dec 14, 2021 at 12:33 PM Vivek Goyal wrote: > > > > > > On Tue, Dec 14, 2021 at 08:41:30AM -0800, Dan Williams wrote: > > > > On Tue, Dec 14, 2021 at 6:23 AM Vivek Goya

Re: [PATCH 4/5] dax: remove the copy_from_iter and copy_to_iter methods

2021-12-15 Thread Vivek Goyal
On Tue, Dec 14, 2021 at 03:43:38PM -0800, Dan Williams wrote: > On Tue, Dec 14, 2021 at 12:33 PM Vivek Goyal wrote: > > > > On Tue, Dec 14, 2021 at 08:41:30AM -0800, Dan Williams wrote: > > > On Tue, Dec 14, 2021 at 6:23 AM Vivek Goyal wrote: > > > > > > > > On Mon, Dec 13, 2021 at 09:23:18AM +01

Re: [PATCH 4/5] dax: remove the copy_from_iter and copy_to_iter methods

2021-12-15 Thread Vivek Goyal
On Wed, Dec 15, 2021 at 10:30:50AM +, Stefan Hajnoczi wrote: > On Tue, Dec 14, 2021 at 03:32:43PM -0500, Vivek Goyal wrote: > > On Tue, Dec 14, 2021 at 08:41:30AM -0800, Dan Williams wrote: > > > On Tue, Dec 14, 2021 at 6:23 AM Vivek Goyal wrote: > > > > > > > > On Mon, Dec 13, 2021 at 09:23:1

Re: [PATCH 4/5] dax: remove the copy_from_iter and copy_to_iter methods

2021-12-15 Thread Stefan Hajnoczi
On Tue, Dec 14, 2021 at 03:32:43PM -0500, Vivek Goyal wrote: > On Tue, Dec 14, 2021 at 08:41:30AM -0800, Dan Williams wrote: > > On Tue, Dec 14, 2021 at 6:23 AM Vivek Goyal wrote: > > > > > > On Mon, Dec 13, 2021 at 09:23:18AM +0100, Christoph Hellwig wrote: > > > > On Sun, Dec 12, 2021 at 06:44:2

[PATCH 3/4] dax: remove the DAXDEV_F_SYNC flag

2021-12-15 Thread Christoph Hellwig
Remove the DAXDEV_F_SYNC flag and thus the flags argument to alloc_dax and just let the drivers call set_dax_synchronous directly. Signed-off-by: Christoph Hellwig Reviewed-by: Pankaj Gupta Reviewed-by: Dan Williams --- drivers/dax/bus.c| 3 ++- drivers/dax/super.c | 6 +--

[PATCH 4/4] dax: remove the copy_from_iter and copy_to_iter methods

2021-12-15 Thread Christoph Hellwig
These methods indirect the actual DAX read/write path. In the end pmem uses magic flush and mc safe variants and fuse and dcssblk use plain ones while device mapper picks redirects to the underlying device. Add set_dax_nocache() and set_dax_nomc() APIs to control which copy routines are used to r

[PATCH 2/4] dax: simplify dax_synchronous and set_dax_synchronous

2021-12-15 Thread Christoph Hellwig
Remove the pointless wrappers. Signed-off-by: Christoph Hellwig Reviewed-by: Pankaj Gupta Reviewed-by: Dan Williams --- drivers/dax/super.c | 8 include/linux/dax.h | 12 ++-- 2 files changed, 6 insertions(+), 14 deletions(-) diff --git a/drivers/dax/super.c b/drivers/dax/su

[PATCH 1/4] uio: remove copy_from_iter_flushcache() and copy_mc_to_iter()

2021-12-15 Thread Christoph Hellwig
These two wrappers are never used. Signed-off-by: Christoph Hellwig --- drivers/nvdimm/pmem.c | 4 +--- include/linux/uio.h | 20 +--- 2 files changed, 2 insertions(+), 22 deletions(-) diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c index 4190c8c46ca88..d225bcfa67c

devirtualize kernel access to DAX v2

2021-12-15 Thread Christoph Hellwig
Hi Dan, this series cleans up a few loose end ends and then removes the copy_from_iter and copy_to_iter dax_operations methods in favor of straight calls. Changes since v1: - reword a 'no check' comment - clean up the flags for the copy routine variants - drop the last patch Diffstat: driver