Re: RE: [PATCH v2 3/3] virtio-crypto: implement RSA algorithm

2022-02-17 Thread zhenwei pi
+void virtio_crypto_akcipher_algs_unregister(struct virtio_crypto +*vcrypto) { + int i = 0; + + mutex_lock(_lock); + + for (i = 0; i < ARRAY_SIZE(virtio_crypto_akcipher_algs); i++) { + uint32_t service = virtio_crypto_akcipher_algs[i].service; +

Re: [PATCH] virtio: Add definition for VIRTIO_F_NOTIFICATION_DATA feature flag

2022-02-17 Thread Michael S. Tsirkin
On Thu, Feb 17, 2022 at 06:22:25PM +, Edward Cree wrote: > On 17/02/2022 11:49, Michael S. Tsirkin wrote: > > On Thu, Feb 17, 2022 at 11:55:45AM +0200, Eli Cohen wrote: > >> This is required by iproute2 to display the capabilities of a vdpa based > >> virtio device. > >> > >> Previously,

Re: [PATCH v3 2/4] drivers/net/virtio_net: Added basic RSS support.

2022-02-17 Thread Andrew Melnichenko
Hi all, On Mon, Feb 14, 2022 at 12:09 AM Willem de Bruijn wrote: > > > > > @@ -3113,13 +3270,14 @@ static int virtnet_probe(struct virtio_device > > > > *vdev) > > > > u16 max_queue_pairs; > > > > int mtu; > > > > > > > > - /* Find if host supports multiqueue virtio_net

Re: [PATCH v2] vsock: remove vsock from connected table when connect is interrupted by a signal

2022-02-17 Thread Stefano Garzarella
On Thu, Feb 17, 2022 at 08:13:12AM -0600, Seth Forshee wrote: vsock_connect() expects that the socket could already be in the TCP_ESTABLISHED state when the connecting task wakes up with a signal pending. If this happens the socket will be in the connected table, and it is not removed when the

RE: [PATCH v2 1/3] virtio-crypto: header update

2022-02-17 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Friday, February 11, 2022 4:44 PM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; virtualization@lists.linux-foundation.org; > linux-cry...@vger.kernel.org; qemu-de...@nongnu.org; >

RE: [PATCH v2 2/3] virtio-crypto: introduce akcipher service

2022-02-17 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Friday, February 11, 2022 4:41 PM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; virtualization@lists.linux-foundation.org; > linux-cry...@vger.kernel.org; linux-ker...@vger.kernel.org; >

RE: [PATCH v2 3/3] virtio-crypto: implement RSA algorithm

2022-02-17 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Friday, February 11, 2022 4:41 PM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; virtualization@lists.linux-foundation.org; > linux-cry...@vger.kernel.org; linux-ker...@vger.kernel.org; >

Re: [PATCH] virtio: Add definition for VIRTIO_F_NOTIFICATION_DATA feature flag

2022-02-17 Thread Michael S. Tsirkin
On Thu, Feb 17, 2022 at 11:55:45AM +0200, Eli Cohen wrote: > This is required by iproute2 to display the capabilities of a vdpa based > virtio device. > > Previously, drivers/net/ethernet/sfc/mcdi_pcol.h made use of a private > definition of this flag. Modify the definition to rely on the new >

Re: [PATCH] virtio: Add definition for VIRTIO_F_NOTIFICATION_DATA feature flag

2022-02-17 Thread Stefano Garzarella
On Thu, Feb 17, 2022 at 11:55:45AM +0200, Eli Cohen wrote: This is required by iproute2 to display the capabilities of a vdpa based virtio device. Previously, drivers/net/ethernet/sfc/mcdi_pcol.h made use of a private definition of this flag. Modify the definition to rely on the new generic

Re: [syzbot] WARNING in vhost_dev_cleanup (2)

2022-02-17 Thread Stefano Garzarella
On Thu, Feb 17, 2022 at 8:50 AM Michael S. Tsirkin wrote: > > On Thu, Feb 17, 2022 at 03:39:48PM +0800, Jason Wang wrote: > > On Thu, Feb 17, 2022 at 3:36 PM Michael S. Tsirkin wrote: > > > > > > On Thu, Feb 17, 2022 at 03:34:13PM +0800, Jason Wang wrote: > > > > On Thu, Feb 17, 2022 at 10:01

Re: [PATCH v5 20/22] virtio_net: set the default max ring num

2022-02-17 Thread Xuan Zhuo
On Thu, 17 Feb 2022 15:21:26 +0800, Jason Wang wrote: > On Wed, Feb 16, 2022 at 3:52 PM Xuan Zhuo wrote: > > > > On Wed, 16 Feb 2022 12:14:31 +0800, Jason Wang wrote: > > > On Mon, Feb 14, 2022 at 4:14 PM Xuan Zhuo > > > wrote: > > > > > > > > Sets the default maximum ring num based on

Re: [PATCH] vsock: remove vsock from connected table when connect is interrupted by a signal

2022-02-17 Thread Stefano Garzarella
On Wed, Feb 16, 2022 at 08:14:59PM -0800, Jakub Kicinski wrote: On Wed, 16 Feb 2022 17:11:22 +0100 Stefano Garzarella wrote: On Wed, Feb 16, 2022 at 08:32:22AM -0600, Seth Forshee wrote: >vsock_connect() expects that the socket could already be in the >TCP_ESTABLISHED state when the connecting