Re: [PATCH] vdpa_sim_blk: add support for VIRTIO_BLK_T_FLUSH

2022-05-06 Thread Jason Wang
On Thu, May 5, 2022 at 4:40 PM Stefano Garzarella wrote: > > On Thu, May 05, 2022 at 04:26:24PM +0800, Jason Wang wrote: > >On Fri, Apr 29, 2022 at 3:14 PM Stefano Garzarella > >wrote: > >> > >> On Fri, Apr 29, 2022 at 10:46:40AM +0800, Jason Wang wrote: > >> >On Thu, Apr 28, 2022 at 11:13 PM

Re: [PATCH net-next 5/6] net: virtio: switch to netif_napi_add_weight()

2022-05-06 Thread Jason Wang
On Sat, May 7, 2022 at 1:08 AM Jakub Kicinski wrote: > > virtio netdev driver uses a custom napi weight, switch to the new > API for setting custom weight. > > Signed-off-by: Jakub Kicinski Acked-by: Jason Wang > --- > CC: m...@redhat.com > CC: jasow...@redhat.com > CC:

Re: [PATCH net-next 5/6] net: virtio: switch to netif_napi_add_weight()

2022-05-06 Thread Xuan Zhuo
On Fri, 6 May 2022 10:07:50 -0700, Jakub Kicinski wrote: > virtio netdev driver uses a custom napi weight, switch to the new > API for setting custom weight. > > Signed-off-by: Jakub Kicinski Reviewed-by: Xuan Zhuo > --- > CC: m...@redhat.com > CC: jasow...@redhat.com > CC:

Re: Re: [PATCH 3/4] mm/memofy-failure.c: optimize hwpoison_filter

2022-05-06 Thread zhenwei pi
On 5/7/22 00:28, David Hildenbrand wrote: On 06.05.22 15:38, zhenwei pi wrote: On 5/6/22 16:59, Naoya Horiguchi wrote: On Fri, Apr 29, 2022 at 10:22:05PM +0800, zhenwei pi wrote: In the memory failure procedure, hwpoison_filter has higher priority, if memory_filter() filters the error

Re: [PATCH 3/4] mm/memofy-failure.c: optimize hwpoison_filter

2022-05-06 Thread David Hildenbrand
On 06.05.22 15:38, zhenwei pi wrote: > > > On 5/6/22 16:59, Naoya Horiguchi wrote: >> On Fri, Apr 29, 2022 at 10:22:05PM +0800, zhenwei pi wrote: >>> In the memory failure procedure, hwpoison_filter has higher priority, >>> if memory_filter() filters the error event, there is no need to do >>>

Re: [PATCH] VMCI: Add support for ARM64

2022-05-06 Thread Vitaly Kuznetsov
vd...@vmware.com writes: > From: Vishnu Dasa > > Add support for ARM64 architecture so that the driver can now be built > and VMCI device can be used. > > Update Kconfig file to allow the driver to be built on ARM64 as well. > Fail vmci_guest_probe_device() on ARM64 if the device does not

Re: Re: [PATCH 3/4] mm/memofy-failure.c: optimize hwpoison_filter

2022-05-06 Thread zhenwei pi
On 5/6/22 16:59, Naoya Horiguchi wrote: On Fri, Apr 29, 2022 at 10:22:05PM +0800, zhenwei pi wrote: In the memory failure procedure, hwpoison_filter has higher priority, if memory_filter() filters the error event, there is no need to do the further work. Could you clarify what problem you

[PATCH v6 2/5] virtio-crypto: use private buffer for control request

2022-05-06 Thread zhenwei pi
Originally, all of the control requests share a single buffer( ctrl & input & ctrl_status fields in struct virtio_crypto), this allows queue depth 1 only, the performance of control queue gets limited by this design. In this patch, each request allocates request buffer dynamically, and free

[PATCH v6 4/5] virtio-crypto: adjust dst_len at ops callback

2022-05-06 Thread zhenwei pi
From: lei he For some akcipher operations(eg, decryption of pkcs1pad(rsa)), the length of returned result maybe less than akcipher_req->dst_len, we need to recalculate the actual dst_len through the virt-queue protocol. Cc: Michael S. Tsirkin Cc: Jason Wang Cc: Gonglei Reviewed-by: Gonglei

[PATCH v6 3/5] virtio-crypto: wait ctrl queue instead of busy polling

2022-05-06 Thread zhenwei pi
Originally, after submitting request into virtio crypto control queue, the guest side polls the result from the virt queue. This works like following: CPU0 CPU1 ... CPUx CPUy | | | | \ \

[PATCH v6 5/5] virtio-crypto: enable retry for virtio-crypto-dev

2022-05-06 Thread zhenwei pi
From: lei he Enable retry for virtio-crypto-dev, so that crypto-engine can process cipher-requests parallelly. Cc: Michael S. Tsirkin Cc: Jason Wang Cc: Gonglei Reviewed-by: Gonglei Signed-off-by: lei he Signed-off-by: zhenwei pi --- drivers/crypto/virtio/virtio_crypto_core.c | 3 ++- 1

[PATCH v6 1/5] virtio-crypto: change code style

2022-05-06 Thread zhenwei pi
Use temporary variable to make code easy to read and maintain. /* Pad cipher's parameters */ vcrypto->ctrl.u.sym_create_session.op_type = cpu_to_le32(VIRTIO_CRYPTO_SYM_OP_CIPHER); vcrypto->ctrl.u.sym_create_session.u.cipher.para.algo =

[PATCH v6 0/5] virtio-crypto: Improve performance

2022-05-06 Thread zhenwei pi
v5 -> v6: - Minor fix for crypto_engine_alloc_init_and_set(). - All the patches have been reviewed by Gonglei, add this in patch. Thanks to Gonglei. v4 -> v5: - Fix potentially dereferencing uninitialized variables in 'virtio-crypto: use private buffer for control request'. Thanks to

Re: RE: [PATCH v5 5/5] virtio-crypto: enable retry for virtio-crypto-dev

2022-05-06 Thread Michael S. Tsirkin
On Fri, May 06, 2022 at 05:55:33PM +0800, zhenwei pi wrote: > On 5/6/22 17:34, Gonglei (Arei) wrote: > > > > > > > -Original Message- > > > From: zhenwei pi [mailto:pizhen...@bytedance.com] > > > Sent: Thursday, May 5, 2022 5:24 PM > > > To: Gonglei (Arei) ; m...@redhat.com > > > Cc:

Re: RE: [PATCH v5 5/5] virtio-crypto: enable retry for virtio-crypto-dev

2022-05-06 Thread zhenwei pi
On 5/6/22 17:34, Gonglei (Arei) wrote: -Original Message- From: zhenwei pi [mailto:pizhen...@bytedance.com] Sent: Thursday, May 5, 2022 5:24 PM To: Gonglei (Arei) ; m...@redhat.com Cc: jasow...@redhat.com; herb...@gondor.apana.org.au; linux-ker...@vger.kernel.org;

RE: [PATCH v5 5/5] virtio-crypto: enable retry for virtio-crypto-dev

2022-05-06 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Thursday, May 5, 2022 5:24 PM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; herb...@gondor.apana.org.au; > linux-ker...@vger.kernel.org; virtualization@lists.linux-foundation.org; >

RE: [PATCH v5 4/5] virtio-crypto: adjust dst_len at ops callback

2022-05-06 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Thursday, May 5, 2022 5:24 PM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; herb...@gondor.apana.org.au; > linux-ker...@vger.kernel.org; virtualization@lists.linux-foundation.org; >

RE: [PATCH v5 3/5] virtio-crypto: wait ctrl queue instead of busy polling

2022-05-06 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Thursday, May 5, 2022 5:24 PM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; herb...@gondor.apana.org.au; > linux-ker...@vger.kernel.org; virtualization@lists.linux-foundation.org; >

RE: [PATCH v5 2/5] virtio-crypto: use private buffer for control request

2022-05-06 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Thursday, May 5, 2022 5:24 PM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; herb...@gondor.apana.org.au; > linux-ker...@vger.kernel.org; virtualization@lists.linux-foundation.org; >

RE: [PATCH v5 1/5] virtio-crypto: change code style

2022-05-06 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Thursday, May 5, 2022 5:24 PM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; herb...@gondor.apana.org.au; > linux-ker...@vger.kernel.org; virtualization@lists.linux-foundation.org; >