Re: [PATCH v2 4/4] drivers: virtio: balloon - update inflated memory

2022-08-16 Thread kernel test robot
Hi Alexander, Thank you for the patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on char-misc/char-misc-testing linus/master v6.0-rc1 next-20220816] [cannot apply to soc/for-next] [If your patch is applied to the wrong git tree, kindly drop us

Re: [PATCH 2/2] vDPA: conditionally read fields in virtio-net dev

2022-08-16 Thread Si-Wei Liu
On 8/16/2022 2:08 AM, Zhu, Lingshan wrote: On 8/16/2022 3:58 PM, Si-Wei Liu wrote: On 8/15/2022 6:58 PM, Zhu, Lingshan wrote: On 8/16/2022 7:32 AM, Si-Wei Liu wrote: On 8/15/2022 2:26 AM, Zhu Lingshan wrote: Some fields of virtio-net device config space are conditional on the

Re: [PATCH V5 4/6] vDPA: !FEATURES_OK should not block querying device config space

2022-08-16 Thread Si-Wei Liu
On 8/16/2022 1:29 AM, Zhu, Lingshan wrote: On 8/16/2022 3:41 PM, Si-Wei Liu wrote: Hi Michael, I just noticed this patch got pulled to linux-next prematurely without getting consensus on code review, am not sure why. Hope it was just an oversight. Unfortunately this introduced

Re: [PATCH v2 4/4] drivers: virtio: balloon - update inflated memory

2022-08-16 Thread kernel test robot
Hi Alexander, Thank you for the patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on char-misc/char-misc-testing linus/master v6.0-rc1 next-20220816] [cannot apply to soc/for-next] [If your patch is applied to the wrong git tree, kindly drop us

Re: [PATCH v8 2/2] drm/gem: Don't map imported GEMs

2022-08-16 Thread Rob Clark
On Tue, Aug 16, 2022 at 4:45 AM Dmitry Osipenko wrote: > > On 8/12/22 18:01, Rob Clark wrote: > > On Fri, Aug 12, 2022 at 7:57 AM Rob Clark wrote: > >> > >> On Fri, Aug 12, 2022 at 4:26 AM Dmitry Osipenko > >> wrote: > >>> > >>> On 8/11/22 02:19, Rob Clark wrote: > On Wed, Aug 10, 2022 at

Re: [PATCH V5 4/6] vDPA: !FEATURES_OK should not block querying device config space

2022-08-16 Thread Si-Wei Liu
On 8/16/2022 2:13 PM, Michael S. Tsirkin wrote: On Tue, Aug 16, 2022 at 12:41:21AM -0700, Si-Wei Liu wrote: Hi Michael, I just noticed this patch got pulled to linux-next prematurely without getting consensus on code review, am not sure why. Hope it was just an oversight. Unfortunately this

Re: [PATCH V5 4/6] vDPA: !FEATURES_OK should not block querying device config space

2022-08-16 Thread Michael S. Tsirkin
On Tue, Aug 16, 2022 at 12:41:21AM -0700, Si-Wei Liu wrote: > Hi Michael, > > I just noticed this patch got pulled to linux-next prematurely without > getting consensus on code review, am not sure why. Hope it was just an > oversight. > > Unfortunately this introduced functionality regression to

Re: [PATCH 2/2] vDPA: conditionally read fields in virtio-net dev

2022-08-16 Thread Michael S. Tsirkin
On Tue, Aug 16, 2022 at 09:02:17PM +, Parav Pandit wrote: > > > From: Zhu, Lingshan > > Sent: Tuesday, August 16, 2022 12:19 AM > > > > > > On 8/16/2022 10:32 AM, Parav Pandit wrote: > > >> From: Zhu Lingshan > > >> Sent: Monday, August 15, 2022 5:27 AM > > >> > > >> Some fields of

RE: [PATCH 2/2] vDPA: conditionally read fields in virtio-net dev

2022-08-16 Thread Parav Pandit via Virtualization
> From: Zhu, Lingshan > Sent: Tuesday, August 16, 2022 12:19 AM > > > On 8/16/2022 10:32 AM, Parav Pandit wrote: > >> From: Zhu Lingshan > >> Sent: Monday, August 15, 2022 5:27 AM > >> > >> Some fields of virtio-net device config space are conditional on the > >> feature bits, the spec says:

Re: Potential deadlock in Linux VMCI driver

2022-08-16 Thread Vishnu Dasa via Virtualization
> On Aug 16, 2022, at 11:23 AM, Nadav Amit wrote: > > During my development, I enabled some Linux kernel checkers, specifically > the “sleep in atomic” checker. > > I ran into unrelated issue that appears to be a result of commit > 463713eb6164b6 ("VMCI: dma dg: add support for DMA datagrams

Re: Potential deadlock in Linux VMCI driver

2022-08-16 Thread Nadav Amit via Virtualization
On Aug 16, 2022, at 11:23 AM, Nadav Amit wrote: > During my development, I enabled some Linux kernel checkers, specifically > the “sleep in atomic” checker. > > I ran into unrelated issue that appears to be a result of commit > 463713eb6164b6 ("VMCI: dma dg: add support for DMA datagrams

Potential deadlock in Linux VMCI driver

2022-08-16 Thread Nadav Amit via Virtualization
During my development, I enabled some Linux kernel checkers, specifically the “sleep in atomic” checker. I ran into unrelated issue that appears to be a result of commit 463713eb6164b6 ("VMCI: dma dg: add support for DMA datagrams receive”). IIUC, vmci_read_data() calls wait_event(), which is not

Re: [PATCH 3/6] vsock: add netdev to vhost/virtio vsock

2022-08-16 Thread Michael S. Tsirkin
On Mon, Aug 15, 2022 at 10:56:06AM -0700, Bobby Eshleman wrote: > In order to support usage of qdisc on vsock traffic, this commit > introduces a struct net_device to vhost and virtio vsock. > > Two new devices are created, vhost-vsock for vhost and virtio-vsock > for virtio. The devices are

Re: [PATCH] drivers/virtio: fix repeated words in comments

2022-08-16 Thread Michael S. Tsirkin
On Tue, Aug 16, 2022 at 08:59:59PM +0800, Jilin Yuan wrote: > Delete the redundant word 'the'. > > Signed-off-by: Jilin Yuan send this kind of thing to trivial pls. > --- > drivers/virtio/virtio_mmio.c | 2 +- > drivers/virtio/virtio_pci_modern_dev.c | 2 +- > 2 files changed, 2

Re: [PATCH v8 2/2] drm/gem: Don't map imported GEMs

2022-08-16 Thread Christian König
Am 16.08.22 um 13:44 schrieb Dmitry Osipenko: [SNIP] The other complication I noticed is that we don't seem to keep around the fd after importing to a GEM handle. And I could imagine that doing so could cause issues with too many fd's. So I guess the best thing is to keep the status quo and

Re: [PATCH v2 1/4] Make place for common balloon code

2022-08-16 Thread Michael S. Tsirkin
On Tue, Aug 16, 2022 at 01:56:32PM +0200, Greg Kroah-Hartman wrote: > On Tue, Aug 16, 2022 at 02:47:22PM +0300, Alexander Atanasov wrote: > > Hello, > > > > On 16.08.22 12:49, Greg Kroah-Hartman wrote: > > > On Tue, Aug 16, 2022 at 12:41:14PM +0300, Alexander Atanasov wrote: > > > > > > rename

Re: [PATCH] vduse: Remove include of rwlock.h

2022-08-16 Thread Michael S. Tsirkin
On Tue, Aug 16, 2022 at 12:45:27PM +0200, Sebastian Andrzej Siewior wrote: > On 2022-08-16 04:39:29 [-0400], Michael S. Tsirkin wrote: > > rwlock: detect use outside of spinlock.h > > > > current ifndef does not really prevent including rwlock.h > > directly. > > > > Signed-off-by: Michael S.

Re: [PATCH v2 1/4] Make place for common balloon code

2022-08-16 Thread Greg Kroah-Hartman
On Tue, Aug 16, 2022 at 02:47:22PM +0300, Alexander Atanasov wrote: > Hello, > > On 16.08.22 12:49, Greg Kroah-Hartman wrote: > > On Tue, Aug 16, 2022 at 12:41:14PM +0300, Alexander Atanasov wrote: > > > > rename include/linux/{balloon_compaction.h => balloon_common.h} (99%) > > > > Why

Re: [PATCH] vduse: Remove include of rwlock.h

2022-08-16 Thread Sebastian Andrzej Siewior
On 2022-08-16 04:39:29 [-0400], Michael S. Tsirkin wrote: > rwlock: detect use outside of spinlock.h > > current ifndef does not really prevent including rwlock.h > directly. > > Signed-off-by: Michael S. Tsirkin Actually, yes, this should do the job and render the checkpatch.pl patch, I sent

Re: [PATCH v2 1/4] Make place for common balloon code

2022-08-16 Thread Greg Kroah-Hartman
On Tue, Aug 16, 2022 at 12:41:14PM +0300, Alexander Atanasov wrote: > File already contains code that is common along balloon > drivers so rename it to reflect its contents. > mm/balloon_compaction.c -> mm/balloon_common.c > > Signed-off-by: Alexander Atanasov > --- > MAINTAINERS

RE: [PATCH] crypto-virtio: fix memory-leak

2022-08-16 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Tuesday, August 16, 2022 4:43 PM > To: Lei He > Cc: Gonglei (Arei) ; > herb...@gondor.apana.org.au; virtualization@lists.linux-foundation.org; > linux-cry...@vger.kernel.org; linux-ker...@vger.kernel.org;

Re: [PATCH] crypto-virtio: fix memory-leak

2022-08-16 Thread Michael S. Tsirkin
On Tue, Aug 16, 2022 at 03:59:16PM +0800, Lei He wrote: > From: lei he > > Fix memory-leak for virtio-crypto akcipher request, this problem is > introduced by 59ca6c93387d3(virtio-crypto: implement RSA algorithm). > The leak can be reproduced and tested with the following script > inside virtual

Re: [PATCH V5 4/6] vDPA: !FEATURES_OK should not block querying device config space

2022-08-16 Thread Michael S. Tsirkin
On Tue, Aug 16, 2022 at 04:29:04PM +0800, Zhu, Lingshan wrote: > > > On 8/16/2022 3:41 PM, Si-Wei Liu wrote: > > Hi Michael, > > I just noticed this patch got pulled to linux-next prematurely without > getting consensus on code review, am not sure why. Hope it was just an >

Re: [PATCH] vduse: Remove include of rwlock.h

2022-08-16 Thread Michael S. Tsirkin
On Tue, Aug 16, 2022 at 10:33:57AM +0200, Sebastian Andrzej Siewior wrote: > On 2022-08-16 04:26:59 [-0400], Michael S. Tsirkin wrote: > > #ifndef __LINUX_SPINLOCK_H > > # error "please don't include this file directly" > > #endif > > > > I wonder how does it build. > > spinlock.h is included

Re: [PATCH] vduse: Remove include of rwlock.h

2022-08-16 Thread Sebastian Andrzej Siewior
On 2022-08-16 04:26:59 [-0400], Michael S. Tsirkin wrote: > #ifndef __LINUX_SPINLOCK_H > # error "please don't include this file directly" > #endif > > I wonder how does it build. spinlock.h is included earlier by other means so this define is satisfied. Sebastian

Re: [PATCH] vduse: Remove include of rwlock.h

2022-08-16 Thread Michael S. Tsirkin
On Tue, Aug 16, 2022 at 09:48:16AM +0200, Sebastian Andrzej Siewior wrote: > rwlock.h should not be included directly. Instead linux/splinlock.h > should be included. Including it directly will break the RT build. > > Remove the rwlock.h include. > > Signed-off-by: Sebastian Andrzej Siewior

Re: [PATCH V5 4/6] vDPA: !FEATURES_OK should not block querying device config space

2022-08-16 Thread Michael S. Tsirkin
On Tue, Aug 16, 2022 at 12:41:21AM -0700, Si-Wei Liu wrote: > Hi Michael, > > I just noticed this patch got pulled to linux-next prematurely without > getting consensus on code review, am not sure why. Hope it was just an > oversight. > > Unfortunately this introduced functionality regression to

Re: [PATCH 2/2] vDPA: conditionally read fields in virtio-net dev

2022-08-16 Thread Si-Wei Liu
On 8/16/2022 12:58 AM, Si-Wei Liu wrote: Can you provide the context or link? It shouldn't work like this, otherwise it is breaking uABI. E.g. how will a legacy/BE supporting kernel/device be backward compatible with older vdpa tool (which has knowledge s/has knowledge/has no knowledge/

Re: [PATCH 2/2] vDPA: conditionally read fields in virtio-net dev

2022-08-16 Thread Si-Wei Liu
On 8/15/2022 6:58 PM, Zhu, Lingshan wrote: On 8/16/2022 7:32 AM, Si-Wei Liu wrote: On 8/15/2022 2:26 AM, Zhu Lingshan wrote: Some fields of virtio-net device config space are conditional on the feature bits, the spec says: "The mac address field always exists (though is only valid if

[PATCH] vduse: Remove include of rwlock.h

2022-08-16 Thread Sebastian Andrzej Siewior
rwlock.h should not be included directly. Instead linux/splinlock.h should be included. Including it directly will break the RT build. Remove the rwlock.h include. Signed-off-by: Sebastian Andrzej Siewior --- drivers/vdpa/vdpa_user/iova_domain.h | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH V5 4/6] vDPA: !FEATURES_OK should not block querying device config space

2022-08-16 Thread Si-Wei Liu
Hi Michael, I just noticed this patch got pulled to linux-next prematurely without getting consensus on code review, am not sure why. Hope it was just an oversight. Unfortunately this introduced functionality regression to at least two cases so far as I see: 1. (bogus)

[PATCH 0/6] virtio/vsock: introduce dgrams, sk_buff, and qdisc

2022-08-16 Thread Stefano Garzarella
Hi Bobby, I’m on vacation so I’ll review this series when I’m back on 28th. Please send next versions of this series as RFC until we have at least an agreement on the spec changes. I think will be better to agree on the spec before merge Linux changes. Thanks, Stefano On Monday, August 15,