Re: [PATCH] vdpa: allow provisioning device features

2022-11-14 Thread Jason Wang
On Fri, Nov 11, 2022 at 6:19 PM Michael S. Tsirkin wrote: > > On Fri, Nov 11, 2022 at 03:17:14PM +0800, Jason Wang wrote: > > On Thu, Nov 10, 2022 at 7:01 PM Michael S. Tsirkin wrote: > > > > > > On Thu, Nov 10, 2022 at 03:58:21PM +0800, Jason Wang wrote: > > > > This patch allows device

Re: [PATCH] virtio-crypto: fix memory leak in virtio_crypto_alg_skcipher_close_session()

2022-11-14 Thread Jason Wang
On Mon, Nov 14, 2022 at 7:26 PM Wei Yongjun wrote: > > From: Wei Yongjun > > 'vc_ctrl_req' is alloced in virtio_crypto_alg_skcipher_close_session(), > and should be freed in the invalid ctrl_status->status error handling > case. Otherwise there is a memory leak. > > Fixes: 0756ad15b1fe

Re: [PATH v2 8/8] vdpa/mlx5: Add RX counters to debugfs

2022-11-14 Thread Jason Wang
On Mon, Nov 14, 2022 at 9:18 PM Eli Cohen wrote: > > For each interface, either VLAN tagged or untagged, add two hardware > counters: one for unicast and another for multicast. The counters count > RX packets and bytes and can be read through debugfs: > > $ cat

Re: [PATH v2 5/8] vdpa/mlx5: Avoid overwriting CVQ iotlb

2022-11-14 Thread Jason Wang
On Mon, Nov 14, 2022 at 9:18 PM Eli Cohen wrote: > > When qemu uses different address spaces for data and control virtqueues, > the current code would overwrite the control virtqueue iotlb through the > dup_iotlb call. Fix this by referring to the address space identifier > and the group to asid

Re: [PATCH] virtio: console: remove check for cpkt value when nominating console port

2022-11-14 Thread Andy Bui
On Mon, Nov 14, 2022 at 09:43:48AM -0800, Amit Shah wrote: > > On Sat, 2022-11-12 at 23:45 +1100, Andy Bui wrote: > > The virtIO spec does not specify a need for a value when nominating a > > port as a console port, yet the virtio_console driver requires the value > > to be 1. > > > > Besides

Re: [PATH v2 2/8] vdpa/mlx5: Return error on vlan ctrl commands if not supported

2022-11-14 Thread Jason Wang
On Mon, Nov 14, 2022 at 9:18 PM Eli Cohen wrote: > > Check if VIRTIO_NET_F_CTRL_VLAN is negotiated and return error if > control VQ command is received. > > Signed-off-by: Eli Cohen Acked-by: Jason Wang Thanks > --- > drivers/vdpa/mlx5/net/mlx5_vnet.c | 3 +++ > 1 file changed, 3

Re: [RFC] vdpa: clear the device when opening/releasing it

2022-11-14 Thread Jason Wang
On Mon, Nov 14, 2022 at 12:58 PM Longpeng (Mike, Cloud Infrastructure Service Product Dept.) wrote: > > > > 在 2022/11/14 12:02, Jason Wang 写道: > > On Fri, Nov 11, 2022 at 11:36 PM Longpeng(Mike) > > wrote: > >> > >> From: Longpeng > >> > >> We should do some deeply cleanup when opening or

Re: [PATCH] virtio-crypto: fix memory leak in virtio_crypto_alg_skcipher_close_session()

2022-11-14 Thread zhenwei pi
Looks good to me, thanks! Acked-by: zhenwei pi On 11/14/22 19:07, Wei Yongjun wrote: From: Wei Yongjun 'vc_ctrl_req' is alloced in virtio_crypto_alg_skcipher_close_session(), and should be freed in the invalid ctrl_status->status error handling case. Otherwise there is a memory leak. Fixes:

Re: [PATCH] virtio: console: remove check for cpkt value when nominating console port

2022-11-14 Thread Amit Shah
On Sat, 2022-11-12 at 23:45 +1100, Andy Bui wrote: > The virtIO spec does not specify a need for a value when nominating a > port as a console port, yet the virtio_console driver requires the value > to be 1. > > Besides being a check that's not specified by the virtIO spec, I don't > see

Re: [PATCH] virtio_console: Use an atomic to allocate virtual console numbers

2022-11-14 Thread Greg Kroah-Hartman
On Mon, Nov 14, 2022 at 05:03:40PM +0100, Cédric Le Goater wrote: > On 11/14/22 09:57, Greg Kroah-Hartman wrote: > > On Mon, Nov 14, 2022 at 09:07:52AM +0100, Cédric Le Goater wrote: > > > When a virtio console port is initialized, it is registered as an hvc > > > console using a virtual console

Re: vIOMMU gIOVA to HPA mapping

2022-11-14 Thread Alex Williamson
On Mon, 14 Nov 2022 20:31:49 +0800 "leo...@tom.com" wrote: > Hi, > Here is my application scenario: > 1. The NIC (Network Information Center) passes through to the VM(Virtual > Machine); > 2. The VM uses the user mode driver DPDK; > > Question: > 1. vIOMMU maintains the mapping

Re: [PATCH] vdpa_sim: fix vringh initialization in vdpasim_queue_ready()

2022-11-14 Thread Stefano Garzarella
On Mon, Nov 14, 2022 at 10:13:51AM +0100, Eugenio Perez Martin wrote: On Fri, Nov 11, 2022 at 5:30 PM Stefano Garzarella wrote: On Fri, Nov 11, 2022 at 04:40:33PM +0100, Eugenio Perez Martin wrote: >On Thu, Nov 10, 2022 at 3:13 PM Stefano Garzarella wrote: >> >> When we initialize vringh, we

Re: [PATCH/RFC] virtio_test: A module for testing virtio via userspace

2022-11-14 Thread Michael S. Tsirkin
On Sat, Nov 12, 2022 at 05:19:42PM +0100, Dmitry Vyukov wrote: > I am looking for a test module that allows > to create a transient virtio device that can be used to activate a virtio > driver are communicate with it as if from the host. > Does such thing exist already? > Or how are virtio

Re: [PATCH/RFC] virtio_test: A module for testing virtio via userspace

2022-11-14 Thread Christian Borntraeger
Am 12.11.22 um 17:19 schrieb Dmitry Vyukov: Hi, The original email is from 2009, so I assume you don't have it in your inboxes already. Here is the original email: https://lore.kernel.org/all/200906190927.34831.borntrae...@de.ibm.com/ This patch introduces a prototype for a virtio_test

RE: [PATCH] virtio-crypto: fix memory leak in virtio_crypto_alg_skcipher_close_session()

2022-11-14 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: Wei Yongjun [mailto:weiyong...@huaweicloud.com] > Sent: Monday, November 14, 2022 7:08 PM > To: Michael S. Tsirkin ; Jason Wang > ; Gonglei (Arei) ; > Herbert Xu ; David S. Miller > ; zhenwei pi > Cc: weiyongjun (A) ; >

Re: [PATCH] virtio_console: Use an atomic to allocate virtual console numbers

2022-11-14 Thread Greg Kroah-Hartman
On Mon, Nov 14, 2022 at 09:07:52AM +0100, Cédric Le Goater wrote: > When a virtio console port is initialized, it is registered as an hvc > console using a virtual console number. If a KVM guest is started with > multiple virtio console devices, the same vtermno (or virtual console > number) can

Re: [PATCH 3/6] vduse: Add sysfs interface for irq affinity setup

2022-11-14 Thread Jason Wang
On Mon, Nov 14, 2022 at 4:20 PM Yongji Xie wrote: > > On Mon, Nov 14, 2022 at 3:58 PM Jason Wang wrote: > > > > On Mon, Nov 14, 2022 at 3:16 PM Xie Yongji wrote: > > > > > > Add sysfs interface for each vduse virtqueue to setup > > > irq affinity. This would be useful for performance > > >

Re: [PATCH 1/7] vdpa/mlx5: Fix rule forwarding VLAN to TIR

2022-11-14 Thread Michael S. Tsirkin
On Mon, Nov 14, 2022 at 06:44:30AM +, Eli Cohen wrote: > > From: Jason Wang > > Sent: Monday, 14 November 2022 6:39 > > To: Eli Cohen > > Cc: m...@redhat.com; linux-ker...@vger.kernel.org; > > virtualization@lists.linux- > > foundation.org; si-wei@oracle.com; epere...@redhat.com; > >