Re: [patch net-next v2] net: virtio_net: implement exact header length guest feature

2023-02-21 Thread Jiri Pirko
Tue, Feb 21, 2023 at 06:21:16PM CET, m...@redhat.com wrote: >On Tue, Feb 21, 2023 at 03:47:41PM +0100, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Virtio spec introduced a feature VIRTIO_NET_F_GUEST_HDRLEN which when >> set implicates that the driver provides the exact size of the header. > >OK

Re: [patch net-next v2] net: virtio_net: implement exact header length guest feature

2023-02-21 Thread Jiri Pirko
Tue, Feb 21, 2023 at 05:12:33PM CET, willemdebruijn.ker...@gmail.com wrote: >Jiri Pirko wrote: >> Tue, Feb 21, 2023 at 04:11:53PM CET, willemdebruijn.ker...@gmail.com wrote: >> >Jiri Pirko wrote: >> >> From: Jiri Pirko >> >> >> >> Virtio spec introduced a feature VIRTIO_NET_F_GUEST_HDRLEN which

Re: [PATCH v2 13/13] vdpa: return VHOST_F_LOG_ALL in vhost-vdpa devices

2023-02-21 Thread Jason Wang
在 2023/2/8 17:42, Eugenio Pérez 写道: vhost-vdpa devices can return this features now that blockers have been set in case some features are not met. Expose VHOST_F_LOG_ALL only in that case. Signed-off-by: Eugenio Pérez --- Acked-by: Jason Wang Thanks hw/virtio/vhost-vdpa.c | 3 +--

Re: [PATCH v2 11/13] vdpa: block migration if dev does not have _F_SUSPEND

2023-02-21 Thread Jason Wang
在 2023/2/8 17:42, Eugenio Pérez 写道: Next patches enable devices to be migrated even if vdpa netdev has not been started with x-svq. However, not all devices are migratable, so we need to block migration if we detect that. Block vhost-vdpa device migration if it does not offer _F_SUSPEND and it

Re: [PATCH v2 09/13] vdpa net: block migration if the device has CVQ

2023-02-21 Thread Jason Wang
在 2023/2/8 17:42, Eugenio Pérez 写道: Devices with CVQ needs to migrate state beyond vq state. Leaving this to future series. I may miss something but what is missed to support CVQ/MQ? Thanks Signed-off-by: Eugenio Pérez --- net/vhost-vdpa.c | 6 ++ 1 file changed, 6

Re: [PATCH v2 07/13] vdpa: add vdpa net migration state notifier

2023-02-21 Thread Jason Wang
在 2023/2/8 17:42, Eugenio Pérez 写道: This allows net to restart the device backend to configure SVQ on it. Ideally, these changes should not be net specific. However, the vdpa net backend is the one with enough knowledge to configure everything because of some reasons: * Queues might need to be

Re: [PATCH v2 04/13] vdpa: move vhost reset after get vring base

2023-02-21 Thread Jason Wang
On Tue, Feb 21, 2023 at 3:08 PM Eugenio Perez Martin wrote: > > On Tue, Feb 21, 2023 at 6:36 AM Jason Wang wrote: > > > > > > 在 2023/2/8 17:42, Eugenio Pérez 写道: > > > The function vhost.c:vhost_dev_stop calls vhost operation > > > vhost_dev_start(false). In the case of vdpa it totally reset and

Re: [patch net-next v2] net: virtio_net: implement exact header length guest feature

2023-02-21 Thread Michael S. Tsirkin
On Tue, Feb 21, 2023 at 04:39:32PM +0100, Jiri Pirko wrote: > Tue, Feb 21, 2023 at 04:11:53PM CET, willemdebruijn.ker...@gmail.com wrote: > >Jiri Pirko wrote: > >> From: Jiri Pirko > >> > >> Virtio spec introduced a feature VIRTIO_NET_F_GUEST_HDRLEN which when > >> set implicates that the driver

Re: [patch net-next v2] net: virtio_net: implement exact header length guest feature

2023-02-21 Thread Michael S. Tsirkin
On Tue, Feb 21, 2023 at 03:47:41PM +0100, Jiri Pirko wrote: > From: Jiri Pirko > > Virtio spec introduced a feature VIRTIO_NET_F_GUEST_HDRLEN which when > set implicates that the driver provides the exact size of the header. OK but I feel this is not the important point. The important points

Re: [patch net-next v2] net: virtio_net: implement exact header length guest feature

2023-02-21 Thread Willem de Bruijn
Jiri Pirko wrote: > Tue, Feb 21, 2023 at 04:11:53PM CET, willemdebruijn.ker...@gmail.com wrote: > >Jiri Pirko wrote: > >> From: Jiri Pirko > >> > >> Virtio spec introduced a feature VIRTIO_NET_F_GUEST_HDRLEN which when > >> set implicates that the driver provides the exact size of the header. >

Re: [patch net-next v2] net: virtio_net: implement exact header length guest feature

2023-02-21 Thread Jiri Pirko
Tue, Feb 21, 2023 at 04:11:53PM CET, willemdebruijn.ker...@gmail.com wrote: >Jiri Pirko wrote: >> From: Jiri Pirko >> >> Virtio spec introduced a feature VIRTIO_NET_F_GUEST_HDRLEN which when >> set implicates that the driver provides the exact size of the header. >> >> Quoting the original

Re: [patch net-next v2] net: virtio_net: implement exact header length guest feature

2023-02-21 Thread Alvaro Karsz
> > From: Jiri Pirko > > Virtio spec introduced a feature VIRTIO_NET_F_GUEST_HDRLEN which when > set implicates that the driver provides the exact size of the header. > > Quoting the original virtio spec: > "hdr_len is a hint to the device as to how much of the header needs to > be kept to copy

RE: [patch net-next v2] net: virtio_net: implement exact header length guest feature

2023-02-21 Thread Parav Pandit via Virtualization
> From: Jiri Pirko > Sent: Tuesday, February 21, 2023 9:48 AM > > From: Jiri Pirko > > Virtio spec introduced a feature VIRTIO_NET_F_GUEST_HDRLEN which when > set implicates that the driver provides the exact size of the header. > > Quoting the original virtio spec: > "hdr_len is a hint to

RE: [patch net-next v2] net: virtio_net: implement exact header length guest feature

2023-02-21 Thread Willem de Bruijn
Jiri Pirko wrote: > From: Jiri Pirko > > Virtio spec introduced a feature VIRTIO_NET_F_GUEST_HDRLEN which when > set implicates that the driver provides the exact size of the header. > > Quoting the original virtio spec: > "hdr_len is a hint to the device as to how much of the header needs to >

[patch net-next v2] net: virtio_net: implement exact header length guest feature

2023-02-21 Thread Jiri Pirko
From: Jiri Pirko Virtio spec introduced a feature VIRTIO_NET_F_GUEST_HDRLEN which when set implicates that the driver provides the exact size of the header. Quoting the original virtio spec: "hdr_len is a hint to the device as to how much of the header needs to be kept to copy into each

Re: [patch net-next] net: virtio_net: implement exact header length guest feature

2023-02-21 Thread Jiri Pirko
Tue, Feb 21, 2023 at 02:39:31PM CET, alvaro.ka...@solid-run.com wrote: >Hi, > >Our device offers this feature bit as well. >I don't have concrete numbers, but this feature will save our device a >few cycles for every GSO packet. Cool. I will try to include this into the patch description. Thanks!

Re: [patch net-next] net: virtio_net: implement exact header length guest feature

2023-02-21 Thread Alvaro Karsz
Hi, Our device offers this feature bit as well. I don't have concrete numbers, but this feature will save our device a few cycles for every GSO packet. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org

Re: [patch net-next] net: virtio_net: implement exact header length guest feature

2023-02-21 Thread Jiri Pirko
Mon, Feb 20, 2023 at 11:43:52PM CET, m...@redhat.com wrote: >On Mon, Feb 20, 2023 at 02:56:08PM +0100, Jiri Pirko wrote: >> Mon, Feb 20, 2023 at 01:55:33PM CET, m...@redhat.com wrote: >> >On Mon, Feb 20, 2023 at 09:35:00AM +0100, Jiri Pirko wrote: >> >> Fri, Feb 17, 2023 at 02:47:36PM CET,

Re: [patch net-next] net: virtio_net: implement exact header length guest feature

2023-02-21 Thread Jiri Pirko
Tue, Feb 21, 2023 at 03:38:10AM CET, jasow...@redhat.com wrote: > >在 2023/2/20 21:56, Jiri Pirko 写道: >> Mon, Feb 20, 2023 at 01:55:33PM CET, m...@redhat.com wrote: >> > On Mon, Feb 20, 2023 at 09:35:00AM +0100, Jiri Pirko wrote: >> > > Fri, Feb 17, 2023 at 02:47:36PM CET, m...@redhat.com wrote: >>