Re: [PATCH] mlx5_vdpa: offer VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK

2023-07-04 Thread Jason Wang
On Wed, Jul 5, 2023 at 1:31 PM Michael S. Tsirkin wrote: > > On Wed, Jul 05, 2023 at 01:11:37PM +0800, Jason Wang wrote: > > On Tue, Jul 4, 2023 at 6:16 PM Michael S. Tsirkin wrote: > > > > > > On Mon, Jul 03, 2023 at 05:26:02PM -0700, Si-Wei Liu wrote: > > > > > > > > > > > > On 7/3/2023 8:46

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-07-04 Thread Liang Chen
On Fri, Jun 9, 2023 at 10:57 AM Liang Chen wrote: > > On Thu, Jun 8, 2023 at 8:38 AM Jason Wang wrote: > > > > On Thu, Jun 8, 2023 at 4:17 AM Michael S. Tsirkin wrote: > > > > > > On Wed, Jun 07, 2023 at 05:08:59PM +0800, Liang Chen wrote: > > > > On Tue, May 30, 2023 at 9:19 AM Liang Chen >

Re: [PATCH] mlx5_vdpa: offer VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK

2023-07-04 Thread Michael S. Tsirkin
On Wed, Jul 05, 2023 at 01:11:37PM +0800, Jason Wang wrote: > On Tue, Jul 4, 2023 at 6:16 PM Michael S. Tsirkin wrote: > > > > On Mon, Jul 03, 2023 at 05:26:02PM -0700, Si-Wei Liu wrote: > > > > > > > > > On 7/3/2023 8:46 AM, Michael S. Tsirkin wrote: > > > > On Mon, Jul 03, 2023 at 04:25:14PM

Re: [PATCH] mlx5_vdpa: offer VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK

2023-07-04 Thread Jason Wang
On Tue, Jul 4, 2023 at 6:16 PM Michael S. Tsirkin wrote: > > On Mon, Jul 03, 2023 at 05:26:02PM -0700, Si-Wei Liu wrote: > > > > > > On 7/3/2023 8:46 AM, Michael S. Tsirkin wrote: > > > On Mon, Jul 03, 2023 at 04:25:14PM +0200, Eugenio Pérez wrote: > > > > Offer this backend feature as mlx5 is

Re: [PATCH v2 3/3] vduse: Temporarily disable control queue features

2023-07-04 Thread Maxime Coquelin
On 7/4/23 18:43, Michael S. Tsirkin wrote: On Tue, Jul 04, 2023 at 06:40:45PM +0200, Maxime Coquelin wrote: Virtio-net driver control queue implementation is not safe when used with VDUSE. If the VDUSE application does not reply to control queue messages, it currently ends up hanging the

[linux-next:master] BUILD REGRESSION 1c6f93977947dbba1fc4d250c4eb8a7d4cfdecf1

2023-07-04 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 1c6f93977947dbba1fc4d250c4eb8a7d4cfdecf1 Add linux-next specific files for 20230704 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202306260401.qzlyqpv2-...@intel.com https

Re: [PATCH v2 3/3] vduse: Temporarily disable control queue features

2023-07-04 Thread Michael S. Tsirkin
On Tue, Jul 04, 2023 at 06:40:45PM +0200, Maxime Coquelin wrote: > Virtio-net driver control queue implementation is not safe > when used with VDUSE. If the VDUSE application does not > reply to control queue messages, it currently ends up > hanging the kernel thread sending this command. > >

[PATCH v2 3/3] vduse: Temporarily disable control queue features

2023-07-04 Thread Maxime Coquelin
Virtio-net driver control queue implementation is not safe when used with VDUSE. If the VDUSE application does not reply to control queue messages, it currently ends up hanging the kernel thread sending this command. Some work is on-going to make the control queue implementation robust with

[PATCH v2 1/3] vduse: validate block features only with block devices

2023-07-04 Thread Maxime Coquelin
This patch is preliminary work to enable network device type support to VDUSE. As VIRTIO_BLK_F_CONFIG_WCE shares the same value as VIRTIO_NET_F_HOST_TSO4, we need to restrict its check to Virtio-blk device type. Acked-by: Jason Wang Reviewed-by: Xie Yongji Signed-off-by: Maxime Coquelin ---

[PATCH v2 2/3] vduse: enable Virtio-net device type

2023-07-04 Thread Maxime Coquelin
This patch adds Virtio-net device type to the supported devices types. Initialization fails if the device does not support VIRTIO_F_VERSION_1 feature, in order to guarantee the configuration space is read-only. Acked-by: Jason Wang Reviewed-by: Xie Yongji Signed-off-by: Maxime Coquelin ---

[PATCH v2 0/3] vduse: add support for networking devices

2023-07-04 Thread Maxime Coquelin
This small series enables virtio-net device type in VDUSE. With it, basic operation have been tested, both with virtio-vdpa and vhost-vdpa using DPDK Vhost library series adding VDUSE support using split rings layout (merged in DPDK v23.07-rc1). Control queue support (and so multiqueue) has also

Re: [PATCH] vdpa: reject F_ENABLE_AFTER_DRIVER_OK if backend does not support it

2023-07-04 Thread Michael S. Tsirkin
On Tue, Jul 04, 2023 at 01:36:11PM +0200, Eugenio Perez Martin wrote: > On Tue, Jul 4, 2023 at 12:38 PM Michael S. Tsirkin wrote: > > > > On Tue, Jul 04, 2023 at 12:25:32PM +0200, Eugenio Perez Martin wrote: > > > On Mon, Jul 3, 2023 at 4:52 PM Michael S. Tsirkin wrote: > > > > > > > > On Mon,

Re: [PATCH v1 0/2] vduse: add support for networking devices

2023-07-04 Thread Maxime Coquelin
On 7/4/23 11:59, Michael S. Tsirkin wrote: On Tue, Jul 04, 2023 at 10:43:07AM +0200, Maxime Coquelin wrote: On 7/3/23 23:45, Michael S. Tsirkin wrote: On Mon, Jul 03, 2023 at 09:43:49AM +0200, Maxime Coquelin wrote: On 7/3/23 08:44, Jason Wang wrote: On Sun, Jul 2, 2023 at 9:37 PM

Re: [PATCH] vdpa: reject F_ENABLE_AFTER_DRIVER_OK if backend does not support it

2023-07-04 Thread Michael S. Tsirkin
On Tue, Jul 04, 2023 at 12:25:32PM +0200, Eugenio Perez Martin wrote: > On Mon, Jul 3, 2023 at 4:52 PM Michael S. Tsirkin wrote: > > > > On Mon, Jul 03, 2023 at 04:22:18PM +0200, Eugenio Pérez wrote: > > > With the current code it is accepted as long as userland send it. > > > > > > Although

Re: [PATCH] mlx5_vdpa: offer VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK

2023-07-04 Thread Michael S. Tsirkin
On Mon, Jul 03, 2023 at 05:26:02PM -0700, Si-Wei Liu wrote: > > > On 7/3/2023 8:46 AM, Michael S. Tsirkin wrote: > > On Mon, Jul 03, 2023 at 04:25:14PM +0200, Eugenio Pérez wrote: > > > Offer this backend feature as mlx5 is compatible with it. It allows it > > > to do live migration with CVQ,

Re: [PATCH v1 0/2] vduse: add support for networking devices

2023-07-04 Thread Michael S. Tsirkin
On Tue, Jul 04, 2023 at 10:43:07AM +0200, Maxime Coquelin wrote: > > > On 7/3/23 23:45, Michael S. Tsirkin wrote: > > On Mon, Jul 03, 2023 at 09:43:49AM +0200, Maxime Coquelin wrote: > > > > > > On 7/3/23 08:44, Jason Wang wrote: > > > > On Sun, Jul 2, 2023 at 9:37 PM Michael S. Tsirkin > > >

Re: [PATCH v1 0/2] vduse: add support for networking devices

2023-07-04 Thread Maxime Coquelin
On 7/3/23 23:45, Michael S. Tsirkin wrote: On Mon, Jul 03, 2023 at 09:43:49AM +0200, Maxime Coquelin wrote: On 7/3/23 08:44, Jason Wang wrote: On Sun, Jul 2, 2023 at 9:37 PM Michael S. Tsirkin wrote: On Tue, Jun 27, 2023 at 01:36:50PM +0200, Maxime Coquelin wrote: This small series

Re: Re: [PATCH] virtio_ring: use u32 for virtio_max_dma_size

2023-07-04 Thread zhenwei pi via Virtualization
On 7/4/23 14:21, Michael S. Tsirkin wrote: On Wed, May 10, 2023 at 10:54:37AM +0800, zhenwei pi wrote: Both split ring and packed ring use 32bits to describe the length of a descriptor: see struct vring_desc and struct vring_packed_desc. This means the max segment size supported by virtio is

Re: [PATCH] virtio_ring: use u32 for virtio_max_dma_size

2023-07-04 Thread Michael S. Tsirkin
On Wed, May 10, 2023 at 10:54:37AM +0800, zhenwei pi wrote: > Both split ring and packed ring use 32bits to describe the length of > a descriptor: see struct vring_desc and struct vring_packed_desc. > This means the max segment size supported by virtio is U32_MAX. > > An example of